diff mbox series

[v3,2/2] ARM: dts: imx6: exchange fallback and specific compatible string

Message ID 1712652644-28887-3-git-send-email-shengjiu.wang@nxp.com (mailing list archive)
State Superseded
Headers show
Series convert imx-audio-spdif.txt to YAML | expand

Commit Message

Shengjiu Wang April 9, 2024, 8:50 a.m. UTC 
exchange fallback and specific compatible string for spdif sound card.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-sabreauto.dtsi | 4 ++--
 arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi        | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Fabio Estevam April 9, 2024, 10:02 a.m. UTC | #1 
On Tue, Apr 9, 2024 at 6:08 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
>
> exchange fallback and specific compatible string for spdif sound card.

Ok, but please explain the reason.
Fabio Estevam April 9, 2024, 10:06 a.m. UTC | #2 
On Tue, Apr 9, 2024 at 7:02 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Tue, Apr 9, 2024 at 6:08 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
> >
> > exchange fallback and specific compatible string for spdif sound card.
>
> Ok, but please explain the reason.

I mean, why can't these two .dts files be changed to

compatible =  "fsl,imx-audio-spdif";

, like all the others?
Shengjiu Wang April 9, 2024, 11:22 a.m. UTC | #3 
On Tue, Apr 9, 2024 at 6:06 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> On Tue, Apr 9, 2024 at 7:02 AM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > On Tue, Apr 9, 2024 at 6:08 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote:
> > >
> > > exchange fallback and specific compatible string for spdif sound card.
> >
> > Ok, but please explain the reason.
>
> I mean, why can't these two .dts files be changed to
>
> compatible =  "fsl,imx-audio-spdif";
>
> , like all the others?

The specific compatible string should be first place
as the dts rules I think. This patch is just to fix this problem.

For removing the specific compatible string,  I think we can
do that.  but this change may be out of the scope of this patch
series I think.

So I just change the order of compatible strings

best regards
wang shengjiu
Conor Dooley April 11, 2024, 3:55 p.m. UTC | #4 
On Tue, Apr 09, 2024 at 04:50:44PM +0800, Shengjiu Wang wrote:
> exchange fallback and specific compatible string for spdif sound card.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-sabreauto.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-sabreauto.dtsi
index 68e97180d33e..51517e27418c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-sabreauto.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-sabreauto.dtsi
@@ -144,8 +144,8 @@  sound-cs42888 {
 	};
 
 	sound-spdif {
-		compatible = "fsl,imx-audio-spdif",
-			   "fsl,imx-sabreauto-spdif";
+		compatible = "fsl,imx-sabreauto-spdif",
+			     "fsl,imx-audio-spdif";
 		model = "imx-spdif";
 		spdif-controller = <&spdif>;
 		spdif-in;
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi
index c6e85e4a0883..67872c16372a 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi
@@ -184,8 +184,8 @@  panel_in: endpoint {
 	};
 
 	sound-spdif {
-		compatible = "fsl,imx-audio-spdif",
-			   "fsl,imx6sx-sdb-spdif";
+		compatible = "fsl,imx6sx-sdb-spdif",
+			     "fsl,imx-audio-spdif";
 		model = "imx-spdif";
 		spdif-controller = <&spdif>;
 		spdif-out;