| Message ID | 20240330-b4-module-owner-drm-mediatek-v1-1-fd5c4b8d633e@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/mediatek: drop driver owner initialization | expand |
Hi, Krzysztof: On Sat, 2024-03-30 at 21:43 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Core in platform_driver_register() already sets the .owner, so > driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). For the whole series, Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/gpu/drm/mediatek/mtk_disp_aal.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_aal.c > b/drivers/gpu/drm/mediatek/mtk_disp_aal.c > index 40fe403086c3..f6f2c24abc93 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_aal.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_aal.c > @@ -223,7 +223,6 @@ struct platform_driver mtk_disp_aal_driver = { > .remove_new= mtk_disp_aal_remove, > .driver= { > .name= "mediatek-disp-aal", > -.owner= THIS_MODULE, > .of_match_table = mtk_disp_aal_driver_dt_match, > }, > }; > > -- > 2.34.1 >
On 01/04/2024 05:44, CK Hu (胡俊光) wrote: > Hi, Krzysztof: > > On Sat, 2024-03-30 at 21:43 +0100, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> Core in platform_driver_register() already sets the .owner, so >> driver >> does not need to. Whatever is set here will be anyway overwritten by >> main driver calling platform_driver_register(). > > For the whole series, > > Reviewed-by: CK Hu <ck.hu@mediatek.com> For the tag to work on entire series, you need to provide it to the cover letter. Anyway, Philipp, Everything good here from your side? Will you be able to take everything to mediatek/drm? I think drm window is slowly closing. Best regards, Krzysztof
Hi, Krzysztof: On Wed, 2024-04-10 at 09:43 +0200, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 01/04/2024 05:44, CK Hu (胡俊光) wrote: > > Hi, Krzysztof: > > > > On Sat, 2024-03-30 at 21:43 +0100, Krzysztof Kozlowski wrote: > >> > >> External email : Please do not click links or open attachments > until > >> you have verified the sender or the content. > >> Core in platform_driver_register() already sets the .owner, so > >> driver > >> does not need to. Whatever is set here will be anyway overwritten > by > >> main driver calling platform_driver_register(). > > > > For the whole series, > > > > Reviewed-by: CK Hu <ck.hu@mediatek.com> > > For the tag to work on entire series, you need to provide it to the > cover letter. > > Anyway, Philipp, > > Everything good here from your side? Will you be able to take > everything > to mediatek/drm? I think drm window is slowly closing. I've applied to mediatek_drm_next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, CK > > Best regards, > Krzysztof >
diff --git a/drivers/gpu/drm/mediatek/mtk_disp_aal.c b/drivers/gpu/drm/mediatek/mtk_disp_aal.c index 40fe403086c3..f6f2c24abc93 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_aal.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_aal.c @@ -223,7 +223,6 @@ struct platform_driver mtk_disp_aal_driver = { .remove_new = mtk_disp_aal_remove, .driver = { .name = "mediatek-disp-aal", - .owner = THIS_MODULE, .of_match_table = mtk_disp_aal_driver_dt_match, }, };
Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/gpu/drm/mediatek/mtk_disp_aal.c | 1 - 1 file changed, 1 deletion(-)