| Message ID | 20240405085208.32227-2-j-choudhary@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix reg ranges for dma-controller node | expand |
Thanks for this fix Jayesh On 4/5/2024 2:22 PM, Jayesh Choudhary wrote: > The TX Channel Realtime Registers region 'tchanrt' is 128KB and Ring > Realtime Registers region 'ringrt' is 2MB as shown in memory map in > the TRM[0]. So fix ranges for those reg-regions. Minor one, but it will be better to say that you are fixing these register ranges for PKTDMA . Something like that For PKTDMA, The TX Channel Realtime Registers region 'tchanrt' .... Also, it will help reviewer if you can mention which section in TRM[0], holding memory map . If you are doing v2 then please take care of above in commit message. rest for whole series LGTM > [0]: <https://www.ti.com/lit/pdf/spruiv7> > > Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes") > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > index e9cffca073ef..e10cc9fc0b10 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > @@ -141,8 +141,8 @@ main_pktdma: dma-controller@485c0000 { > compatible = "ti,am64-dmss-pktdma"; > reg = <0x00 0x485c0000 0x00 0x100>, > <0x00 0x4a800000 0x00 0x20000>, > - <0x00 0x4aa00000 0x00 0x40000>, > - <0x00 0x4b800000 0x00 0x400000>, > + <0x00 0x4aa00000 0x00 0x20000>, > + <0x00 0x4b800000 0x00 0x200000>, > <0x00 0x485e0000 0x00 0x10000>, > <0x00 0x484a0000 0x00 0x2000>, > <0x00 0x484c0000 0x00 0x2000>,
Hello Udit, On 10/04/24 15:36, Kumar, Udit wrote: > Thanks for this fix Jayesh > > On 4/5/2024 2:22 PM, Jayesh Choudhary wrote: >> The TX Channel Realtime Registers region 'tchanrt' is 128KB and Ring >> Realtime Registers region 'ringrt' is 2MB as shown in memory map in >> the TRM[0]. So fix ranges for those reg-regions. > > Minor one, but it will be better to say that you are fixing these > register ranges for PKTDMA . > > Something like that The cover-letter[0] for the series does mention that the changes are for DMASS0_PKTDMA_RINGRT and DMASS0_PKTDMA_TCHANRT with the current and correct region size. It also mentions the section and the Table from where we can check them. {*** section for Main Memory Map (Table 2-1)} [0]: https://lore.kernel.org/all/20240405085208.32227-1-j-choudhary@ti.com/ It was same check across all platform so added in cover letter. But I will add that in each patch. Thanks, Jayesh > > For PKTDMA, The TX Channel Realtime Registers region 'tchanrt' .... > > Also, it will help reviewer if you can mention which section in TRM[0], > holding memory map . > > If you are doing v2 then please take care of above in commit message. > > rest for whole series > > LGTM > > > >> [0]: <https://www.ti.com/lit/pdf/spruiv7> >> >> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral >> nodes") >> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >> b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >> index e9cffca073ef..e10cc9fc0b10 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi >> @@ -141,8 +141,8 @@ main_pktdma: dma-controller@485c0000 { >> compatible = "ti,am64-dmss-pktdma"; >> reg = <0x00 0x485c0000 0x00 0x100>, >> <0x00 0x4a800000 0x00 0x20000>, >> - <0x00 0x4aa00000 0x00 0x40000>, >> - <0x00 0x4b800000 0x00 0x400000>, >> + <0x00 0x4aa00000 0x00 0x20000>, >> + <0x00 0x4b800000 0x00 0x200000>, >> <0x00 0x485e0000 0x00 0x10000>, >> <0x00 0x484a0000 0x00 0x2000>, >> <0x00 0x484c0000 0x00 0x2000>,
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi index e9cffca073ef..e10cc9fc0b10 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -141,8 +141,8 @@ main_pktdma: dma-controller@485c0000 { compatible = "ti,am64-dmss-pktdma"; reg = <0x00 0x485c0000 0x00 0x100>, <0x00 0x4a800000 0x00 0x20000>, - <0x00 0x4aa00000 0x00 0x40000>, - <0x00 0x4b800000 0x00 0x400000>, + <0x00 0x4aa00000 0x00 0x20000>, + <0x00 0x4b800000 0x00 0x200000>, <0x00 0x485e0000 0x00 0x10000>, <0x00 0x484a0000 0x00 0x2000>, <0x00 0x484c0000 0x00 0x2000>,
The TX Channel Realtime Registers region 'tchanrt' is 128KB and Ring Realtime Registers region 'ringrt' is 2MB as shown in memory map in the TRM[0]. So fix ranges for those reg-regions. [0]: <https://www.ti.com/lit/pdf/spruiv7> Fixes: c37c58fdeb8a ("arm64: dts: ti: k3-am62: Add more peripheral nodes") Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> --- arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)