| Message ID | 5e02d887bc93a4212499c3bd13b36c401cc19081.1712741871.git.thalia@archibald.dev (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | fast-import: tighten parsing of paths | expand |
Thalia Archibald <thalia@archibald.dev> writes: > The former is somewhat imprecise. The latter became out of sync with the > behavior in e814c39c2f (fast-import: refactor parsing of spaces, > 2014-06-18). > > Signed-off-by: Thalia Archibald <thalia@archibald.dev> > --- > builtin/fast-import.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks for being careful. Looking good. > > diff --git a/builtin/fast-import.c b/builtin/fast-import.c > index 98096b6fa7..fd23a00150 100644 > --- a/builtin/fast-import.c > +++ b/builtin/fast-import.c > @@ -2210,7 +2210,7 @@ static int parse_mapped_oid_hex(const char *hex, struct object_id *oid, const ch > * > * idnum ::= ':' bigint; > * > - * Return the first character after the value in *endptr. > + * Update *endptr to point to the first character after the value. > * > * Complain if the following character is not what is expected, > * either a space or end of the string. > @@ -2243,8 +2243,8 @@ static uintmax_t parse_mark_ref_eol(const char *p) > } > > /* > - * Parse the mark reference, demanding a trailing space. Return a > - * pointer to the space. > + * Parse the mark reference, demanding a trailing space. Update *p to > + * point to the first character after the space. > */ > static uintmax_t parse_mark_ref_space(const char **p) > {
diff --git a/builtin/fast-import.c b/builtin/fast-import.c index 98096b6fa7..fd23a00150 100644 --- a/builtin/fast-import.c +++ b/builtin/fast-import.c @@ -2210,7 +2210,7 @@ static int parse_mapped_oid_hex(const char *hex, struct object_id *oid, const ch * * idnum ::= ':' bigint; * - * Return the first character after the value in *endptr. + * Update *endptr to point to the first character after the value. * * Complain if the following character is not what is expected, * either a space or end of the string. @@ -2243,8 +2243,8 @@ static uintmax_t parse_mark_ref_eol(const char *p) } /* - * Parse the mark reference, demanding a trailing space. Return a - * pointer to the space. + * Parse the mark reference, demanding a trailing space. Update *p to + * point to the first character after the space. */ static uintmax_t parse_mark_ref_space(const char **p) {
The former is somewhat imprecise. The latter became out of sync with the behavior in e814c39c2f (fast-import: refactor parsing of spaces, 2014-06-18). Signed-off-by: Thalia Archibald <thalia@archibald.dev> --- builtin/fast-import.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)