diff mbox series

[rdma-next,1/1] RDMA/mana_ib: remove useless return values from dbg prints

Message ID 1712672465-29960-1-git-send-email-kotaranov@linux.microsoft.com (mailing list archive)
State Accepted
Headers show
Series [rdma-next,1/1] RDMA/mana_ib: remove useless return values from dbg prints | expand

Commit Message

Konstantin Taranov April 9, 2024, 2:21 p.m. UTC 
From: Konstantin Taranov <kotaranov@microsoft.com>

Remove printing ret value on success as it was always 0.

Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
---
 drivers/infiniband/hw/mana/main.c | 4 +---
 drivers/infiniband/hw/mana/mr.c   | 2 +-
 drivers/infiniband/hw/mana/qp.c   | 6 +++---
 3 files changed, 5 insertions(+), 7 deletions(-)


base-commit: f10242b3da908dc9d4bfa040e6511a5b86522499

Comments

Long Li April 11, 2024, 4:18 a.m. UTC | #1 
> Subject: [PATCH rdma-next 1/1] RDMA/mana_ib: remove useless return
> values from dbg prints
> 
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Remove printing ret value on success as it was always 0.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
Reviewed-by: Long Li <longli@microsoft.com>
Leon Romanovsky April 11, 2024, 11:30 a.m. UTC | #2 
On Tue, 09 Apr 2024 07:21:05 -0700, Konstantin Taranov wrote:
> Remove printing ret value on success as it was always 0.
> 
> 

Applied, thanks!

[1/1] RDMA/mana_ib: remove useless return values from dbg prints
      https://git.kernel.org/rdma/rdma/c/c8fc935f4b198d

Best regards,
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c
index 4524c6b80748..b31dcff32699 100644
--- a/drivers/infiniband/hw/mana/main.c
+++ b/drivers/infiniband/hw/mana/main.c
@@ -261,9 +261,7 @@  int mana_ib_create_queue(struct mana_ib_dev *mdev, u64 addr, u32 size,
 	}
 	queue->umem = umem;
 
-	ibdev_dbg(&mdev->ib_dev,
-		  "create_dma_region ret %d gdma_region 0x%llx\n",
-		  err, queue->gdma_region);
+	ibdev_dbg(&mdev->ib_dev, "created dma region 0x%llx\n", queue->gdma_region);
 
 	return 0;
 free_umem:
diff --git a/drivers/infiniband/hw/mana/mr.c b/drivers/infiniband/hw/mana/mr.c
index b70b13484f09..4f13423ecdbd 100644
--- a/drivers/infiniband/hw/mana/mr.c
+++ b/drivers/infiniband/hw/mana/mr.c
@@ -135,7 +135,7 @@  struct ib_mr *mana_ib_reg_user_mr(struct ib_pd *ibpd, u64 start, u64 length,
 	}
 
 	ibdev_dbg(ibdev,
-		  "create_dma_region ret %d gdma_region %llx\n", err,
+		  "created dma region for user-mr 0x%llx\n",
 		  dma_region_handle);
 
 	mr_params.pd_handle = pd->pd_handle;
diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c
index ef0a6dc664d0..6cecf76426d4 100644
--- a/drivers/infiniband/hw/mana/qp.c
+++ b/drivers/infiniband/hw/mana/qp.c
@@ -219,8 +219,8 @@  static int mana_ib_create_qp_rss(struct ib_qp *ibqp, struct ib_pd *pd,
 		cq->queue.id = cq_spec.queue_index;
 
 		ibdev_dbg(&mdev->ib_dev,
-			  "ret %d rx_object 0x%llx wq id %llu cq id %llu\n",
-			  ret, wq->rx_object, wq->queue.id, cq->queue.id);
+			  "rx_object 0x%llx wq id %llu cq id %llu\n",
+			  wq->rx_object, wq->queue.id, cq->queue.id);
 
 		resp.entries[i].cqid = cq->queue.id;
 		resp.entries[i].wqid = wq->queue.id;
@@ -385,7 +385,7 @@  static int mana_ib_create_qp_raw(struct ib_qp *ibqp, struct ib_pd *ibpd,
 		goto err_destroy_wq_obj;
 
 	ibdev_dbg(&mdev->ib_dev,
-		  "ret %d qp->qp_handle 0x%llx sq id %llu cq id %llu\n", err,
+		  "qp->qp_handle 0x%llx sq id %llu cq id %llu\n",
 		  qp->qp_handle, qp->raw_sq.id, send_cq->queue.id);
 
 	resp.sqid = qp->raw_sq.id;