| Message ID | 20240410-samsung-galaxy-zfold5-q5q-v5-0-9311ee9a55f7@yahoo.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Samsung Galaxy Z Fold5 initial support | expand |
On 10/04/2024 23:28, Alexandru Marc Serdeliuc via B4 Relay wrote: > This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > ChangeLog > > - v5 > . Added ChangeLog > . Added missing Acked-by tags in their respective section in ChangeLog Where? I cannot find anything. Best regards, Krzysztof
Hi, The list of changes (changelog) from the cover is not what I should add? My patches received only two ACK tags, on V3 and on the initial request (v1), I was not able to identify any other, I added them to their place in the change log ... - v3 . added b4 version 3 . removed address and size cells in device description Acked-by: Rob Herring<robh@kernel.org> ... - v1 . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst Acked-by: Krzysztof Kozlowski<krzysztof.kozlowski@linaro.org> I suppose that adding them to their place in change log is wrong, I should create a v6 and put them at the end of the cover letter? Or how to proceed? Best regards, Alexandru Marc Serdeliuc On 11/4/24 8:03, Krzysztof Kozlowski wrote: > On 10/04/2024 23:28, Alexandru Marc Serdeliuc via B4 Relay wrote: >> This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q) >> which is a foldable phone by Samsung based on the sm8550 SoC. >> >> ChangeLog >> >> - v5 >> . Added ChangeLog >> . Added missing Acked-by tags in their respective section in ChangeLog > Where? I cannot find anything. > > Best regards, > Krzysztof >
On 11/04/2024 08:36, Alexandru Serdeliuc wrote: > Hi, > > The list of changes (changelog) from the cover is not what I should add? > > My patches received only two ACK tags, on V3 and on the initial request > (v1), I was not able to identify any other, I added them to their place > in the change log > > ... > - v3 > . added b4 version 3 > . removed address and size cells in device description > Acked-by: Rob Herring<robh@kernel.org> > ... > - v1 > . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together: > WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > Acked-by: Krzysztof Kozlowski<krzysztof.kozlowski@linaro.org> > > I suppose that adding them to their place in change log is wrong, I > should create a v6 and put them at the end of the cover letter? Or how > to proceed? Please don't top post. If you add them to the changelog, how are they going to be effective? Please apply your patch (e.g. b4 shazam) and look for them... Submitting patches explains where to add tags. Look at other mailings. And finally: why even bothering about this if b4 does it for you? https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 Best regards, Krzysztof
On 11/04/2024 09:34, Krzysztof Kozlowski wrote: > On 11/04/2024 08:36, Alexandru Serdeliuc wrote: >> Hi, >> >> The list of changes (changelog) from the cover is not what I should add? >> >> My patches received only two ACK tags, on V3 and on the initial request >> (v1), I was not able to identify any other, I added them to their place >> in the change log >> >> ... >> - v3 >> . added b4 version 3 >> . removed address and size cells in device description >> Acked-by: Rob Herring<robh@kernel.org> >> ... >> - v1 >> . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together: >> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst >> Acked-by: Krzysztof Kozlowski<krzysztof.kozlowski@linaro.org> >> >> I suppose that adding them to their place in change log is wrong, I >> should create a v6 and put them at the end of the cover letter? Or how >> to proceed? > > Please don't top post. If you add them to the changelog, how are they > going to be effective? Please apply your patch (e.g. b4 shazam) and look > for them... > > Submitting patches explains where to add tags. Look at other mailings. > And finally: why even bothering about this if b4 does it for you? > BTW, in reply to your first posting I gave you detailed instruction how to proceed with tags. Let me quote: "Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag" I think it is clear where you should add it. I gave this instruction on purpose so we will avoid this mess... Drop all invalid acks from cover letter and send v6 with proper tags places in mentioned place. Best regards, Krzysztof
Hi Krzysztof, Thank you for your time and please excuse my lack of knowledge, reviewing the first reply I clearly see now the details, but i missed them initially, I suppose that due to the lack of knowledge in regards to the procedures here. I am going to generate a v6, thanks again for your valuable time spent helping me. Best regards, Alexandru Marc Serdeliuc On 11/4/24 10:47, Krzysztof Kozlowski wrote: > On 11/04/2024 09:34, Krzysztof Kozlowski wrote: >> On 11/04/2024 08:36, Alexandru Serdeliuc wrote: >>> Hi, >>> >>> The list of changes (changelog) from the cover is not what I should add? >>> >>> My patches received only two ACK tags, on V3 and on the initial request >>> (v1), I was not able to identify any other, I added them to their place >>> in the change log >>> >>> ... >>> - v3 >>> . added b4 version 3 >>> . removed address and size cells in device description >>> Acked-by: Rob Herring<robh@kernel.org> >>> ... >>> - v1 >>> . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together: >>> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst >>> Acked-by: Krzysztof Kozlowski<krzysztof.kozlowski@linaro.org> >>> >>> I suppose that adding them to their place in change log is wrong, I >>> should create a v6 and put them at the end of the cover letter? Or how >>> to proceed? >> Please don't top post. If you add them to the changelog, how are they >> going to be effective? Please apply your patch (e.g. b4 shazam) and look >> for them... >> >> Submitting patches explains where to add tags. Look at other mailings. >> And finally: why even bothering about this if b4 does it for you? >> > BTW, in reply to your first posting I gave you detailed instruction how > to proceed with tags. Let me quote: > > "Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag" > > I think it is clear where you should add it. I gave this instruction on > purpose so we will avoid this mess... > > Drop all invalid acks from cover letter and send v6 with proper tags > places in mentioned place. > > Best regards, > Krzysztof >
On Wed, 10 Apr 2024 23:28:32 +0200, Alexandru Marc Serdeliuc wrote: > This documents and add intial dts support for Samsung Galaxy Z Fold5 (samsung,q5q) > which is a foldable phone by Samsung based on the sm8550 SoC. > > ChangeLog > > - v5 > . Added ChangeLog > . Added missing Acked-by tags in their respective section in ChangeLog > > - v4 > . removed a spurious new line > . removed pcie_1_phy_aux_clk as requested > . removed secondary pcie1 which does not exists on the device > . changed firmware extension from .mbn to .mdt > . added missing reserved memory regions required by firmware to properly load > > - v3 > . added b4 version 3 > . removed address and size cells in device description > Acked-by: Rob Herring <robh@kernel.org> > > - v2 > . added both but added an extra v2 in the subject line instead to b4 subject header, was requested to send the patch again, along with following mods: > . removed whole bootargs line > . fixed underscores in reserved memory by removing all reserved memory regions > . added missing idetation to spash_screen remark > . validated the dts with "dtbs_check" > . removed all comments at the end of nodes > . moved status of the node at the end of the node > . reversed pin control name with control numbers > . ordered the nodes alphabetically > > - v1 > . The initial request was split in two patches sent due to the following checkpatch warning, was requested to re send them together: > WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > --- > Alexandru Marc Serdeliuc (2): > dt-bindings: arm: qcom: Document the Samsung Galaxy Z Fold5 > arm64: dts: qcom: sm8550: Add support for Samsung Galaxy Z Fold5 > > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dts | 593 ++++++++++++++++++++++++ > 3 files changed, 595 insertions(+) > --- > base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702 > change-id: 20240410-samsung-galaxy-zfold5-q5q-d31cdeeac09f > > Best regards, > -- > Alexandru Marc Serdeliuc <serdeliuk@yahoo.com> > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/sm8550-samsung-q5q.dtb' for 20240410-samsung-galaxy-zfold5-q5q-v5-0-9311ee9a55f7@yahoo.com: arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: pcie-1-phy-aux-clk: 'clock-frequency' is a required property from schema $id: http://devicetree.org/schemas/clock/fixed-clock.yaml# arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: phy@1c0e000: clock-output-names: ['pcie1_pipe_clk'] is too short from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/sm8550-samsung-q5q.dtb: phy@1c0e000: #clock-cells:0:0: 1 was expected from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml#