| Message ID | 20240409141909.4413-1-sensor1010@163.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | cpufreq: Remove redundant exit() functions | expand |
On 09-04-24, 07:19, Lizhe wrote: > The return value of exit() is 0 and it performs no action. > This function can be omitted. Please refer to the end condition > check in the __cpufreq_offline() function. > > Signed-off-by: Lizhe <sensor1010@163.com> > --- > drivers/cpufreq/cpufreq-nforce2.c | 6 ------ > drivers/cpufreq/loongson2_cpufreq.c | 6 ------ > 2 files changed, 12 deletions(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
On 10-04-24, 21:49, lizhe wrote: > > > > Hi, > I have already tested it, it is functioning properly, Please review. Please don't expect reply within a day from maintainers. Give at least two weeks before posting another email to remind people.
diff --git a/drivers/cpufreq/cpufreq-nforce2.c b/drivers/cpufreq/cpufreq-nforce2.c index f7a7bcf6f52e..fedad1081973 100644 --- a/drivers/cpufreq/cpufreq-nforce2.c +++ b/drivers/cpufreq/cpufreq-nforce2.c @@ -359,11 +359,6 @@ static int nforce2_cpu_init(struct cpufreq_policy *policy) return 0; } -static int nforce2_cpu_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver nforce2_driver = { .name = "nforce2", .flags = CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING, @@ -371,7 +366,6 @@ static struct cpufreq_driver nforce2_driver = { .target = nforce2_target, .get = nforce2_get, .init = nforce2_cpu_init, - .exit = nforce2_cpu_exit, }; #ifdef MODULE diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c index afc59b292153..6a8e97896d38 100644 --- a/drivers/cpufreq/loongson2_cpufreq.c +++ b/drivers/cpufreq/loongson2_cpufreq.c @@ -85,18 +85,12 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int loongson2_cpufreq_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver loongson2_cpufreq_driver = { .name = "loongson2", .init = loongson2_cpufreq_cpu_init, .verify = cpufreq_generic_frequency_table_verify, .target_index = loongson2_cpufreq_target, .get = cpufreq_generic_get, - .exit = loongson2_cpufreq_exit, .attr = cpufreq_generic_attr, };
The return value of exit() is 0 and it performs no action. This function can be omitted. Please refer to the end condition check in the __cpufreq_offline() function. Signed-off-by: Lizhe <sensor1010@163.com> --- drivers/cpufreq/cpufreq-nforce2.c | 6 ------ drivers/cpufreq/loongson2_cpufreq.c | 6 ------ 2 files changed, 12 deletions(-)