| Message ID | 20240412064307.6478-1-jiande.lu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v4] Bluetooth: btusb: Add USB HWID to usb_device_id table for Acer NB | expand |
Dear Jiande, Thank you for your patches. Some minor comments from side. Am 12.04.24 um 08:43 schrieb Jiande Lu: > From: "jiande.lu" <jiande.lu@mediatek.com> I’d spell your name Jiande Lu: $ git config --global user.name "Jiande Lu" $ git commit --amend -s --author="Jiande Lu <jiande.lu@mediatek.com>" For the commit message summary/title, I’d use: Bluetooth: btusb: Add USB HW ids for MT7921/MT7922/MT7925 > This commit add HWID for wireless modules specific to Acer This commit add*s* is redundant. Just use imperative mood: Add HW ids for … > notebook models to ensure proper recongnition and functionality recognition > > Https://acer.com/tw-zh/support/product-support/ > SFE16-42/NX.KH5TA.0.01/downloads Please put it in one line and spell the schema https:// all lowercase. It’d be great if you listed the models in the commit message too, and mentioned, on what device you tested your change. > Signed-off-by: jiande.lu <jiande.lu@mediatek.com> > --- > v4: Update title > --- > v3: Fix patch fail > --- > v2: Update commit description and fix typo > --- > --- > drivers/bluetooth/btusb.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index c391e612b83b..b71efca2af73 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -616,6 +616,9 @@ static const struct usb_device_id quirks_table[] = { > { USB_DEVICE(0x0e8d, 0x0608), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH | > BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3606), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, Unfortunately, these entries are not sorted by the id. Can you please send a follow-up patch to sort the ids in these sections? > /* MediaTek MT7922 Bluetooth devices */ > { USB_DEVICE(0x13d3, 0x3585), .driver_info = BTUSB_MEDIATEK | > @@ -662,11 +665,32 @@ static const struct usb_device_id quirks_table[] = { > { USB_DEVICE(0x35f5, 0x7922), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH | > BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3614), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3615), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x04ca, 0x38e4), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3605), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3607), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, Please sort the entries. > /* Additional MediaTek MT7925 Bluetooth devices */ > + { USB_DEVICE(0x0489, 0xE113), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, Lowercase: 0xe113 > { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH | > BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > > /* Additional Realtek 8723AE Bluetooth devices */ > { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK }, Kind regards, Paul
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index c391e612b83b..b71efca2af73 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -616,6 +616,9 @@ static const struct usb_device_id quirks_table[] = { { USB_DEVICE(0x0e8d, 0x0608), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3606), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, /* MediaTek MT7922 Bluetooth devices */ { USB_DEVICE(0x13d3, 0x3585), .driver_info = BTUSB_MEDIATEK | @@ -662,11 +665,32 @@ static const struct usb_device_id quirks_table[] = { { USB_DEVICE(0x35f5, 0x7922), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3614), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3615), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x04ca, 0x38e4), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3605), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3607), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, /* Additional MediaTek MT7925 Bluetooth devices */ + { USB_DEVICE(0x0489, 0xE113), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x13d3, 0x3603), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, /* Additional Realtek 8723AE Bluetooth devices */ { USB_DEVICE(0x0930, 0x021d), .driver_info = BTUSB_REALTEK },