| Message ID | 20240407021100.48008-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f6e0f53a48809184c6d79177d1435fbff6b672c0 |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: nintendo: Remove unused function | expand |
On Sun, 7 Apr 2024, Jiapeng Chong wrote: > The function are defined in the hid-nintendo.c file, but not called > elsewhere, so delete the unused function. > > drivers/hid/hid-nintendo.c:697:20: warning: unused function 'joycon_device_has_usb'. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8704 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Applied, thanks.
diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c index 4b4ca990f968..b4a97803eca3 100644 --- a/drivers/hid/hid-nintendo.c +++ b/drivers/hid/hid-nintendo.c @@ -694,15 +694,6 @@ static inline bool joycon_device_is_n64con(struct joycon_ctlr *ctlr) return ctlr->hdev->product == USB_DEVICE_ID_NINTENDO_N64CON; } -static inline bool joycon_device_has_usb(struct joycon_ctlr *ctlr) -{ - return joycon_device_is_procon(ctlr) || - joycon_device_is_chrggrip(ctlr) || - joycon_device_is_snescon(ctlr) || - joycon_device_is_gencon(ctlr) || - joycon_device_is_n64con(ctlr); -} - /* * Controller type helpers *
The function are defined in the hid-nintendo.c file, but not called elsewhere, so delete the unused function. drivers/hid/hid-nintendo.c:697:20: warning: unused function 'joycon_device_has_usb'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8704 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/hid/hid-nintendo.c | 9 --------- 1 file changed, 9 deletions(-)