mbox series

[v2,0/7] PCI/MSI: Remove IMS (Interrupt Message Store) support for now

Message ID 20240410221307.2162676-1-helgaas@kernel.org (mailing list archive)
Headers show
Series PCI/MSI: Remove IMS (Interrupt Message Store) support for now | expand

Message

Bjorn Helgaas April 10, 2024, 10:13 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

IMS (Interrupt Message Store) support appeared in v6.2, but there are no
users yet.

Remove it for now.  We can add it back when a user comes along.

I propose to merge this via the PCI tree unless somebody else wants it.


Changes since v1 (https://lore.kernel.org/linux-pci/20240401232326.1794707-1-helgaas@kernel.org/):
  - Revert other IMS commits in IOMMU, apic, genirq, suggested by Kevin

Bjorn Helgaas (7):
  Revert "PCI/MSI: Provide stubs for IMS functions"
  Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()"
  Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"
  Revert "iommu/amd: Enable PCI/IMS"
  Revert "iommu/vt-d: Enable PCI/IMS"
  Revert "x86/apic/msi: Enable PCI/IMS"
  Revert "genirq/msi: Provide constants for PCI/IMS support"

 arch/x86/kernel/apic/msi.c          |  5 ---
 drivers/iommu/amd/iommu.c           | 17 +--------
 drivers/iommu/intel/irq_remapping.c | 19 ++--------
 drivers/pci/msi/api.c               | 50 ------------------------
 drivers/pci/msi/irqdomain.c         | 59 -----------------------------
 include/linux/irqdomain_defs.h      |  1 -
 include/linux/msi.h                 |  2 -
 include/linux/msi_api.h             |  1 -
 include/linux/pci.h                 | 26 -------------
 9 files changed, 5 insertions(+), 175 deletions(-)

Comments

Thomas Gleixner April 10, 2024, 10:45 p.m. UTC | #1
On Wed, Apr 10 2024 at 17:13, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> users yet.

Bah.

> Remove it for now.  We can add it back when a user comes along.
>
> I propose to merge this via the PCI tree unless somebody else wants it.

Go wild!

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Jason Gunthorpe April 10, 2024, 10:46 p.m. UTC | #2
On Thu, Apr 11, 2024 at 12:45:08AM +0200, Thomas Gleixner wrote:
> On Wed, Apr 10 2024 at 17:13, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> > users yet.
> 
> Bah.

Still baking here :|

Not sure what is going on with idxd though.

Jason
Bjorn Helgaas April 12, 2024, 9:31 p.m. UTC | #3
On Wed, Apr 10, 2024 at 05:13:00PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> IMS (Interrupt Message Store) support appeared in v6.2, but there are no
> users yet.
> 
> Remove it for now.  We can add it back when a user comes along.
> 
> I propose to merge this via the PCI tree unless somebody else wants it.
> 
> 
> Changes since v1 (https://lore.kernel.org/linux-pci/20240401232326.1794707-1-helgaas@kernel.org/):
>   - Revert other IMS commits in IOMMU, apic, genirq, suggested by Kevin
> 
> Bjorn Helgaas (7):
>   Revert "PCI/MSI: Provide stubs for IMS functions"
>   Revert "PCI/MSI: Provide pci_ims_alloc/free_irq()"
>   Revert "PCI/MSI: Provide IMS (Interrupt Message Store) support"
>   Revert "iommu/amd: Enable PCI/IMS"
>   Revert "iommu/vt-d: Enable PCI/IMS"
>   Revert "x86/apic/msi: Enable PCI/IMS"
>   Revert "genirq/msi: Provide constants for PCI/IMS support"
> 
>  arch/x86/kernel/apic/msi.c          |  5 ---
>  drivers/iommu/amd/iommu.c           | 17 +--------
>  drivers/iommu/intel/irq_remapping.c | 19 ++--------
>  drivers/pci/msi/api.c               | 50 ------------------------
>  drivers/pci/msi/irqdomain.c         | 59 -----------------------------
>  include/linux/irqdomain_defs.h      |  1 -
>  include/linux/msi.h                 |  2 -
>  include/linux/msi_api.h             |  1 -
>  include/linux/pci.h                 | 26 -------------
>  9 files changed, 5 insertions(+), 175 deletions(-)

I applied this to pci/ims-removal for v6.10.