diff mbox series

[7/7] arm64: dts: ti: k3-j784s4-evm: Remove HS400 mode support for eMMC

Message ID 20240411225257.383889-8-jm@ti.com (mailing list archive)
State New, archived
Headers show
Series MMC updates for TI K3 platforms | expand

Commit Message

Judith Mendez April 11, 2024, 10:52 p.m. UTC
From: Udit Kumar <u-kumar1@ti.com>

The eMMC fails to enumerate intermittently on HS400 mode. Also
observing multiple CQE recovery warnings.

Update the sdhci0 node to disable HS400.

Cc: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Bhavya Kapoor <b-kapoor@ti.com>
Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Udit Kumar <u-kumar1@ti.com>
Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
[Judith: Reword commit]
Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Kumar, Udit April 12, 2024, 4:52 a.m. UTC | #1
Hi Judith

On 4/12/2024 4:22 AM, Judith Mendez wrote:
> From: Udit Kumar <u-kumar1@ti.com>
>
> The eMMC fails to enumerate intermittently on HS400 mode. Also
> observing multiple CQE recovery warnings.
>
> Update the sdhci0 node to disable HS400.
>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: Bhavya Kapoor <b-kapoor@ti.com>
> Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> [Judith: Reword commit]
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index 81fd7afac8c57..04a241a91e6b8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -791,6 +791,7 @@ &main_sdhci0 {
>   	non-removable;
>   	ti,driver-strength-ohm = <50>;
>   	disable-wp;
> +	no-mmc-hs400;

This is just WA to get rid of CQE errors. I prefer to hold this patch 
under debug from hardware side is not complete.

Moreover, CQE errors are seen with 32GB variant not with 16GB, So we can 
not blame controller for this


>   };
>   
>   &main_sdhci1 {
Judith Mendez April 12, 2024, 10:14 p.m. UTC | #2
Hi Udit,

On 4/11/24 11:52 PM, Kumar, Udit wrote:
> Hi Judith
> 
> On 4/12/2024 4:22 AM, Judith Mendez wrote:
>> From: Udit Kumar <u-kumar1@ti.com>
>>
>> The eMMC fails to enumerate intermittently on HS400 mode. Also
>> observing multiple CQE recovery warnings.
>>
>> Update the sdhci0 node to disable HS400.
>>
>> Cc: Vignesh Raghavendra <vigneshr@ti.com>
>> Cc: Bhavya Kapoor <b-kapoor@ti.com>
>> Cc: Siddharth Vadapalli <s-vadapalli@ti.com>
>> Signed-off-by: Udit Kumar <u-kumar1@ti.com>
>> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
>> [Judith: Reword commit]
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts 
>> b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> index 81fd7afac8c57..04a241a91e6b8 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
>> @@ -791,6 +791,7 @@ &main_sdhci0 {
>>       non-removable;
>>       ti,driver-strength-ohm = <50>;
>>       disable-wp;
>> +    no-mmc-hs400;
> 
> This is just WA to get rid of CQE errors. I prefer to hold this patch 
> under debug from hardware side is not complete.
> 
> Moreover, CQE errors are seen with 32GB variant not with 16GB, So we can 
> not blame controller for this

Will drop, thanks.

~ Judith

> 
> 
>>   };
>>   &main_sdhci1 {
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index 81fd7afac8c57..04a241a91e6b8 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -791,6 +791,7 @@  &main_sdhci0 {
 	non-removable;
 	ti,driver-strength-ohm = <50>;
 	disable-wp;
+	no-mmc-hs400;
 };
 
 &main_sdhci1 {