mbox series

[v2,0/5] drm/vmwgfx: vblank and crc generation support

Message ID 20240412025511.78553-1-zack.rusin@broadcom.com (mailing list archive)
Headers show
Series drm/vmwgfx: vblank and crc generation support | expand

Message

Zack Rusin April 12, 2024, 2:55 a.m. UTC
vmwgfx didn't have support for vblank or crc generation which made it
impossible to use a large number of IGT tests to properly test DRM
functionality in the driver.

This series add virtual vblank and crc generation support, which allows
running most of IGT and immediately helped fix a number of kms issues
in the driver.

v2: Fix misspelled comment header found by the kernel test robot, a style
fix spotted by Martin and improve commit message in 5/5 as suggested
by Pekka.

Zack Rusin (5):
  drm/vmwgfx: Implement virtual kms
  drm/vmwgfx: Implement virtual crc generation
  drm/vmwgfx: Fix prime import/export
  drm/vmwgfx: Fix crtc's atomic check conditional
  drm/vmwgfx: Sort primary plane formats by order of preference

 drivers/gpu/drm/vmwgfx/Makefile            |   2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c       |  35 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c         |   7 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.h         |   2 +
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c        |   5 +
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h        |   7 +
 drivers/gpu/drm/vmwgfx/vmwgfx_gem.c        |  32 ++
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c        |  51 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h        |  26 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c        |  39 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_prime.c      |  15 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c   |  32 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c       |  28 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c       |  42 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c |  44 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c       | 632 +++++++++++++++++++++
 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h       |  75 +++
 17 files changed, 965 insertions(+), 109 deletions(-)
 create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c
 create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h

Comments

Martin Krastev April 12, 2024, 2:36 p.m. UTC | #1
On Fri, Apr 12, 2024 at 5:55 AM Zack Rusin <zack.rusin@broadcom.com> wrote:
>
> vmwgfx didn't have support for vblank or crc generation which made it
> impossible to use a large number of IGT tests to properly test DRM
> functionality in the driver.
>
> This series add virtual vblank and crc generation support, which allows
> running most of IGT and immediately helped fix a number of kms issues
> in the driver.
>
> v2: Fix misspelled comment header found by the kernel test robot, a style
> fix spotted by Martin and improve commit message in 5/5 as suggested
> by Pekka.
>
> Zack Rusin (5):
>   drm/vmwgfx: Implement virtual kms
>   drm/vmwgfx: Implement virtual crc generation
>   drm/vmwgfx: Fix prime import/export
>   drm/vmwgfx: Fix crtc's atomic check conditional
>   drm/vmwgfx: Sort primary plane formats by order of preference
>
>  drivers/gpu/drm/vmwgfx/Makefile            |   2 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c       |  35 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c         |   7 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h         |   2 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c        |   5 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h        |   7 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_gem.c        |  32 ++
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c        |  51 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_kms.h        |  26 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c        |  39 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_prime.c      |  15 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_resource.c   |  32 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c       |  28 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c       |  42 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c |  44 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c       | 632 +++++++++++++++++++++
>  drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h       |  75 +++
>  17 files changed, 965 insertions(+), 109 deletions(-)
>  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c
>  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h
>
> --
> 2.40.1
>

LGTM to the series.

Signed-off-by: Martin Krastev <martin.krastev@broadcom.com>

Regards,
Martin
Martin Krastev April 15, 2024, 8:04 a.m. UTC | #2
On Fri, Apr 12, 2024 at 5:36 PM Martin Krastev
<martin.krastev@broadcom.com> wrote:
>
> On Fri, Apr 12, 2024 at 5:55 AM Zack Rusin <zack.rusin@broadcom.com> wrote:
> >
> > vmwgfx didn't have support for vblank or crc generation which made it
> > impossible to use a large number of IGT tests to properly test DRM
> > functionality in the driver.
> >
> > This series add virtual vblank and crc generation support, which allows
> > running most of IGT and immediately helped fix a number of kms issues
> > in the driver.
> >
> > v2: Fix misspelled comment header found by the kernel test robot, a style
> > fix spotted by Martin and improve commit message in 5/5 as suggested
> > by Pekka.
> >
> > Zack Rusin (5):
> >   drm/vmwgfx: Implement virtual kms
> >   drm/vmwgfx: Implement virtual crc generation
> >   drm/vmwgfx: Fix prime import/export
> >   drm/vmwgfx: Fix crtc's atomic check conditional
> >   drm/vmwgfx: Sort primary plane formats by order of preference
> >
> >  drivers/gpu/drm/vmwgfx/Makefile            |   2 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c       |  35 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c         |   7 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h         |   2 +
> >  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c        |   5 +
> >  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h        |   7 +
> >  drivers/gpu/drm/vmwgfx/vmwgfx_gem.c        |  32 ++
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c        |  51 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.h        |  26 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c        |  39 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_prime.c      |  15 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_resource.c   |  32 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c       |  28 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c       |  42 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c |  44 +-
> >  drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c       | 632 +++++++++++++++++++++
> >  drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h       |  75 +++
> >  17 files changed, 965 insertions(+), 109 deletions(-)
> >  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.c
> >  create mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_vkms.h
> >
> > --
> > 2.40.1
> >
>
> LGTM to the series.
>
> Signed-off-by: Martin Krastev <martin.krastev@broadcom.com>
>
> Regards,
> Martin

Sorry, pasted the wrong clipboard.

Acked-by: Martin Krastev <martin.krastev@broadcom.com>

Regards,
Martin