| Message ID | 20240415070722.5131-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm/xe/irq: Remove unnecessary semicolon in pick_engine_gt() | expand |
On 4/15/2024 12:37, Jiapeng Chong wrote: > No functional modification involved. > > ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon. What i meant in the first review, was the commit description. The commit subject looks better now, but the issue remains the same: Line numbers will change after new code is added, so, it's better to just write it as "Remove unnecessary semicolon in pick_engine_gt()" instead of "./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon." With that, Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com> > > Reported-by: Abaci Robot<abaci@linux.alibaba.com> > Closes:https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 > Signed-off-by: Jiapeng Chong<jiapeng.chong@linux.alibaba.com> > --- > Changes in v2: > -Make the commit message more clearer. > > drivers/gpu/drm/xe/xe_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c > index 996806353171..5b1a2f46a1b2 100644 > --- a/drivers/gpu/drm/xe/xe_irq.c > +++ b/drivers/gpu/drm/xe/xe_irq.c > @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile, > return tile->media_gt; > default: > break; > - }; > + } > fallthrough; > default: > return tile->primary_gt;
On 4/15/2024 12:37, Jiapeng Chong wrote: > No functional modification involved. > > ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon. What i meant in the first review, was the commit description. The commit subject looks better now, but the issue remains the same: Line numbers will change after new code is added, so, it's better to just write it as "Remove unnecessary semicolon in pick_engine_gt()" instead of "./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon." With that, Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com> > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > Changes in v2: > -Make the commit message more clearer. > > drivers/gpu/drm/xe/xe_irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c > index 996806353171..5b1a2f46a1b2 100644 > --- a/drivers/gpu/drm/xe/xe_irq.c > +++ b/drivers/gpu/drm/xe/xe_irq.c > @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile, > return tile->media_gt; > default: > break; > - }; > + } > fallthrough; > default: > return tile->primary_gt;
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c index 996806353171..5b1a2f46a1b2 100644 --- a/drivers/gpu/drm/xe/xe_irq.c +++ b/drivers/gpu/drm/xe/xe_irq.c @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile, return tile->media_gt; default: break; - }; + } fallthrough; default: return tile->primary_gt;
No functional modification involved. ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: -Make the commit message more clearer. drivers/gpu/drm/xe/xe_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)