diff mbox series

[v2] drivers: char: Enable OMAP UART driver for TI K3 devices

Message ID 20240408150317.1309759-1-vaishnav.a@ti.com (mailing list archive)
State New, archived
Headers show
Series [v2] drivers: char: Enable OMAP UART driver for TI K3 devices | expand

Commit Message

Vaishnav Achath April 8, 2024, 3:03 p.m. UTC 
TI K3 devices (J721E, J721S2, AM62X .etc) have the same variant
of UART as OMAP4. Add the compatible used in Linux device tree,
"ti,am654-uart" to the OMAP UART dt_match so that the driver can
be used with these devices. Also, enable the driver for ARM64
platforms.

Reviewed-by: Michal Orzel <michal.orzel@amd.com>
Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

V1->V2:
Incorporate feedback from Michal Orzel:
	* Change to CONFIG_ARM
	* Update commit message.
	* Pick R-by from Michal.

Xen logs from J721E EVM: 
https://gist.github.com/vaishnavachath/8185e2378981705e1deb121f109f46b5

 xen/drivers/char/Kconfig     | 2 +-
 xen/drivers/char/omap-uart.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Julien Grall April 15, 2024, 10:41 a.m. UTC | #1 
Hi,

On 08/04/2024 16:03, Vaishnav Achath wrote:
> TI K3 devices (J721E, J721S2, AM62X .etc) have the same variant
> of UART as OMAP4. Add the compatible used in Linux device tree,
> "ti,am654-uart" to the OMAP UART dt_match so that the driver can
> be used with these devices. Also, enable the driver for ARM64
> platforms.
> 
> Reviewed-by: Michal Orzel <michal.orzel@amd.com>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>

In general, the tags are sorted chronologically. I can re-order both 
when committing:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,
diff mbox series

Patch

diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig
index e18ec3788c..3f836ab301 100644
--- a/xen/drivers/char/Kconfig
+++ b/xen/drivers/char/Kconfig
@@ -55,7 +55,7 @@  config HAS_EXYNOS4210
 config HAS_OMAP
 	bool "Texas Instruments OMAP UART driver"
 	default y
-	depends on ARM_32
+	depends on ARM
 	help
 	  This selects the Texas Instruments OMAP UART. If you have a Texas
 	  Instruments based CPU, say Y.
diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c
index f4368c158c..03b5b66e7a 100644
--- a/xen/drivers/char/omap-uart.c
+++ b/xen/drivers/char/omap-uart.c
@@ -372,6 +372,7 @@  static int __init omap_uart_init(struct dt_device_node *dev,
 static const struct dt_device_match omap_uart_dt_match[] __initconst =
 {
     DT_MATCH_COMPATIBLE("ti,omap4-uart"),
+    DT_MATCH_COMPATIBLE("ti,am654-uart"),
     { /* sentinel */ },
 };