| Message ID | 20240415161055.8316-1-jain.abhinav177@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI/AER: Print error message as per the TODO | expand |
On Mon, 2024-04-15 at 16:10 +0000, Abhinav Jain wrote: > Add a pr_err() to print the add device error in find_device_iter() [] > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c [] > @@ -885,7 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void *data) > /* List this device */ > if (add_error_device(e_info, dev)) { > /* We cannot handle more... Stop iteration */ > - /* TODO: Should print error message here? */ > + pr_err("find_device_iter: Cannot handle more devices. > + Stopping iteration"); You are adding unnecessary whitespace after the period. String concatenation keeps _all_ the whitespace. The format is fine on a single line too. Something like: pr_notice("%s: Cannot handle more devices - iteration stopped\n", __func__);
diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c index ac6293c24976..0e1ad2998116 100644 --- a/drivers/pci/pcie/aer.c +++ b/drivers/pci/pcie/aer.c @@ -885,7 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void *data) /* List this device */ if (add_error_device(e_info, dev)) { /* We cannot handle more... Stop iteration */ - /* TODO: Should print error message here? */ + pr_err("find_device_iter: Cannot handle more devices. + Stopping iteration"); return 1; }
Add a pr_err() to print the add device error in find_device_iter() Signed-off-by: Abhinav Jain <jain.abhinav177@gmail.com> --- drivers/pci/pcie/aer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)