mbox series

[blktests,v2,00/18] refactoring and various cleanups/fixes

Message ID 20240322135015.14712-1-dwagner@suse.de (mailing list archive)
Headers show
Series refactoring and various cleanups/fixes | expand

Message

Daniel Wagner March 22, 2024, 1:49 p.m. UTC 
Updated the series to include all the feedback from Shinichiro.

changes:
 v2:
  - addressed 'make check' errors
  - squashed 'nvme/rc: remove correct port from target'
    into 'nvme/rc: add nqn/uuid args to target setup/cleanup helper'
  - reordered patches
  - added 'nvme: drop default trtype argument for _nvmet_passthru_target_connect'

 v1:
   - https://lore.kernel.org/linux-nvme/20240321094727.6503-1-dwagner@suse.de/

Daniel Wagner (18):
  nvme/rc: silence error on module unload for fc
  nvme/rc: silence fcloop cleanup failures
  nvme/rc: log error if stale configuration is found
  common/xfs: propagate errors from _xfs_run_fio_verify_io
  nvme/{012,013,035}: check return value of _xfs_run_fio_verify_io
  nvme/rc: use long command line option for nvme
  nvme/{014,015,018,019,020,023,024,026,045,046}: use long command line
    option for nvme
  nvme/rc: connect subsys only support long options
  nvme/rc: add nqn/uuid args to target setup/cleanup helper
  nvme/rc: remove unused connect options
  nvme/rc: do not cleanup external managed loop device
  nvme/031: do not open code target setup/cleanup
  nvme: drop default trtype argument for _nvmet_connect_subsys
  nvme: drop default trtype argument for _nvmet_passthru_target_connect
  nvme: drop default subsysnqn argument from
    _nvme_{connect|disconnect}_subsys
  nvme/{041,042,043,044,045,048}: do not pass default host{nqn|id} to
    _nvme_connect_subsys
  nvme: don't assume namespace id
  nvme/028: drop unused nvmedev

 common/xfs     |   9 ++-
 tests/nvme/003 |   4 +-
 tests/nvme/004 |   5 +-
 tests/nvme/005 |   2 +-
 tests/nvme/008 |   4 +-
 tests/nvme/009 |   4 +-
 tests/nvme/010 |  11 ++--
 tests/nvme/011 |  11 ++--
 tests/nvme/012 |  13 ++--
 tests/nvme/013 |  13 ++--
 tests/nvme/014 |  17 +++--
 tests/nvme/015 |  17 +++--
 tests/nvme/018 |  20 +++---
 tests/nvme/019 |  13 ++--
 tests/nvme/020 |  12 ++--
 tests/nvme/021 |  11 ++--
 tests/nvme/022 |   4 +-
 tests/nvme/023 |  11 ++--
 tests/nvme/024 |  12 ++--
 tests/nvme/025 |  11 ++--
 tests/nvme/026 |  11 ++--
 tests/nvme/027 |   4 +-
 tests/nvme/028 |   9 +--
 tests/nvme/029 |  11 ++--
 tests/nvme/031 |  16 ++---
 tests/nvme/033 |   2 +-
 tests/nvme/034 |   2 +-
 tests/nvme/035 |   6 +-
 tests/nvme/036 |   2 +-
 tests/nvme/037 |   3 +-
 tests/nvme/040 |   6 +-
 tests/nvme/041 |  13 ++--
 tests/nvme/042 |  14 ++--
 tests/nvme/043 |  14 ++--
 tests/nvme/044 |  28 +++-----
 tests/nvme/045 |  17 ++---
 tests/nvme/046 |   7 +-
 tests/nvme/047 |  16 ++---
 tests/nvme/048 |   9 +--
 tests/nvme/rc  | 175 ++++++++++++++++++++++++++++++++-----------------
 40 files changed, 292 insertions(+), 277 deletions(-)

Comments

Chaitanya Kulkarni April 16, 2024, 2:50 a.m. UTC | #1 
On 3/22/24 06:49, Daniel Wagner wrote:
> Updated the series to include all the feedback from Shinichiro.
>
> changes:
>   v2:
>    - addressed 'make check' errors
>    - squashed 'nvme/rc: remove correct port from target'
>      into 'nvme/rc: add nqn/uuid args to target setup/cleanup helper'
>    - reordered patches
>    - added 'nvme: drop default trtype argument for _nvmet_passthru_target_connect'
>
>   v1:
>     -https://lore.kernel.org/linux-nvme/20240321094727.6503-1-dwagner@suse.de/

overall it looks good to me, I'll wait for V3 to provide review
since Shinichiro has some comments on this one  ...

-ck
Shinichiro Kawasaki April 16, 2024, 4:56 a.m. UTC | #2 
On Apr 16, 2024 / 02:50, Chaitanya Kulkarni wrote:
> On 3/22/24 06:49, Daniel Wagner wrote:
> > Updated the series to include all the feedback from Shinichiro.
> >
> > changes:
> >   v2:
> >    - addressed 'make check' errors
> >    - squashed 'nvme/rc: remove correct port from target'
> >      into 'nvme/rc: add nqn/uuid args to target setup/cleanup helper'
> >    - reordered patches
> >    - added 'nvme: drop default trtype argument for _nvmet_passthru_target_connect'
> >
> >   v1:
> >     -https://lore.kernel.org/linux-nvme/20240321094727.6503-1-dwagner@suse.de/
> 
> overall it looks good to me, I'll wait for V3 to provide review
> since Shinichiro has some comments on this one  ...

It's good to know that this series is okay for you. Actually, the v3 was posted
on Mar/26, and I applied the series on Mar/29 [1]. So, it's done.

[1] https://lore.kernel.org/linux-block/6foqfrw4amrpqoaiov6tyr7dhlnlm5tpeb6unfxpbrvsc6zals@lcbxl7pljbso/