mbox series

[0/3] Make support for multi-value configuration options more consistent

Message ID cover.1712016667.git.dsimic@manjaro.org (mailing list archive)
Headers show
Series Make support for multi-value configuration options more consistent | expand

Message

Dragan Simic April 2, 2024, 12:13 a.m. UTC
This series adds support for optional placing of additional whitespace
characters around the commas in the multi-value, comma-separated values
for the "diff.dirstat" and "diff.wsErrorHighlight" configuration options,
and the "--dirstat" and "--ws-error-highlight" command-line options.

This makes the way multi-(sub)value configuration options can be specified
more consistent, because exactly the same additional whitespace characters
are already allowed for some of the configuration options.  It may also
make the configuration files more readable to some users.

Dragan Simic (3):
  diff: support additional whitespace in diff.{dirstat,wsErrorHighlight}
  t4015: whitespace in diff.wsErrorHighlight and --ws-error-highlight
  t4047: whitespace in diff.dirstat and --dirstat

 builtin/gc.c                |  4 ++--
 diff.c                      | 14 ++++++++++----
 notes.c                     |  2 +-
 refs/packed-backend.c       |  2 +-
 string-list.c               | 27 +++++++++++++++++++++------
 string-list.h               | 10 ++++++----
 t/helper/test-hashmap.c     |  2 +-
 t/helper/test-json-writer.c |  2 +-
 t/helper/test-oidmap.c      |  2 +-
 t/helper/test-string-list.c |  4 ++--
 t/t4015-diff-whitespace.sh  | 36 ++++++++++++++++++++++++++++++++++--
 t/t4047-diff-dirstat.sh     | 33 ++++++++++++++++++++++++++++++---
 12 files changed, 110 insertions(+), 28 deletions(-)

Comments

Dragan Simic April 2, 2024, 12:31 a.m. UTC | #1
On 2024-04-02 02:13, Dragan Simic wrote:
> This series adds support for optional placing of additional whitespace
> characters around the commas in the multi-value, comma-separated values
> for the "diff.dirstat" and "diff.wsErrorHighlight" configuration 
> options,
> and the "--dirstat" and "--ws-error-highlight" command-line options.
> 
> This makes the way multi-(sub)value configuration options can be 
> specified
> more consistent, because exactly the same additional whitespace 
> characters
> are already allowed for some of the configuration options.  It may also
> make the configuration files more readable to some users.

Meh, somehow I managed to forget to include the brief summary for the
"what's cooking".  Here's what might be used for that purpose:

  * Allow additional whitespace around the commas in 
"diff.dirstat=<multi-value>",
    "diff.wsErrorHighlight=<multi-value>", "git diff 
--dirstat=<multi-value>"
    and "git diff --ws-error-highlight=<multi-value>".

> Dragan Simic (3):
>   diff: support additional whitespace in 
> diff.{dirstat,wsErrorHighlight}
>   t4015: whitespace in diff.wsErrorHighlight and --ws-error-highlight
>   t4047: whitespace in diff.dirstat and --dirstat
> 
>  builtin/gc.c                |  4 ++--
>  diff.c                      | 14 ++++++++++----
>  notes.c                     |  2 +-
>  refs/packed-backend.c       |  2 +-
>  string-list.c               | 27 +++++++++++++++++++++------
>  string-list.h               | 10 ++++++----
>  t/helper/test-hashmap.c     |  2 +-
>  t/helper/test-json-writer.c |  2 +-
>  t/helper/test-oidmap.c      |  2 +-
>  t/helper/test-string-list.c |  4 ++--
>  t/t4015-diff-whitespace.sh  | 36 ++++++++++++++++++++++++++++++++++--
>  t/t4047-diff-dirstat.sh     | 33 ++++++++++++++++++++++++++++++---
>  12 files changed, 110 insertions(+), 28 deletions(-)
Dragan Simic April 16, 2024, 5:40 a.m. UTC | #2
Hello all,

On 2024-04-02 02:13, Dragan Simic wrote:
> This series adds support for optional placing of additional whitespace
> characters around the commas in the multi-value, comma-separated values
> for the "diff.dirstat" and "diff.wsErrorHighlight" configuration 
> options,
> and the "--dirstat" and "--ws-error-highlight" command-line options.
> 
> This makes the way multi-(sub)value configuration options can be 
> specified
> more consistent, because exactly the same additional whitespace 
> characters
> are already allowed for some of the configuration options.  It may also
> make the configuration files more readable to some users.

Just a brief reminder about this patch series.

> Dragan Simic (3):
>   diff: support additional whitespace in 
> diff.{dirstat,wsErrorHighlight}
>   t4015: whitespace in diff.wsErrorHighlight and --ws-error-highlight
>   t4047: whitespace in diff.dirstat and --dirstat
> 
>  builtin/gc.c                |  4 ++--
>  diff.c                      | 14 ++++++++++----
>  notes.c                     |  2 +-
>  refs/packed-backend.c       |  2 +-
>  string-list.c               | 27 +++++++++++++++++++++------
>  string-list.h               | 10 ++++++----
>  t/helper/test-hashmap.c     |  2 +-
>  t/helper/test-json-writer.c |  2 +-
>  t/helper/test-oidmap.c      |  2 +-
>  t/helper/test-string-list.c |  4 ++--
>  t/t4015-diff-whitespace.sh  | 36 ++++++++++++++++++++++++++++++++++--
>  t/t4047-diff-dirstat.sh     | 33 ++++++++++++++++++++++++++++++---
>  12 files changed, 110 insertions(+), 28 deletions(-)