| Message ID | 20240414225729.18451-2-fw@strlen.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: netfilter: move to lib.sh infra | expand |
Hi Florian, On 15/04/2024 00:57, Florian Westphal wrote: > Only relevant change is that netns names have random suffix names, > i.e. its safe to run this in parallel with other tests. According to the patch title and description, it looks like something is missing from the diff below where on the 'config' file is modified, no? Same for patch 2/12 where we have the opposite modification. (BTW, it is good to see all the shellcheck cleanups, my text editor will show fewer warnings :) ) > > Signed-off-by: Florian Westphal <fw@strlen.de> > --- > tools/testing/selftests/net/netfilter/config | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config > index 9df6a9f11384..a34c284242ec 100644 > --- a/tools/testing/selftests/net/netfilter/config > +++ b/tools/testing/selftests/net/netfilter/config > @@ -2,6 +2,8 @@ CONFIG_AUDIT=y > CONFIG_BRIDGE_EBT_BROUTE=m > CONFIG_BRIDGE_EBT_REDIRECT=m > CONFIG_BRIDGE_NETFILTER=m > +CONFIG_NF_CONNTRACK=m > +CONFIG_NF_CT_NETLINK=m > CONFIG_IP_NF_MATCH_RPFILTER=m > CONFIG_IP6_NF_MATCH_RPFILTER=m > CONFIG_IP_SCTP=m Cheers, Matt
Matthieu Baerts <matttbe@kernel.org> wrote: > According to the patch title and description, it looks like something is > missing from the diff below where on the 'config' file is modified, no? > > Same for patch 2/12 where we have the opposite modification. Rebase artifact. Jakub/netdev maintainers, please toss this series, it needs more work, I can use this opportunity to also update a few scripts to skip instead of failing when requirements are not met.
diff --git a/tools/testing/selftests/net/netfilter/config b/tools/testing/selftests/net/netfilter/config index 9df6a9f11384..a34c284242ec 100644 --- a/tools/testing/selftests/net/netfilter/config +++ b/tools/testing/selftests/net/netfilter/config @@ -2,6 +2,8 @@ CONFIG_AUDIT=y CONFIG_BRIDGE_EBT_BROUTE=m CONFIG_BRIDGE_EBT_REDIRECT=m CONFIG_BRIDGE_NETFILTER=m +CONFIG_NF_CONNTRACK=m +CONFIG_NF_CT_NETLINK=m CONFIG_IP_NF_MATCH_RPFILTER=m CONFIG_IP6_NF_MATCH_RPFILTER=m CONFIG_IP_SCTP=m
Only relevant change is that netns names have random suffix names, i.e. its safe to run this in parallel with other tests. Signed-off-by: Florian Westphal <fw@strlen.de> --- tools/testing/selftests/net/netfilter/config | 2 ++ 1 file changed, 2 insertions(+)