| Message ID | 20240415174241.77982-1-arnd@kernel.org |
|---|---|
| State | Accepted |
| Commit | 9c79b779643e56d4253bd3ba6998c58c819943af |
| Headers | show |
| Series | phy: rockchip: fix CONFIG_TYPEC dependency | expand |
Am Montag, 15. April 2024, 19:42:25 CEST schrieb Arnd Bergmann: > From: Arnd Bergmann <arnd@arndb.de> > > The newly added driver causes a warning about missing dependencies > by selecting CONFIG_TYPEC unconditionally: > > WARNING: unmet direct dependencies detected for TYPEC > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] > > WARNING: unmet direct dependencies detected for USB_COMMON > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] > > Since that is a user-visible option, it should not really be selected > in the first place. Replace the 'select' with a 'depends on' as > we have for similar drivers. > > Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/phy/rockchip/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index a752ccdddb86..08b0f4345760 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB > config PHY_ROCKCHIP_USBDP > tristate "Rockchip USBDP COMBO PHY Driver" > depends on ARCH_ROCKCHIP && OF > + depends on TYPEC > select GENERIC_PHY > - select TYPEC > help > Enable this to support the Rockchip USB3.0/DP combo PHY with > Samsung IP block. This is required for USB3 support on RK3588. >
On Mon, 15 Apr 2024 19:42:25 +0200, Arnd Bergmann wrote: > The newly added driver causes a warning about missing dependencies > by selecting CONFIG_TYPEC unconditionally: > > WARNING: unmet direct dependencies detected for TYPEC > Depends on [n]: USB_SUPPORT [=n] > Selected by [y]: > - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] > > [...] Applied, thanks! [1/1] phy: rockchip: fix CONFIG_TYPEC dependency commit: 9c79b779643e56d4253bd3ba6998c58c819943af Best regards,
diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index a752ccdddb86..08b0f4345760 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB config PHY_ROCKCHIP_USBDP tristate "Rockchip USBDP COMBO PHY Driver" depends on ARCH_ROCKCHIP && OF + depends on TYPEC select GENERIC_PHY - select TYPEC help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588.