[0/3] Some null_blk cleanups

Message

Damien Le Moal April 11, 2024, 8:54 a.m. UTC

3 patches to cleanup null_blk main code and improve zone device support.
With the last 2 patches, some performance improvements (up to +1.7%) can
be measured for a null zoned device with no zone resource limits. The
maximum IOPS measured with zone write plugging with a multi-stream 4K
sequential write workload (32 jobs) is:

Before patches:
 - mq-deadline: 596 KIOPS
 - none: 2406 KIOPS

With patches applied:
 - mq-deadline: 600 KIOPS
 - none: 2447 KIOPS

Overall, there is no functional change.

Damien Le Moal (3):
  null_blk: Have all null_handle_xxx() return a blk_status_t
  null_blk: Do zone resource management only if necessary
  null_blk: Simplify null_zone_write()

 drivers/block/null_blk/main.c  |  18 +-
 drivers/block/null_blk/zoned.c | 343 +++++++++++++++++----------------
 2 files changed, 187 insertions(+), 174 deletions(-)

Comments

Jens Axboe April 17, 2024, 2:45 p.m. UTC | #1

On Thu, 11 Apr 2024 17:54:59 +0900, Damien Le Moal wrote:
> 3 patches to cleanup null_blk main code and improve zone device support.
> With the last 2 patches, some performance improvements (up to +1.7%) can
> be measured for a null zoned device with no zone resource limits. The
> maximum IOPS measured with zone write plugging with a multi-stream 4K
> sequential write workload (32 jobs) is:
> 
> Before patches:
>  - mq-deadline: 596 KIOPS
>  - none: 2406 KIOPS
> 
> [...]

Applied, thanks!

[1/3] null_blk: Have all null_handle_xxx() return a blk_status_t
      commit: cb9e5273f6d97830c44aeecd28cf5f5723ef2ba3
[2/3] null_blk: Do zone resource management only if necessary
      commit: 3bdde0701e5f819df0fa0e32fa8d5df7dc184cb5
[3/3] null_blk: Simplify null_zone_write()
      commit: e994ff5b55e3bf30ecb6ed354eaec77c989aa4ae

Best regards,