| Message ID | 20231023-display-support-v2-12-33ce8864b227@baylibre.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add display support for the MT8365-EVK board | expand |
Hello, On Tue, Apr 16, 2024 at 05:53:13PM +0200, Alexandre Mergnat wrote: > Add a compatible string for MediaTek Genio 350 MT8365's display PWM > block: this is the same as MT8183. > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> I already asked in reply to v1 what the merge plan is here. There are changes in my pwm tree to the mediatek,pwm-disp binding already. I don't think they conflict with this patch, but maybe it's still easier to take this via pwm?! Best regards Uwe
On Tue, 16 Apr 2024 17:53:13 +0200, Alexandre Mergnat wrote: > Add a compatible string for MediaTek Genio 350 MT8365's display PWM > block: this is the same as MT8183. > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
Hi Uwe On 17/04/2024 10:06, Uwe Kleine-König wrote: > Hello, > > On Tue, Apr 16, 2024 at 05:53:13PM +0200, Alexandre Mergnat wrote: >> Add a compatible string for MediaTek Genio 350 MT8365's display PWM >> block: this is the same as MT8183. >> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > I already asked in reply to v1 what the merge plan is here. There are > changes in my pwm tree to the mediatek,pwm-disp binding already. I don't > think they conflict with this patch, but maybe it's still easier to take > this via pwm?! Sorry, I though the merge strategy wasn't addressed to me because I'm not a maintainer. It's fine for me to merge it in the PWM tree. IMO, this change [1] shouldn't conflict with this patch. Can you add the "Acked-by: Rob Herring (Arm) <robh@kernel.org>" please if you merge this version ? Thanks for the review and help. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/commit/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml?h=pwm/for-next&id=fb7c3d8ba039df877886fd457538d8b24ca9c84b
Hello Alexandre, On Thu, Apr 18, 2024 at 11:46:11AM +0200, Alexandre Mergnat wrote: > On 17/04/2024 10:06, Uwe Kleine-König wrote: > > On Tue, Apr 16, 2024 at 05:53:13PM +0200, Alexandre Mergnat wrote: > > > Add a compatible string for MediaTek Genio 350 MT8365's display PWM > > > block: this is the same as MT8183. > > > > > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > > > > I already asked in reply to v1 what the merge plan is here. There are > > changes in my pwm tree to the mediatek,pwm-disp binding already. I don't > > think they conflict with this patch, but maybe it's still easier to take > > this via pwm?! > > Sorry, I though the merge strategy wasn't addressed to me because I'm not a maintainer. Well, you're the canonical person who has an interest to get this series in, so you can at least have and express an idea. In my experience it's good to be proactive and suggest a merge plan. Maintainers are triggered more to reply by a presented plan they don't agree with than with suggesting a plan themselves. And this way at least there is less surprise for you as submitter. > It's fine for me to merge it in the PWM tree. > IMO, this change [1] shouldn't conflict with this patch. FTR: [1] is in Linus's tree already now. > Can you add the "Acked-by: Rob Herring (Arm) <robh@kernel.org>" please if you merge this version ? I picked the one from your v3 series now where you included Rob's Ack. I was a bit grumpy because I only spotted your reply here afterwards. (Everything fine now on my side now.) Best regards Uwe > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/commit/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml?h=pwm/for-next&id=fb7c3d8ba039df877886fd457538d8b24ca9c84b
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml index f8988af05287..180dd8366935 100644 --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml @@ -31,6 +31,7 @@ properties: - mediatek,mt8188-disp-pwm - mediatek,mt8192-disp-pwm - mediatek,mt8195-disp-pwm + - mediatek,mt8365-disp-pwm - const: mediatek,mt8183-disp-pwm reg: