mbox series

[ethtool-next,v2,0/2] Userspace code for ethtool HW TS statistics

Message ID 20240417203836.113377-1-rrameshbabu@nvidia.com (mailing list archive)
Headers show
Series Userspace code for ethtool HW TS statistics | expand

Message

Rahul Rameshbabu April 17, 2024, 8:38 p.m. UTC
Adds support for querying statistics related to tsinfo if the kernel supports
such statistics.

Changes:
  v1->v2:
    - Updated UAPI header copy to be based on a valid commit in the
      net-next tree. Thanks Alexandra Winter <wintera@linux.ibm.com> for
      the catch.
    - Refactored logic based on a suggestion from Jakub Kicinski
      <kuba@kernel.org>.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Link: https://lore.kernel.org/netdev/20240403212931.128541-1-rrameshbabu@nvidia.com/
Link: https://lore.kernel.org/netdev/20240416203723.104062-1-rrameshbabu@nvidia.com/
---
Rahul Rameshbabu (2):
  update UAPI header copies
  netlink: tsinfo: add statistics support

 netlink/tsinfo.c             | 65 +++++++++++++++++++++++++++++++++++-
 uapi/linux/ethtool.h         | 64 +++++++++++++++++++++++++++++++++++
 uapi/linux/ethtool_netlink.h | 30 +++++++++++++----
 uapi/linux/if_link.h         |  1 +
 4 files changed, 153 insertions(+), 7 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 17, 2024, 9:30 p.m. UTC | #1
Hello:

This series was applied to ethtool/ethtool.git (next)
by Michal Kubecek <mkubecek@suse.cz>:

On Wed, 17 Apr 2024 13:38:27 -0700 you wrote:
> Adds support for querying statistics related to tsinfo if the kernel supports
> such statistics.
> 
> Changes:
>   v1->v2:
>     - Updated UAPI header copy to be based on a valid commit in the
>       net-next tree. Thanks Alexandra Winter <wintera@linux.ibm.com> for
>       the catch.
>     - Refactored logic based on a suggestion from Jakub Kicinski
>       <kuba@kernel.org>.
> 
> [...]

Here is the summary with links:
  - [ethtool-next,v2,1/2] update UAPI header copies
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=d324940988f3
  - [ethtool-next,v2,2/2] netlink: tsinfo: add statistics support
    (no matching commit)

You are awesome, thank you!
Michal Kubecek April 18, 2024, 6:30 a.m. UTC | #2
On Wed, Apr 17, 2024 at 09:30:30PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This series was applied to ethtool/ethtool.git (next)
> by Michal Kubecek <mkubecek@suse.cz>:
> 
> On Wed, 17 Apr 2024 13:38:27 -0700 you wrote:
> > Adds support for querying statistics related to tsinfo if the kernel supports
> > such statistics.
> > 
> > Changes:
> >   v1->v2:
> >     - Updated UAPI header copy to be based on a valid commit in the
> >       net-next tree. Thanks Alexandra Winter <wintera@linux.ibm.com> for
> >       the catch.
> >     - Refactored logic based on a suggestion from Jakub Kicinski
> >       <kuba@kernel.org>.
> > 
> > [...]
> 
> Here is the summary with links:
>   - [ethtool-next,v2,1/2] update UAPI header copies
>     https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=d324940988f3
>   - [ethtool-next,v2,2/2] netlink: tsinfo: add statistics support
>     (no matching commit)

Looks like the patchwork bot got a bit confused here. I accidentally
updated the UAPI header copies to the same mainline commit yesterday
which was probably identified as accepting the first patch. But the
second (i.e. the important one) is still in the queue.

Michal
Rahul Rameshbabu April 18, 2024, 6:32 a.m. UTC | #3
On Thu, 18 Apr, 2024 08:30:48 +0200 Michal Kubecek <mkubecek@suse.cz> wrote:
> [[PGP Signed Part:Undecided]]
> On Wed, Apr 17, 2024 at 09:30:30PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
>> Hello:
>> 
>> This series was applied to ethtool/ethtool.git (next)
>> by Michal Kubecek <mkubecek@suse.cz>:
>> 
>> On Wed, 17 Apr 2024 13:38:27 -0700 you wrote:
>> > Adds support for querying statistics related to tsinfo if the kernel supports
>> > such statistics.
>> > 
>> > Changes:
>> >   v1->v2:
>> >     - Updated UAPI header copy to be based on a valid commit in the
>> >       net-next tree. Thanks Alexandra Winter <wintera@linux.ibm.com> for
>> >       the catch.
>> >     - Refactored logic based on a suggestion from Jakub Kicinski
>> >       <kuba@kernel.org>.
>> > 
>> > [...]
>> 
>> Here is the summary with links:
>>   - [ethtool-next,v2,1/2] update UAPI header copies
>>     https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=d324940988f3
>>   - [ethtool-next,v2,2/2] netlink: tsinfo: add statistics support
>>     (no matching commit)
>
> Looks like the patchwork bot got a bit confused here. I accidentally
> updated the UAPI header copies to the same mainline commit yesterday
> which was probably identified as accepting the first patch. But the
> second (i.e. the important one) is still in the queue.

I saw this but was not sure it was intentional. Good to know it was
pw-bot hiccup.

--
Thanks,

Rahul Rameshbabu
Rahul Rameshbabu April 24, 2024, 6:58 p.m. UTC | #4
On Wed, 17 Apr, 2024 23:32:45 -0700 Rahul Rameshbabu <rrameshbabu@nvidia.com> wrote:
> On Thu, 18 Apr, 2024 08:30:48 +0200 Michal Kubecek <mkubecek@suse.cz> wrote:
>> [[PGP Signed Part:Undecided]]
>> On Wed, Apr 17, 2024 at 09:30:30PM +0000, patchwork-bot+netdevbpf@kernel.org wrote:
>>> Hello:
>>> 
>>> This series was applied to ethtool/ethtool.git (next)
>>> by Michal Kubecek <mkubecek@suse.cz>:
>>> 
>>> On Wed, 17 Apr 2024 13:38:27 -0700 you wrote:
>>> > Adds support for querying statistics related to tsinfo if the kernel supports
>>> > such statistics.
>>> > 
>>> > Changes:
>>> >   v1->v2:
>>> >     - Updated UAPI header copy to be based on a valid commit in the
>>> >       net-next tree. Thanks Alexandra Winter <wintera@linux.ibm.com> for
>>> >       the catch.
>>> >     - Refactored logic based on a suggestion from Jakub Kicinski
>>> >       <kuba@kernel.org>.
>>> > 
>>> > [...]
>>> 
>>> Here is the summary with links:
>>>   - [ethtool-next,v2,1/2] update UAPI header copies
>>>     https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=d324940988f3
>>>   - [ethtool-next,v2,2/2] netlink: tsinfo: add statistics support
>>>     (no matching commit)
>>
>> Looks like the patchwork bot got a bit confused here. I accidentally
>> updated the UAPI header copies to the same mainline commit yesterday
>> which was probably identified as accepting the first patch. But the
>> second (i.e. the important one) is still in the queue.
>
> I saw this but was not sure it was intentional. Good to know it was
> pw-bot hiccup.

Following up since I noticed these commits have not landed in next
recently.

  https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/log/?h=next

--
Thanks,

Rahul Rameshbabu