| Message ID | 20240412095031.256163-1-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Manivannan Sadhasivam |
| Headers | show |
| Series | [v2,1/1] Documentation: PCI: pci-endpoint: Fix EPF ops list | expand |
On Fri, Apr 12, 2024 at 11:50:31AM +0200, Alexander Stein wrote: > With commit 5779dd0a7dbd7 ("PCI: endpoint: Use notification chain > mechanism to notify EPC events to EPF") the linkup callback has been > removed and replaced by EPC event notifications. > > With commit 256ae475201b1 ("PCI: endpoint: Add pci_epf_ops to expose > function-specific attrs") a new (optional) add_cfs callback was added. > Update documentation accordingly. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Changes in v2: > * Separated paragraphs by blank line > > Documentation/PCI/endpoint/pci-endpoint.rst | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/PCI/endpoint/pci-endpoint.rst b/Documentation/PCI/endpoint/pci-endpoint.rst > index 4f5622a65555..3961ff4e5beb 100644 > --- a/Documentation/PCI/endpoint/pci-endpoint.rst > +++ b/Documentation/PCI/endpoint/pci-endpoint.rst > @@ -172,8 +172,7 @@ by the PCI endpoint function driver. > * bind: ops to perform when a EPC device has been bound to EPF device > * unbind: ops to perform when a binding has been lost between a EPC > device and EPF device > - * linkup: ops to perform when the EPC device has established a > - connection with a host system > + * add_cfs: optional ops to create function specific config attributes I think it is much clearer if you: s/config/configfs/ here. With that: Reviewed-by: Niklas Cassel <cassel@kernel.org>
On Fri, Apr 12, 2024 at 11:50:31AM +0200, Alexander Stein wrote: > With commit 5779dd0a7dbd7 ("PCI: endpoint: Use notification chain > mechanism to notify EPC events to EPF") the linkup callback has been > removed and replaced by EPC event notifications. > > With commit 256ae475201b1 ("PCI: endpoint: Add pci_epf_ops to expose > function-specific attrs") a new (optional) add_cfs callback was added. > Update documentation accordingly. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> With the change mentioned by Niklas. Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > Changes in v2: > * Separated paragraphs by blank line > > Documentation/PCI/endpoint/pci-endpoint.rst | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/PCI/endpoint/pci-endpoint.rst b/Documentation/PCI/endpoint/pci-endpoint.rst > index 4f5622a65555..3961ff4e5beb 100644 > --- a/Documentation/PCI/endpoint/pci-endpoint.rst > +++ b/Documentation/PCI/endpoint/pci-endpoint.rst > @@ -172,8 +172,7 @@ by the PCI endpoint function driver. > * bind: ops to perform when a EPC device has been bound to EPF device > * unbind: ops to perform when a binding has been lost between a EPC > device and EPF device > - * linkup: ops to perform when the EPC device has established a > - connection with a host system > + * add_cfs: optional ops to create function specific config attributes > > The PCI Function driver can then register the PCI EPF driver by using > pci_epf_register_driver(). > -- > 2.34.1 >
diff --git a/Documentation/PCI/endpoint/pci-endpoint.rst b/Documentation/PCI/endpoint/pci-endpoint.rst index 4f5622a65555..3961ff4e5beb 100644 --- a/Documentation/PCI/endpoint/pci-endpoint.rst +++ b/Documentation/PCI/endpoint/pci-endpoint.rst @@ -172,8 +172,7 @@ by the PCI endpoint function driver. * bind: ops to perform when a EPC device has been bound to EPF device * unbind: ops to perform when a binding has been lost between a EPC device and EPF device - * linkup: ops to perform when the EPC device has established a - connection with a host system + * add_cfs: optional ops to create function specific config attributes The PCI Function driver can then register the PCI EPF driver by using pci_epf_register_driver().
With commit 5779dd0a7dbd7 ("PCI: endpoint: Use notification chain mechanism to notify EPC events to EPF") the linkup callback has been removed and replaced by EPC event notifications. With commit 256ae475201b1 ("PCI: endpoint: Add pci_epf_ops to expose function-specific attrs") a new (optional) add_cfs callback was added. Update documentation accordingly. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Changes in v2: * Separated paragraphs by blank line Documentation/PCI/endpoint/pci-endpoint.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)