mbox series

[v10,0/6] QGV/SAGV related fixes

Message ID 20240405113533.338553-1-vinod.govindapillai@intel.com (mailing list archive)
Headers show
Series QGV/SAGV related fixes | expand

Message

Vinod Govindapillai April 5, 2024, 11:35 a.m. UTC
We have couple of customer issues, related to SAGV/QGV point
calculation. Those patches contain fixes plus some additional
debugs for those issues.

Stanislav Lisovskiy (4):
  drm/i915/display: Add meaningful traces for QGV point info error
    handling
  drm/i915/display: Extract code required to calculate max qgv/psf gv
    point
  drm/i915/display: Disable SAGV on bw init, to force QGV point
    recalculation
  drm/i915/display: handle systems with duplicate psf gv points

Vinod Govindapillai (2):
  drm/i915/display: extract code to prepare qgv points mask
  drm/i915/display: force qgv check after the hw state readout

 drivers/gpu/drm/i915/display/intel_bw.c      | 160 ++++++++++++++-----
 drivers/gpu/drm/i915/display/intel_bw.h      |   6 +
 drivers/gpu/drm/i915/display/skl_watermark.c |   2 +-
 drivers/gpu/drm/i915/display/skl_watermark.h |   1 +
 drivers/gpu/drm/i915/soc/intel_dram.c        |   2 +
 5 files changed, 129 insertions(+), 42 deletions(-)

Comments

Hogander, Jouni April 19, 2024, 8:42 a.m. UTC | #1
On Fri, 2024-04-05 at 14:35 +0300, Vinod Govindapillai wrote:
> We have couple of customer issues, related to SAGV/QGV point
> calculation. Those patches contain fixes plus some additional
> debugs for those issues.

For the whole set (with assumption you take care of that one naming
change suggested by Stan):

Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

> 
> Stanislav Lisovskiy (4):
>   drm/i915/display: Add meaningful traces for QGV point info error
>     handling
>   drm/i915/display: Extract code required to calculate max qgv/psf gv
>     point
>   drm/i915/display: Disable SAGV on bw init, to force QGV point
>     recalculation
>   drm/i915/display: handle systems with duplicate psf gv points
> 
> Vinod Govindapillai (2):
>   drm/i915/display: extract code to prepare qgv points mask
>   drm/i915/display: force qgv check after the hw state readout
> 
>  drivers/gpu/drm/i915/display/intel_bw.c      | 160 ++++++++++++++---
> --
>  drivers/gpu/drm/i915/display/intel_bw.h      |   6 +
>  drivers/gpu/drm/i915/display/skl_watermark.c |   2 +-
>  drivers/gpu/drm/i915/display/skl_watermark.h |   1 +
>  drivers/gpu/drm/i915/soc/intel_dram.c        |   2 +
>  5 files changed, 129 insertions(+), 42 deletions(-)
>
Vinod Govindapillai April 19, 2024, 1:32 p.m. UTC | #2
On Fri, 2024-04-19 at 08:42 +0000, Hogander, Jouni wrote:
> On Fri, 2024-04-05 at 14:35 +0300, Vinod Govindapillai wrote:
> > We have couple of customer issues, related to SAGV/QGV point
> > calculation. Those patches contain fixes plus some additional
> > debugs for those issues.
> 
> For the whole set (with assumption you take care of that one naming
> change suggested by Stan):
> 
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

Thanks for the reviews. Pushed to drm-intel-next

Thanks
Vinod

> 
> > 
> > Stanislav Lisovskiy (4):
> >   drm/i915/display: Add meaningful traces for QGV point info error
> >     handling
> >   drm/i915/display: Extract code required to calculate max qgv/psf gv
> >     point
> >   drm/i915/display: Disable SAGV on bw init, to force QGV point
> >     recalculation
> >   drm/i915/display: handle systems with duplicate psf gv points
> > 
> > Vinod Govindapillai (2):
> >   drm/i915/display: extract code to prepare qgv points mask
> >   drm/i915/display: force qgv check after the hw state readout
> > 
> >  drivers/gpu/drm/i915/display/intel_bw.c      | 160 ++++++++++++++---
> > --
> >  drivers/gpu/drm/i915/display/intel_bw.h      |   6 +
> >  drivers/gpu/drm/i915/display/skl_watermark.c |   2 +-
> >  drivers/gpu/drm/i915/display/skl_watermark.h |   1 +
> >  drivers/gpu/drm/i915/soc/intel_dram.c        |   2 +
> >  5 files changed, 129 insertions(+), 42 deletions(-)
> > 
>