| Message ID | 20240403043416.3800259-1-sumit.garg@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS | expand |
On Wed, 03 Apr 2024 10:04:13 +0530, Sumit Garg wrote: > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge > Box Core board based on the Qualcomm APQ8016E SoC. For more information > refer to the product page [1]. > > One of the major difference from db410c is serial port where HMIBSC board > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux > configured via gpio99 and gpio100). > > Support for Schneider Electric HMIBSC. Features: > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > - 1GiB RAM > - 8GiB eMMC, SD slot > - WiFi and Bluetooth > - 2x Host, 1x Device USB port > - HDMI > - Discrete TPM2 chip over SPI > - USB ethernet adaptors (soldered) > > This series is a v2 since v1 of this DTS file has been reviewed on the > U-Boot mailing list [2]. > > Changes in v5: > - Addressed another nitpick from Stephen. > - Collected Stephen's review tag. > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > still not converted to YAML format. > > Changes in v4: > - Dropped IRQ_TYPE_EDGE_FALLING for pm8916_resin given the expectations > of Linux kernel driver. Instead depend on systemd workaround suggested > by Caleb to get expected HMIBSC reset behaviour. > - Incorporated further DT coding style comments from Stephen. > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > still not converted to YAML format. > > Changes in v3: > - Picked up tags. > - Fixed further DT schema warnings. > - Configure resin/power button interrupt as falling edge. > - Incorporate DTS coding style comments from Krzysztof and Konrad. > > Changes in v2: > - Fix DT schema warnings. > - Incorporate suggestions from Stephan. > - Document UART1 mode GPIOs based mux. > > [1] https://www.se.com/us/en/product/HMIBSCEA53D1L0T/iiot-edge-box-core-harmony-ipc-emmc-dc-linux-tpm/ > [2] https://patchwork.ozlabs.org/project/uboot/patch/20240311111027.44577-6-sumit.garg@linaro.org/ > > Sumit Garg (3): > dt-bindings: vendor-prefixes: Add Schneider Electric > dt-bindings: arm: qcom: Add Schneider Electric HMIBSC board > arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS > > .../devicetree/bindings/arm/qcom.yaml | 1 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/apq8016-schneider-hmibsc.dts | 491 ++++++++++++++++++ > 4 files changed, 495 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/apq8016-schneider-hmibsc.dtb' for 20240403043416.3800259-1-sumit.garg@linaro.org: arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: pmic@0: gpio@c000:gpio-line-names: ['USB_HUB_RESET_N_PM', 'USB_SW_SEL_PM', 'NC', 'NC'] is too short from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml# arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: gpio@c000: gpio-line-names: ['USB_HUB_RESET_N_PM', 'USB_SW_SEL_PM', 'NC', 'NC'] is too short from schema $id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml# arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: /soc@0/audio-codec@771c000: failed to match any schema with compatible: ['qcom,msm8916-wcd-digital-codec'] arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: /soc@0/power-manager@b088000: failed to match any schema with compatible: ['qcom,msm8916-acc'] arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: /soc@0/power-manager@b098000: failed to match any schema with compatible: ['qcom,msm8916-acc'] arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: /soc@0/power-manager@b0a8000: failed to match any schema with compatible: ['qcom,msm8916-acc'] arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: /soc@0/power-manager@b0b8000: failed to match any schema with compatible: ['qcom,msm8916-acc'] arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: /usb-id: failed to match any schema with compatible: ['linux,extcon-usb-gpio']
Hi Bjorn, Konrad, On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote: > > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge > Box Core board based on the Qualcomm APQ8016E SoC. For more information > refer to the product page [1]. > > One of the major difference from db410c is serial port where HMIBSC board > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux > configured via gpio99 and gpio100). > > Support for Schneider Electric HMIBSC. Features: > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > - 1GiB RAM > - 8GiB eMMC, SD slot > - WiFi and Bluetooth > - 2x Host, 1x Device USB port > - HDMI > - Discrete TPM2 chip over SPI > - USB ethernet adaptors (soldered) > > This series is a v2 since v1 of this DTS file has been reviewed on the > U-Boot mailing list [2]. > > Changes in v5: > - Addressed another nitpick from Stephen. > - Collected Stephen's review tag. > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > still not converted to YAML format. > I haven't seen any further comments on this series, can you help to pick it up? -Sumit > Changes in v4: > - Dropped IRQ_TYPE_EDGE_FALLING for pm8916_resin given the expectations > of Linux kernel driver. Instead depend on systemd workaround suggested > by Caleb to get expected HMIBSC reset behaviour. > - Incorporated further DT coding style comments from Stephen. > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > still not converted to YAML format. > > Changes in v3: > - Picked up tags. > - Fixed further DT schema warnings. > - Configure resin/power button interrupt as falling edge. > - Incorporate DTS coding style comments from Krzysztof and Konrad. > > Changes in v2: > - Fix DT schema warnings. > - Incorporate suggestions from Stephan. > - Document UART1 mode GPIOs based mux. > > [1] https://www.se.com/us/en/product/HMIBSCEA53D1L0T/iiot-edge-box-core-harmony-ipc-emmc-dc-linux-tpm/ > [2] https://patchwork.ozlabs.org/project/uboot/patch/20240311111027.44577-6-sumit.garg@linaro.org/ > > Sumit Garg (3): > dt-bindings: vendor-prefixes: Add Schneider Electric > dt-bindings: arm: qcom: Add Schneider Electric HMIBSC board > arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS > > .../devicetree/bindings/arm/qcom.yaml | 1 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../dts/qcom/apq8016-schneider-hmibsc.dts | 491 ++++++++++++++++++ > 4 files changed, 495 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts > > -- > 2.34.1 >
On Tue, 9 Apr 2024 at 23:24, Sumit Garg <sumit.garg@linaro.org> wrote: > > Hi Bjorn, Konrad, > > On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge > > Box Core board based on the Qualcomm APQ8016E SoC. For more information > > refer to the product page [1]. > > > > One of the major difference from db410c is serial port where HMIBSC board > > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux > > configured via gpio99 and gpio100). > > > > Support for Schneider Electric HMIBSC. Features: > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > > - 1GiB RAM > > - 8GiB eMMC, SD slot > > - WiFi and Bluetooth > > - 2x Host, 1x Device USB port > > - HDMI > > - Discrete TPM2 chip over SPI > > - USB ethernet adaptors (soldered) > > > > This series is a v2 since v1 of this DTS file has been reviewed on the > > U-Boot mailing list [2]. > > > > Changes in v5: > > - Addressed another nitpick from Stephen. > > - Collected Stephen's review tag. > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > > still not converted to YAML format. > > > > I haven't seen any further comments on this series, can you help to pick it up? Gentle reminder. -Sumit > > > Changes in v4: > > - Dropped IRQ_TYPE_EDGE_FALLING for pm8916_resin given the expectations > > of Linux kernel driver. Instead depend on systemd workaround suggested > > by Caleb to get expected HMIBSC reset behaviour. > > - Incorporated further DT coding style comments from Stephen. > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > > still not converted to YAML format. > > > > Changes in v3: > > - Picked up tags. > > - Fixed further DT schema warnings. > > - Configure resin/power button interrupt as falling edge. > > - Incorporate DTS coding style comments from Krzysztof and Konrad. > > > > Changes in v2: > > - Fix DT schema warnings. > > - Incorporate suggestions from Stephan. > > - Document UART1 mode GPIOs based mux. > > > > [1] https://www.se.com/us/en/product/HMIBSCEA53D1L0T/iiot-edge-box-core-harmony-ipc-emmc-dc-linux-tpm/ > > [2] https://patchwork.ozlabs.org/project/uboot/patch/20240311111027.44577-6-sumit.garg@linaro.org/ > > > > Sumit Garg (3): > > dt-bindings: vendor-prefixes: Add Schneider Electric > > dt-bindings: arm: qcom: Add Schneider Electric HMIBSC board > > arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS > > > > .../devicetree/bindings/arm/qcom.yaml | 1 + > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > .../dts/qcom/apq8016-schneider-hmibsc.dts | 491 ++++++++++++++++++ > > 4 files changed, 495 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts > > > > -- > > 2.34.1 > >
On Fri, 19 Apr 2024 at 18:27, Sumit Garg <sumit.garg@linaro.org> wrote: > > On Tue, 9 Apr 2024 at 23:24, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > Hi Bjorn, Konrad, > > > > On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge > > > Box Core board based on the Qualcomm APQ8016E SoC. For more information > > > refer to the product page [1]. > > > > > > One of the major difference from db410c is serial port where HMIBSC board > > > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux > > > configured via gpio99 and gpio100). > > > > > > Support for Schneider Electric HMIBSC. Features: > > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > > > - 1GiB RAM > > > - 8GiB eMMC, SD slot > > > - WiFi and Bluetooth > > > - 2x Host, 1x Device USB port > > > - HDMI > > > - Discrete TPM2 chip over SPI > > > - USB ethernet adaptors (soldered) > > > > > > This series is a v2 since v1 of this DTS file has been reviewed on the > > > U-Boot mailing list [2]. > > > > > > Changes in v5: > > > - Addressed another nitpick from Stephen. > > > - Collected Stephen's review tag. > > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > > > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > > > still not converted to YAML format. > > > > > > > I haven't seen any further comments on this series, can you help to pick it up? > > Gentle reminder. I see an email from Rob. At least GPIO-related warnings are related to HMIBSC
On Fri, 19 Apr 2024 at 08:31, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Fri, 19 Apr 2024 at 18:27, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > On Tue, 9 Apr 2024 at 23:24, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > Hi Bjorn, Konrad, > > > > > > On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > > > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge > > > > Box Core board based on the Qualcomm APQ8016E SoC. For more information > > > > refer to the product page [1]. > > > > > > > > One of the major difference from db410c is serial port where HMIBSC board > > > > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux > > > > configured via gpio99 and gpio100). > > > > > > > > Support for Schneider Electric HMIBSC. Features: > > > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > > > > - 1GiB RAM > > > > - 8GiB eMMC, SD slot > > > > - WiFi and Bluetooth > > > > - 2x Host, 1x Device USB port > > > > - HDMI > > > > - Discrete TPM2 chip over SPI > > > > - USB ethernet adaptors (soldered) > > > > > > > > This series is a v2 since v1 of this DTS file has been reviewed on the > > > > U-Boot mailing list [2]. > > > > > > > > Changes in v5: > > > > - Addressed another nitpick from Stephen. > > > > - Collected Stephen's review tag. > > > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > > > > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > > > > still not converted to YAML format. > > > > > > > > > > I haven't seen any further comments on this series, can you help to pick it up? > > > > Gentle reminder. > > I see an email from Rob. At least GPIO-related warnings are related to HMIBSC > I suppose you are referring to: arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: pmic@0: gpio@c000:gpio-line-names: ['USB_HUB_RESET_N_PM', 'USB_SW_SEL_PM', 'NC', 'NC'] is too short from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml# arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb: gpio@c000: gpio-line-names: ['USB_HUB_RESET_N_PM', 'USB_SW_SEL_PM', 'NC', 'NC'] is too short from schema $id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml# I am really not sure as to why those warnings are being reported for v5 and not reported for v4 here [1]. Also, there are only 4 PMIC GPIOs available on PM8916 out of which only 2 are connected on HMIBSC and the other 2 are not connected. AFAICT, these seem to be false warning reports or am I missing something? [1] https://lore.kernel.org/lkml/171155390164.3454213.14779164019451021567.robh@kernel.org/ -Sumit > > -- > With best wishes > Dmitry
On Fri, 19 Apr 2024 at 20:57, Sumit Garg <sumit.garg@linaro.org> wrote: > > On Tue, 9 Apr 2024 at 23:24, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > Hi Bjorn, Konrad, > > > > On Wed, 3 Apr 2024 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote: > > > > > > Add Schneider Electric HMIBSC board DTS. The HMIBSC board is an IIoT Edge > > > Box Core board based on the Qualcomm APQ8016E SoC. For more information > > > refer to the product page [1]. > > > > > > One of the major difference from db410c is serial port where HMIBSC board > > > uses UART1 as the debug console with a default RS232 mode (UART1 mode mux > > > configured via gpio99 and gpio100). > > > > > > Support for Schneider Electric HMIBSC. Features: > > > - Qualcomm Snapdragon 410C SoC - APQ8016 (4xCortex A53, Adreno 306) > > > - 1GiB RAM > > > - 8GiB eMMC, SD slot > > > - WiFi and Bluetooth > > > - 2x Host, 1x Device USB port > > > - HDMI > > > - Discrete TPM2 chip over SPI > > > - USB ethernet adaptors (soldered) > > > > > > This series is a v2 since v1 of this DTS file has been reviewed on the > > > U-Boot mailing list [2]. > > > > > > Changes in v5: > > > - Addressed another nitpick from Stephen. > > > - Collected Stephen's review tag. > > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > > > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > > > still not converted to YAML format. > > > > > > > I haven't seen any further comments on this series, can you help to pick it up? > > Gentle reminder. > Is there anything missing on my part to get this accepted? It has already gone through the review cycle with v5 posted for about a month now. -Sumit > > > > > > Changes in v4: > > > - Dropped IRQ_TYPE_EDGE_FALLING for pm8916_resin given the expectations > > > of Linux kernel driver. Instead depend on systemd workaround suggested > > > by Caleb to get expected HMIBSC reset behaviour. > > > - Incorporated further DT coding style comments from Stephen. > > > - Warnings reported by Rob's DT check bot aren't related to HMIBSC > > > board DTS but rather they are due to msm8916.dtsi or extcon-usb-gpio.txt > > > still not converted to YAML format. > > > > > > Changes in v3: > > > - Picked up tags. > > > - Fixed further DT schema warnings. > > > - Configure resin/power button interrupt as falling edge. > > > - Incorporate DTS coding style comments from Krzysztof and Konrad. > > > > > > Changes in v2: > > > - Fix DT schema warnings. > > > - Incorporate suggestions from Stephan. > > > - Document UART1 mode GPIOs based mux. > > > > > > [1] https://www.se.com/us/en/product/HMIBSCEA53D1L0T/iiot-edge-box-core-harmony-ipc-emmc-dc-linux-tpm/ > > > [2] https://patchwork.ozlabs.org/project/uboot/patch/20240311111027.44577-6-sumit.garg@linaro.org/ > > > > > > Sumit Garg (3): > > > dt-bindings: vendor-prefixes: Add Schneider Electric > > > dt-bindings: arm: qcom: Add Schneider Electric HMIBSC board > > > arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS > > > > > > .../devicetree/bindings/arm/qcom.yaml | 1 + > > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > > .../dts/qcom/apq8016-schneider-hmibsc.dts | 491 ++++++++++++++++++ > > > 4 files changed, 495 insertions(+) > > > create mode 100644 arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dts > > > > > > -- > > > 2.34.1 > > >