mbox series

[0/8] drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup

Message ID 20240412175818.29217-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup | expand

Message

Ville Syrjala April 12, 2024, 5:58 p.m. UTC 
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Start off with a bit of cleanup around the BXT/GLK DPIO
PHY registers, and finish off with per-lane vswing
programming.

Ville Syrjälä (8):
  drm/i915/dpio: Clean up bxt/glk PHY registers
  drm/i915/dpio: Add per-lane PHY TX register definitons for bxt/glk
  drm/i915/dpio: Extract bxt_dpio_phy_regs.h
  drm/i915/dpio: Introdude bxt_ddi_phy_rmw_grp()
  drm/i915/dpio: Use intel_de_rmw() for BXT DPIO latency optim setup
  drm/i915/dpio: s/ddi/dpio/ for bxt/glk PHY stuff
  drm/i915/dpio: Program bxt/glk PHY TX registers per-lane
  drm/i915: Enable per-lane DP drive settings for bxt/glk

 .../gpu/drm/i915/display/bxt_dpio_phy_regs.h  | 273 ++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_ddi.c      |  10 +-
 .../i915/display/intel_display_power_well.c   |  18 +-
 .../drm/i915/display/intel_dp_link_training.c |   2 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   2 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c | 213 ++++++++------
 drivers/gpu/drm/i915/display/intel_dpio_phy.h |  48 +--
 drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   3 +-
 drivers/gpu/drm/i915/i915_reg.h               | 262 -----------------
 9 files changed, 432 insertions(+), 399 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/bxt_dpio_phy_regs.h

Comments

Jani Nikula April 15, 2024, 12:34 p.m. UTC | #1 
On Fri, 12 Apr 2024, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Start off with a bit of cleanup around the BXT/GLK DPIO
> PHY registers, and finish off with per-lane vswing
> programming.

The series is

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

but I'll add some notes inline.

>
> Ville Syrjälä (8):
>   drm/i915/dpio: Clean up bxt/glk PHY registers
>   drm/i915/dpio: Add per-lane PHY TX register definitons for bxt/glk
>   drm/i915/dpio: Extract bxt_dpio_phy_regs.h
>   drm/i915/dpio: Introdude bxt_ddi_phy_rmw_grp()
>   drm/i915/dpio: Use intel_de_rmw() for BXT DPIO latency optim setup
>   drm/i915/dpio: s/ddi/dpio/ for bxt/glk PHY stuff
>   drm/i915/dpio: Program bxt/glk PHY TX registers per-lane
>   drm/i915: Enable per-lane DP drive settings for bxt/glk
>
>  .../gpu/drm/i915/display/bxt_dpio_phy_regs.h  | 273 ++++++++++++++++++
>  drivers/gpu/drm/i915/display/intel_ddi.c      |  10 +-
>  .../i915/display/intel_display_power_well.c   |  18 +-
>  .../drm/i915/display/intel_dp_link_training.c |   2 +-
>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   2 +-
>  drivers/gpu/drm/i915/display/intel_dpio_phy.c | 213 ++++++++------
>  drivers/gpu/drm/i915/display/intel_dpio_phy.h |  48 +--
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   3 +-
>  drivers/gpu/drm/i915/i915_reg.h               | 262 -----------------
>  9 files changed, 432 insertions(+), 399 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/bxt_dpio_phy_regs.h
Jani Nikula April 18, 2024, 4:40 p.m. UTC | #2 
On Wed, 17 Apr 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
> URL   : https://patchwork.freedesktop.org/series/132390/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14597 -> Patchwork_132390v3
> ====================================================
>
> Summary
> -------
>
>   **SUCCESS**
>
>   No regressions found.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html

What happened here? BAT passed, but there are no IGT results, and the
shards queue is empty?

BR,
Jani.


>
> Participating hosts (38 -> 32)
> ------------------------------
>
>   Missing    (6): bat-dg1-7 fi-snb-2520m fi-glk-j4005 fi-kbl-8809g bat-dg2-11 bat-arls-3 
>
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_132390v3 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@i915_selftest@live@gem:
>     - bat-dg2-9:          [PASS][1] -> [ABORT][2] ([i915#10366])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14597/bat-dg2-9/igt@i915_selftest@live@gem.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/bat-dg2-9/igt@i915_selftest@live@gem.html
>
>   
>   [i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_14597 -> Patchwork_132390v3
>
>   CI-20190529: 20190529
>   CI_DRM_14597: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7810: 189483744e9ff56ea573e07a049c5365404c7ecb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_132390v3: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html
Musial, Ewelina April 19, 2024, 5:37 a.m. UTC | #3 
+ @Grabski, Mateusz please check it 

Thanks,
Ewelina

-----Original Message-----
From: Jani Nikula <jani.nikula@linux.intel.com> 
Sent: Thursday, April 18, 2024 6:41 PM
To: Patchwork <patchwork@emeril.freedesktop.org>; Ville Syrjala <ville.syrjala@linux.intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✓ Fi.CI.BAT: success for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)

On Wed, 17 Apr 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
> URL   : https://patchwork.freedesktop.org/series/132390/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_14597 -> Patchwork_132390v3 
> ====================================================
>
> Summary
> -------
>
>   **SUCCESS**
>
>   No regressions found.
>
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html

What happened here? BAT passed, but there are no IGT results, and the shards queue is empty?

BR,
Jani.


>
> Participating hosts (38 -> 32)
> ------------------------------
>
>   Missing    (6): bat-dg1-7 fi-snb-2520m fi-glk-j4005 fi-kbl-8809g bat-dg2-11 bat-arls-3 
>
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_132390v3 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@i915_selftest@live@gem:
>     - bat-dg2-9:          [PASS][1] -> [ABORT][2] ([i915#10366])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14597/bat-dg2-9/igt@i915_selftest@live@gem.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/bat-dg2-9/
> igt@i915_selftest@live@gem.html
>
>   
>   [i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_14597 -> Patchwork_132390v3
>
>   CI-20190529: 20190529
>   CI_DRM_14597: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7810: 189483744e9ff56ea573e07a049c5365404c7ecb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_132390v3: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html

--
Jani Nikula, Intel
Jani Nikula April 19, 2024, 8:31 a.m. UTC | #4 
Got the results in the middle of the night; Ville, please merge. :)

BR,
Jani.

On Fri, 19 Apr 2024, "Musial, Ewelina" <ewelina.musial@intel.com> wrote:
> + @Grabski, Mateusz please check it 
>
> Thanks,
> Ewelina
>
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com> 
> Sent: Thursday, April 18, 2024 6:41 PM
> To: Patchwork <patchwork@emeril.freedesktop.org>; Ville Syrjala <ville.syrjala@linux.intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: ✓ Fi.CI.BAT: success for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
>
> On Wed, 17 Apr 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
>> URL   : https://patchwork.freedesktop.org/series/132390/
>> State : success
>>
>> == Summary ==
>>
>> CI Bug Log - changes from CI_DRM_14597 -> Patchwork_132390v3 
>> ====================================================
>>
>> Summary
>> -------
>>
>>   **SUCCESS**
>>
>>   No regressions found.
>>
>>   External URL: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html
>
> What happened here? BAT passed, but there are no IGT results, and the shards queue is empty?
>
> BR,
> Jani.
>
>
>>
>> Participating hosts (38 -> 32)
>> ------------------------------
>>
>>   Missing    (6): bat-dg1-7 fi-snb-2520m fi-glk-j4005 fi-kbl-8809g bat-dg2-11 bat-arls-3 
>>
>> Known issues
>> ------------
>>
>>   Here are the changes found in Patchwork_132390v3 that come from known issues:
>>
>> ### IGT changes ###
>>
>> #### Issues hit ####
>>
>>   * igt@i915_selftest@live@gem:
>>     - bat-dg2-9:          [PASS][1] -> [ABORT][2] ([i915#10366])
>>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14597/bat-dg2-9/igt@i915_selftest@live@gem.html
>>    [2]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/bat-dg2-9/
>> igt@i915_selftest@live@gem.html
>>
>>   
>>   [i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366
>>
>>
>> Build changes
>> -------------
>>
>>   * Linux: CI_DRM_14597 -> Patchwork_132390v3
>>
>>   CI-20190529: 20190529
>>   CI_DRM_14597: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ git://anongit.freedesktop.org/gfx-ci/linux
>>   IGT_7810: 189483744e9ff56ea573e07a049c5365404c7ecb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>>   Patchwork_132390v3: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ 
>> git://anongit.freedesktop.org/gfx-ci/linux
>>
>> == Logs ==
>>
>> For more details see: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html
>
> --
> Jani Nikula, Intel
Ville Syrjala April 19, 2024, 4:56 p.m. UTC | #5 
On Fri, Apr 19, 2024 at 11:31:29AM +0300, Jani Nikula wrote:
> 
> Got the results in the middle of the night; Ville, please merge. :)

Unfortunately GLK was AWOL at the time, so we didn't actually test
anything :( I've hit the retest button for good measure.

> 
> BR,
> Jani.
> 
> On Fri, 19 Apr 2024, "Musial, Ewelina" <ewelina.musial@intel.com> wrote:
> > + @Grabski, Mateusz please check it 
> >
> > Thanks,
> > Ewelina
> >
> > -----Original Message-----
> > From: Jani Nikula <jani.nikula@linux.intel.com> 
> > Sent: Thursday, April 18, 2024 6:41 PM
> > To: Patchwork <patchwork@emeril.freedesktop.org>; Ville Syrjala <ville.syrjala@linux.intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: Re: ✓ Fi.CI.BAT: success for drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
> >
> > On Wed, 17 Apr 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> >> == Series Details ==
> >>
> >> Series: drm/i915: BXT/GLK per-lane vswing and PHY reg cleanup (rev3)
> >> URL   : https://patchwork.freedesktop.org/series/132390/
> >> State : success
> >>
> >> == Summary ==
> >>
> >> CI Bug Log - changes from CI_DRM_14597 -> Patchwork_132390v3 
> >> ====================================================
> >>
> >> Summary
> >> -------
> >>
> >>   **SUCCESS**
> >>
> >>   No regressions found.
> >>
> >>   External URL: 
> >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html
> >
> > What happened here? BAT passed, but there are no IGT results, and the shards queue is empty?
> >
> > BR,
> > Jani.
> >
> >
> >>
> >> Participating hosts (38 -> 32)
> >> ------------------------------
> >>
> >>   Missing    (6): bat-dg1-7 fi-snb-2520m fi-glk-j4005 fi-kbl-8809g bat-dg2-11 bat-arls-3 
> >>
> >> Known issues
> >> ------------
> >>
> >>   Here are the changes found in Patchwork_132390v3 that come from known issues:
> >>
> >> ### IGT changes ###
> >>
> >> #### Issues hit ####
> >>
> >>   * igt@i915_selftest@live@gem:
> >>     - bat-dg2-9:          [PASS][1] -> [ABORT][2] ([i915#10366])
> >>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14597/bat-dg2-9/igt@i915_selftest@live@gem.html
> >>    [2]: 
> >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/bat-dg2-9/
> >> igt@i915_selftest@live@gem.html
> >>
> >>   
> >>   [i915#10366]: https://gitlab.freedesktop.org/drm/intel/issues/10366
> >>
> >>
> >> Build changes
> >> -------------
> >>
> >>   * Linux: CI_DRM_14597 -> Patchwork_132390v3
> >>
> >>   CI-20190529: 20190529
> >>   CI_DRM_14597: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ git://anongit.freedesktop.org/gfx-ci/linux
> >>   IGT_7810: 189483744e9ff56ea573e07a049c5365404c7ecb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> >>   Patchwork_132390v3: 64a20aacb61e4ce6d8a0b3dc6e4bff72e316ffa3 @ 
> >> git://anongit.freedesktop.org/gfx-ci/linux
> >>
> >> == Logs ==
> >>
> >> For more details see: 
> >> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_132390v3/index.html
> >
> > --
> > Jani Nikula, Intel
> 
> -- 
> Jani Nikula, Intel