[iproute2-next,0/7] unused arguments

Message

Stephen Hemminger April 13, 2024, 10:04 p.m. UTC

While looking at finishing JSON support for TC in all places,
noticed that there was a lot of places with left over unused
arguments.

Stephen Hemminger (7):
  tc/u32: remove FILE argument
  tc/util: remove unused argument from print_tm
  tc/util: remove unused argument from print_action_control
  tc/police: remove unused argument to tc_print_police
  tc/util: remove unused argument from print_tcstats2_attr
  tc/action: remove unused args from tc_print_action
  tc/police: remove unused prototype police_print_xstats

 tc/f_basic.c      |  4 ++--
 tc/f_bpf.c        |  4 ++--
 tc/f_cgroup.c     |  4 ++--
 tc/f_flow.c       |  4 ++--
 tc/f_flower.c     |  2 +-
 tc/f_fw.c         |  4 ++--
 tc/f_matchall.c   |  2 +-
 tc/f_route.c      |  4 ++--
 tc/f_u32.c        | 18 +++++++++---------
 tc/m_action.c     | 30 ++++++++++++++++--------------
 tc/m_bpf.c        |  4 ++--
 tc/m_connmark.c   |  4 ++--
 tc/m_csum.c       |  4 ++--
 tc/m_ct.c         |  4 ++--
 tc/m_ctinfo.c     |  4 ++--
 tc/m_gact.c       |  6 +++---
 tc/m_gate.c       |  4 ++--
 tc/m_ife.c        |  4 ++--
 tc/m_mirred.c     |  4 ++--
 tc/m_mpls.c       |  4 ++--
 tc/m_nat.c        |  4 ++--
 tc/m_pedit.c      |  4 ++--
 tc/m_police.c     | 12 ++++++------
 tc/m_sample.c     |  4 ++--
 tc/m_simple.c     |  2 +-
 tc/m_skbedit.c    |  4 ++--
 tc/m_skbmod.c     |  4 ++--
 tc/m_tunnel_key.c |  4 ++--
 tc/m_vlan.c       |  4 ++--
 tc/tc_util.c      | 10 ++++------
 tc/tc_util.h      | 13 +++++--------
 31 files changed, 90 insertions(+), 93 deletions(-)

Comments

David Ahern April 21, 2024, 1:51 a.m. UTC | #1

On 4/13/24 4:04 PM, Stephen Hemminger wrote:
> While looking at finishing JSON support for TC in all places,
> noticed that there was a lot of places with left over unused
> arguments.
> 
> Stephen Hemminger (7):
>   tc/u32: remove FILE argument
>   tc/util: remove unused argument from print_tm
>   tc/util: remove unused argument from print_action_control
>   tc/police: remove unused argument to tc_print_police
>   tc/util: remove unused argument from print_tcstats2_attr
>   tc/action: remove unused args from tc_print_action
>   tc/police: remove unused prototype police_print_xstats
> 

applied the first 5. Patches 6 and 7 required too many adjustments -
easier to respin the patch.