| Message ID | 20240419140109.1996590-1-rrichter@amd.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] cxl: Fix use of phys_to_target_node() for x86 | expand |
Robert Richter wrote: > The CXL driver uses both functions phys_to_target_node() and > memory_add_physaddr_to_nid(). The x86 architecture relies on the > NUMA_KEEP_MEMINFO kernel option enabled for both functions to work > correct. Update Kconfig to make sure the option is always enabled for > the driver. > > Suggested-by: Dan Williams <dan.j.williams@intel.com> > Signed-off-by: Robert Richter <rrichter@amd.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Robert Richter wrote: > The CXL driver uses both functions phys_to_target_node() and > memory_add_physaddr_to_nid(). The x86 architecture relies on the > NUMA_KEEP_MEMINFO kernel option enabled for both functions to work > correct. Update Kconfig to make sure the option is always enabled for > the driver. > > Suggested-by: Dan Williams <dan.j.williams@intel.com> It would be nice if all "Suggested-by:" tags also came with a "Link:" tag to recall the rationale, because my brain had cache flushed what I said earlier. Found it here: Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch ...with that added: Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig index 67998dbd1d46..6140b3529a29 100644 --- a/drivers/cxl/Kconfig +++ b/drivers/cxl/Kconfig @@ -6,6 +6,7 @@ menuconfig CXL_BUS select FW_UPLOAD select PCI_DOE select FIRMWARE_TABLE + select NUMA_KEEP_MEMINFO if (NUMA && X86) help CXL is a bus that is electrically compatible with PCI Express, but layers three protocols on that signalling (CXL.io, CXL.cache, and
The CXL driver uses both functions phys_to_target_node() and memory_add_physaddr_to_nid(). The x86 architecture relies on the NUMA_KEEP_MEMINFO kernel option enabled for both functions to work correct. Update Kconfig to make sure the option is always enabled for the driver. Suggested-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Robert Richter <rrichter@amd.com> --- drivers/cxl/Kconfig | 1 + 1 file changed, 1 insertion(+)