| Message ID | cover.1712681770.git.u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpu: Convert to platform remove callback returning void | expand |
On Tue, Apr 09, 2024 at 07:02:47PM +0200, Uwe Kleine-König wrote: > Hello, > > with some patches sent earlier[1], this series converts all platform > drivers below drivers/gpu to not use struct platform_device::remove() > any more. I forgot to include footnote with the list of earlier patches. For completeness: [1]: https://lore.kernel.org/dri-devel/20240409165043.105137-2-u.kleine-koenig@pengutronix.de https://lore.kernel.org/dri-devel/20240304091005.717012-2-u.kleine-koenig@pengutronix.de https://lore.kernel.org/dri-devel/20240304090555.716327-2-u.kleine-koenig@pengutronix.de Best regards Uwe
Hi Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> for the series. Best regards Thomas Am 09.04.24 um 19:02 schrieb Uwe Kleine-König: > Hello, > > with some patches sent earlier[1], this series converts all platform > drivers below drivers/gpu to not use struct platform_device::remove() > any more. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > All conversations are trivial, because the driver's .remove() callbacks > returned zero unconditionally. > > There are no interdependencies between these patches. This is merge > window material. > > Best regards > Uwe > > Uwe Kleine-König (4): > drm/imagination: Convert to platform remove callback returning void > drm/mediatek: Convert to platform remove callback returning void > gpu: host1x: Convert to platform remove callback returning void > gpu: ipu-v3: Convert to platform remove callback returning void > > drivers/gpu/drm/imagination/pvr_drv.c | 7 ++----- > drivers/gpu/drm/mediatek/mtk_padding.c | 5 ++--- > drivers/gpu/host1x/dev.c | 6 ++---- > drivers/gpu/ipu-v3/ipu-common.c | 6 ++---- > drivers/gpu/ipu-v3/ipu-pre.c | 5 ++--- > drivers/gpu/ipu-v3/ipu-prg.c | 6 ++---- > 6 files changed, 12 insertions(+), 23 deletions(-) > > base-commit: a053fd3ca5d1b927a8655f239c84b0d790218fda
Hello, On Tue, Apr 09, 2024 at 07:02:47PM +0200, Uwe Kleine-König wrote: > with some patches sent earlier[1], this series converts all platform > drivers below drivers/gpu to not use struct platform_device::remove() > any more. > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > returns no value") for an extended explanation and the eventual goal. > > All conversations are trivial, because the driver's .remove() callbacks > returned zero unconditionally. > > There are no interdependencies between these patches. This is merge > window material. I wonder how this series will make it in. While I would prefer these patches to go in together (that I can consider this thread completed in one go), I think with how drm maintenace works, it's best if the patches are picked up by their individual maintainers. I guess that's: - Frank Binns + Matt Coster for imagination - Chun-Kuang Hu + Philipp Zabel for mediatek - Thierry Reding + Mikko Perttunen for the host1x driver (Note there is another patch for this driver set at 20240409165043.105137-2-u.kleine-koenig@pengutronix.de that is relevant for the same quest.) - Philipp Zabel for ipu-v3 I plan to send a patch changing struct platform_driver::remove after the end of the merge window leading to 6.10-rc1 for inclusion in next via Greg's driver core. So please either care the patches land in 6.10-rc1 or ack that I include them in the submission to Greg. Thanks for your cooperation, Uwe
On Fri Apr 19, 2024 at 9:20 AM CEST, Uwe Kleine-König wrote: > Hello, > > On Tue, Apr 09, 2024 at 07:02:47PM +0200, Uwe Kleine-König wrote: > > with some patches sent earlier[1], this series converts all platform > > drivers below drivers/gpu to not use struct platform_device::remove() > > any more. > > > > See commit 5c5a7680e67b ("platform: Provide a remove callback that > > returns no value") for an extended explanation and the eventual goal. > > > > All conversations are trivial, because the driver's .remove() callbacks > > returned zero unconditionally. > > > > There are no interdependencies between these patches. This is merge > > window material. > > I wonder how this series will make it in. While I would prefer these > patches to go in together (that I can consider this thread completed in > one go), I think with how drm maintenace works, it's best if the patches > are picked up by their individual maintainers. I guess that's: > > - Frank Binns + Matt Coster for imagination > > - Chun-Kuang Hu + Philipp Zabel for mediatek > > - Thierry Reding + Mikko Perttunen for the host1x driver > (Note there is another patch for this driver set at > 20240409165043.105137-2-u.kleine-koenig@pengutronix.de that is > relevant for the same quest.) > > - Philipp Zabel for ipu-v3 > > I plan to send a patch changing struct platform_driver::remove after the > end of the merge window leading to 6.10-rc1 for inclusion in next via > Greg's driver core. So please either care the patches land in 6.10-rc1 > or ack that I include them in the submission to Greg. I think the latter would make more sense. I'll go ack those patches. Thierry
On 19/04/2024 08:20, Uwe Kleine-König wrote: > Hello, > > On Tue, Apr 09, 2024 at 07:02:47PM +0200, Uwe Kleine-König wrote: >> with some patches sent earlier[1], this series converts all platform >> drivers below drivers/gpu to not use struct platform_device::remove() >> any more. >> >> See commit 5c5a7680e67b ("platform: Provide a remove callback that >> returns no value") for an extended explanation and the eventual goal. >> >> All conversations are trivial, because the driver's .remove() callbacks >> returned zero unconditionally. >> >> There are no interdependencies between these patches. This is merge >> window material. > > I wonder how this series will make it in. While I would prefer these > patches to go in together (that I can consider this thread completed in > one go), I think with how drm maintenace works, it's best if the patches > are picked up by their individual maintainers. I guess that's: > > - Frank Binns + Matt Coster for imagination I've acked the imagination patch - feel free to land it however you like. We don't have a separate tree so we'd just land it in drm-misc-next. Cheers, Matt > - Chun-Kuang Hu + Philipp Zabel for mediatek > > - Thierry Reding + Mikko Perttunen for the host1x driver > (Note there is another patch for this driver set at > 20240409165043.105137-2-u.kleine-koenig@pengutronix.de that is > relevant for the same quest.) > > - Philipp Zabel for ipu-v3 > > I plan to send a patch changing struct platform_driver::remove after the > end of the merge window leading to 6.10-rc1 for inclusion in next via > Greg's driver core. So please either care the patches land in 6.10-rc1 > or ack that I include them in the submission to Greg. > > Thanks for your cooperation, > Uwe >
Hello, with some patches sent earlier[1], this series converts all platform drivers below drivers/gpu to not use struct platform_device::remove() any more. See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. All conversations are trivial, because the driver's .remove() callbacks returned zero unconditionally. There are no interdependencies between these patches. This is merge window material. Best regards Uwe Uwe Kleine-König (4): drm/imagination: Convert to platform remove callback returning void drm/mediatek: Convert to platform remove callback returning void gpu: host1x: Convert to platform remove callback returning void gpu: ipu-v3: Convert to platform remove callback returning void drivers/gpu/drm/imagination/pvr_drv.c | 7 ++----- drivers/gpu/drm/mediatek/mtk_padding.c | 5 ++--- drivers/gpu/host1x/dev.c | 6 ++---- drivers/gpu/ipu-v3/ipu-common.c | 6 ++---- drivers/gpu/ipu-v3/ipu-pre.c | 5 ++--- drivers/gpu/ipu-v3/ipu-prg.c | 6 ++---- 6 files changed, 12 insertions(+), 23 deletions(-) base-commit: a053fd3ca5d1b927a8655f239c84b0d790218fda