| Message ID | 20240423073721.2001016-1-chentao@kylinos.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: selftests: Add 'malloc' failure check in config_name | expand |
On 4/23/24 12:37 PM, Kunwu Chan wrote: > There is a 'malloc' call in config_name function, which can > be unsuccessful. This patch will add the malloc failure checking > to avoid possible null dereference and give more information > about test fail reasons. > > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> LGTM Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/kvm/get-reg-list.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c > index 91f05f78e824..22398696ffd6 100644 > --- a/tools/testing/selftests/kvm/get-reg-list.c > +++ b/tools/testing/selftests/kvm/get-reg-list.c > @@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c) > len += strlen(s->name) + 1; > > c->name = malloc(len); > + TEST_ASSERT(c->name, "-ENOMEM when allocating config name"); > > len = 0; > for_each_sublist(c, s) {
… > This patch will add the malloc failure checking … * Please use a corresponding imperative wording for the change description. * Would you like to add the tag “Fixes” accordingly? … > +++ b/tools/testing/selftests/kvm/get-reg-list.c > @@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c) > len += strlen(s->name) + 1; > > c->name = malloc(len); > + TEST_ASSERT(c->name, "-ENOMEM when allocating config name"); … Can “errno” be relevant for the error message construction? Regards, Markus
diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c index 91f05f78e824..22398696ffd6 100644 --- a/tools/testing/selftests/kvm/get-reg-list.c +++ b/tools/testing/selftests/kvm/get-reg-list.c @@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c) len += strlen(s->name) + 1; c->name = malloc(len); + TEST_ASSERT(c->name, "-ENOMEM when allocating config name"); len = 0; for_each_sublist(c, s) {
There is a 'malloc' call in config_name function, which can be unsuccessful. This patch will add the malloc failure checking to avoid possible null dereference and give more information about test fail reasons. Signed-off-by: Kunwu Chan <chentao@kylinos.cn> --- tools/testing/selftests/kvm/get-reg-list.c | 1 + 1 file changed, 1 insertion(+)