| Message ID | 20240422151238.2051330-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v1,1/1] platform/x86: classmate-laptop: Add missing MODULE_DESCRIPTION() | expand |
On Mon, Apr 22, 2024 at 06:12:38PM +0300, Andy Shevchenko wrote: > The modpost script is not happy > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o > > because there is a missing module description. > > Add it to the module. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/platform/x86/classmate-laptop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c > index 87462e7c6219..fb208c68a7eb 100644 > --- a/drivers/platform/x86/classmate-laptop.c > +++ b/drivers/platform/x86/classmate-laptop.c > @@ -13,8 +13,6 @@ > #include <linux/input.h> > #include <linux/rfkill.h> > > -MODULE_LICENSE("GPL"); > - > struct cmpc_accel { > int sensitivity; > int g_select; > @@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = { > }; > > MODULE_DEVICE_TABLE(acpi, cmpc_device_ids); > +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices"); How about "Support for Intel Classmate PC ACPI devices", like the Kconfig devices? Cascardo. > +MODULE_LICENSE("GPL"); > -- > 2.43.0.rc1.1336.g36b5255a03ac >
On Tue, Apr 23, 2024 at 08:49:51AM -0300, Thadeu Lima de Souza Cascardo wrote: > On Mon, Apr 22, 2024 at 06:12:38PM +0300, Andy Shevchenko wrote: > > The modpost script is not happy > > > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o > > > > because there is a missing module description. > > > > Add it to the module. ... > > +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices"); > > How about "Support for Intel Classmate PC ACPI devices", like the > Kconfig devices? Whatever maintainers prefer. Thank you for looking into this.
diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c index 87462e7c6219..fb208c68a7eb 100644 --- a/drivers/platform/x86/classmate-laptop.c +++ b/drivers/platform/x86/classmate-laptop.c @@ -13,8 +13,6 @@ #include <linux/input.h> #include <linux/rfkill.h> -MODULE_LICENSE("GPL"); - struct cmpc_accel { int sensitivity; int g_select; @@ -1139,3 +1137,5 @@ static const struct acpi_device_id cmpc_device_ids[] __maybe_unused = { }; MODULE_DEVICE_TABLE(acpi, cmpc_device_ids); +MODULE_DESCRIPTION("Support for Classmate PC ACPI devices"); +MODULE_LICENSE("GPL");
The modpost script is not happy WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/platform/x86/classmate-laptop.o because there is a missing module description. Add it to the module. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/platform/x86/classmate-laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)