| Message ID | 20240423183339.1368511-1-florian.fainelli@broadcom.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: dsa: b53: Remove adjust_link | expand |
On Tue, Apr 23, 2024 at 11:33:31AM -0700, Florian Fainelli wrote: > b53 is now the only remaining driver that uses both PHYLIB's adjust_link > and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK. > > Florian Fainelli (8): > net: dsa: b53: Stop exporting b53_phylink_* routines > net: dsa: b53: Introduce b53_adjust_531x5_rgmii() > net: dsa: b53: Introduce b53_adjust_5325_mii() > net: dsa: b53: Force flow control for BCM5301X CPU port(s) > net: dsa: b53: Configure RGMII for 531x5 and MII for 5325 > net: dsa: b53: Call b53_eee_init() from b53_mac_link_up() > net: dsa: b53: Remove b53_adjust_link() > net: dsa: b53: provide own phylink MAC operations Read through the series, nothing obvious stands out, thanks for doing this! For the series: Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
On 4/23/24 12:14, Russell King (Oracle) wrote: > On Tue, Apr 23, 2024 at 11:33:31AM -0700, Florian Fainelli wrote: >> b53 is now the only remaining driver that uses both PHYLIB's adjust_link >> and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK. >> >> Florian Fainelli (8): >> net: dsa: b53: Stop exporting b53_phylink_* routines >> net: dsa: b53: Introduce b53_adjust_531x5_rgmii() >> net: dsa: b53: Introduce b53_adjust_5325_mii() >> net: dsa: b53: Force flow control for BCM5301X CPU port(s) >> net: dsa: b53: Configure RGMII for 531x5 and MII for 5325 >> net: dsa: b53: Call b53_eee_init() from b53_mac_link_up() >> net: dsa: b53: Remove b53_adjust_link() >> net: dsa: b53: provide own phylink MAC operations > > Read through the series, nothing obvious stands out, thanks for doing > this! And thank you for the reminder this needed to be done, once this lands I will submit the removal of the adjust_link within net/dsa/, unless you have that queued up already ready to go? > > For the series: > > Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> >
On Tue, Apr 23, 2024 at 12:15:49PM -0700, Florian Fainelli wrote: > And thank you for the reminder this needed to be done, once this lands I > will submit the removal of the adjust_link within net/dsa/, unless you have > that queued up already ready to go? I don't have that queued up, but it would be great to get that done as well. I think it would get rid of a reasonable amount of code in net/dsa?
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 23 Apr 2024 11:33:31 -0700 you wrote: > b53 is now the only remaining driver that uses both PHYLIB's adjust_link > and PHYLINK's mac_ops callbacks, convert entirely to PHYLINK. > > Florian Fainelli (8): > net: dsa: b53: Stop exporting b53_phylink_* routines > net: dsa: b53: Introduce b53_adjust_531x5_rgmii() > net: dsa: b53: Introduce b53_adjust_5325_mii() > net: dsa: b53: Force flow control for BCM5301X CPU port(s) > net: dsa: b53: Configure RGMII for 531x5 and MII for 5325 > net: dsa: b53: Call b53_eee_init() from b53_mac_link_up() > net: dsa: b53: Remove b53_adjust_link() > net: dsa: b53: provide own phylink MAC operations > > [...] Here is the summary with links: - [net-next,1/8] net: dsa: b53: Stop exporting b53_phylink_* routines https://git.kernel.org/netdev/net-next/c/65245197ecec - [net-next,2/8] net: dsa: b53: Introduce b53_adjust_531x5_rgmii() https://git.kernel.org/netdev/net-next/c/b3d06dc3707f - [net-next,3/8] net: dsa: b53: Introduce b53_adjust_5325_mii() https://git.kernel.org/netdev/net-next/c/0d18dea4cde6 - [net-next,4/8] net: dsa: b53: Force flow control for BCM5301X CPU port(s) https://git.kernel.org/netdev/net-next/c/93a2579ed08c - [net-next,5/8] net: dsa: b53: Configure RGMII for 531x5 and MII for 5325 https://git.kernel.org/netdev/net-next/c/536e5b2ecbae - [net-next,6/8] net: dsa: b53: Call b53_eee_init() from b53_mac_link_up() https://git.kernel.org/netdev/net-next/c/888128f360e1 - [net-next,7/8] net: dsa: b53: Remove b53_adjust_link() https://git.kernel.org/netdev/net-next/c/600354352cf2 - [net-next,8/8] net: dsa: b53: provide own phylink MAC operations https://git.kernel.org/netdev/net-next/c/d0a35d2948ec You are awesome, thank you!