| Message ID | 20240419-lan743x-confirm-v1-4-2a087617a3e5@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: microchip: Correct spelling in comments | expand |
Hi Simon, > -/* Convert validation error code into tc extact error message */ > +/* Convert validation error code into tc exact error message */ This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So the fix should be 'extack' instead. > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > { > switch (vrule->exterr) { > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > index 56874f2adbba..d6c3e90745a7 100644 > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > /* Copy to host byte order */ > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > -/* Convert validation error code into tc extact error message */ > +/* Convert validation error code into tc exact error message */ Same here. > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule); The other fixes seems correct. /Daniel
On Sat, Apr 20, 2024 at 07:24:24PM +0000, Daniel Machon wrote: > Hi Simon, > > > -/* Convert validation error code into tc extact error message */ > > +/* Convert validation error code into tc exact error message */ > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > the fix should be 'extack' instead. > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > { > > switch (vrule->exterr) { > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > index 56874f2adbba..d6c3e90745a7 100644 > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > /* Copy to host byte order */ > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > -/* Convert validation error code into tc extact error message */ > > +/* Convert validation error code into tc exact error message */ > > Same here. Thanks Daniel, Silly me. I'll drop these changes in v2. > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule); > > The other fixes seems correct. > > /Daniel >
> > Hi Simon, > > > > > -/* Convert validation error code into tc extact error message */ > > > +/* Convert validation error code into tc exact error message */ > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > the fix should be 'extack' instead. > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > { > > > switch (vrule->exterr) { > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > index 56874f2adbba..d6c3e90745a7 100644 > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > /* Copy to host byte order */ > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > -/* Convert validation error code into tc extact error message */ > > > +/* Convert validation error code into tc exact error message */ > > > > Same here. > > Thanks Daniel, > > Silly me. I'll drop these changes in v2. No reason to drop them just change it to 'extack' :-) /Daniel
On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > Hi Simon, > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > +/* Convert validation error code into tc exact error message */ > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > the fix should be 'extack' instead. > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > { > > > > switch (vrule->exterr) { > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > /* Copy to host byte order */ > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > +/* Convert validation error code into tc exact error message */ > > > > > > Same here. > > > > Thanks Daniel, > > > > Silly me. I'll drop these changes in v2. > > No reason to drop them just change it to 'extack' :-) Thanks, will do.
On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote: > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > > Hi Simon, > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > > the fix should be 'extack' instead. > > > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > > { > > > > > switch (vrule->exterr) { > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > > /* Copy to host byte order */ > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > Same here. > > > > > > Thanks Daniel, > > > > > > Silly me. I'll drop these changes in v2. > > > > No reason to drop them just change it to 'extack' :-) > > Thanks, will do. Sorry, I am somehow confused. Do you mean like this? /* Convert validation error code into extact error message */ Or just leave things unchanged? /* Convert validation error code into tc extact error message */
> On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote: > > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > > > Hi Simon, > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > > > the fix should be 'extack' instead. > > > > > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > > > { > > > > > > switch (vrule->exterr) { > > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > > > /* Copy to host byte order */ > > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > Same here. > > > > > > > > Thanks Daniel, > > > > > > > > Silly me. I'll drop these changes in v2. > > > > > > No reason to drop them just change it to 'extack' :-) > > > > Thanks, will do. > > Sorry, I am somehow confused. > > Do you mean like this? > > /* Convert validation error code into extact error message */ > > Or just leave things unchanged? > > /* Convert validation error code into tc extact error message */ Should be: /* Convert validation error code into tc extack error message */ So the misspelling was real, just the fix was extack and not exact. /Daniel
On Tue, Apr 23, 2024 at 07:29:30PM +0000, Daniel Machon wrote: > > On Tue, Apr 23, 2024 at 02:54:17PM +0100, Simon Horman wrote: > > > On Tue, Apr 23, 2024 at 11:29:15AM +0000, Daniel Machon wrote: > > > > > > Hi Simon, > > > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > > > This seems wrong. I bet it refers to the 'netlink_ext_ack' struct. So > > > > > > the fix should be 'extack' instead. > > > > > > > > > > > > > void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) > > > > > > > { > > > > > > > switch (vrule->exterr) { > > > > > > > diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > > index 56874f2adbba..d6c3e90745a7 100644 > > > > > > > --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > > +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h > > > > > > > @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, > > > > > > > /* Copy to host byte order */ > > > > > > > void vcap_netbytes_copy(u8 *dst, u8 *src, int count); > > > > > > > > > > > > > > -/* Convert validation error code into tc extact error message */ > > > > > > > +/* Convert validation error code into tc exact error message */ > > > > > > > > > > > > Same here. > > > > > > > > > > Thanks Daniel, > > > > > > > > > > Silly me. I'll drop these changes in v2. > > > > > > > > No reason to drop them just change it to 'extack' :-) > > > > > > Thanks, will do. > > > > Sorry, I am somehow confused. > > > > Do you mean like this? > > > > /* Convert validation error code into extact error message */ > > > > Or just leave things unchanged? > > > > /* Convert validation error code into tc extact error message */ > > Should be: > > /* Convert validation error code into tc extack error message */ > > So the misspelling was real, just the fix was extack and not exact. Thanks, I see it now.
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c b/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c index 141897dfe388..1915998f6079 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c @@ -143,7 +143,7 @@ static void sparx5_fdma_rx_activate(struct sparx5 *sparx5, struct sparx5_rx *rx) static void sparx5_fdma_rx_deactivate(struct sparx5 *sparx5, struct sparx5_rx *rx) { - /* Dectivate the RX channel */ + /* Deactivate the RX channel */ spx5_rmw(0, BIT(rx->channel_id) & FDMA_CH_ACTIVATE_CH_ACTIVATE, sparx5, FDMA_CH_ACTIVATE); diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c index ac7e1cffbcec..f3f5fb420468 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c @@ -67,7 +67,7 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap) for (i = 0; i < IFH_LEN; i++) ifh[i] = spx5_rd(sparx5, QS_XTR_RD(grp)); - /* Decode IFH (whats needed) */ + /* Decode IFH (what's needed) */ sparx5_ifh_parse(ifh, &fi); /* Map to port netdev */ diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_port.c b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c index 60dd2fd603a8..062e486c002c 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_port.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_port.c @@ -370,7 +370,7 @@ static int sparx5_port_disable(struct sparx5 *sparx5, struct sparx5_port *port, /* 6: Wait while the last frame is exiting the queues */ usleep_range(8 * spd_prm, 10 * spd_prm); - /* 7: Flush the queues accociated with the port->portno */ + /* 7: Flush the queues associated with the port->portno */ spx5_rmw(HSCH_FLUSH_CTRL_FLUSH_PORT_SET(port->portno) | HSCH_FLUSH_CTRL_FLUSH_DST_SET(1) | HSCH_FLUSH_CTRL_FLUSH_SRC_SET(1) | diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c index 4af85d108a06..0b4abc3eb53d 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c @@ -190,7 +190,7 @@ static int sparx5_port_bridge_join(struct sparx5_port *port, /* Remove standalone port entry */ sparx5_mact_forget(sparx5, ndev->dev_addr, 0); - /* Port enters in bridge mode therefor don't need to copy to CPU + /* Port enters in bridge mode therefore don't need to copy to CPU * frames for multicast in case the bridge is not requesting them */ __dev_mc_unsync(ndev, sparx5_mc_unsync); diff --git a/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h b/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h index c3569a4c7b69..4735fad05708 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h +++ b/drivers/net/ethernet/microchip/vcap/vcap_ag_api.h @@ -290,7 +290,7 @@ enum vcap_keyfield_set { * Sparx5: TCP flag RST , LAN966x: TCP: TCP flag RST. PTP over UDP: messageType * bit 3 * VCAP_KF_L4_SEQUENCE_EQ0_IS: W1, sparx5: is2/es2, lan966x: is2 - * Set if TCP sequence number is 0, LAN966x: Overlayed with PTP over UDP: + * Set if TCP sequence number is 0, LAN966x: Overlaid with PTP over UDP: * messageType bit 0 * VCAP_KF_L4_SPORT: W16, sparx5: is0/is2/es2, lan966x: is1/is2 * TCP/UDP source port diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.c b/drivers/net/ethernet/microchip/vcap/vcap_api.c index 80ae5e1708a6..a3b1dc7a5448 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_api.c +++ b/drivers/net/ethernet/microchip/vcap/vcap_api.c @@ -327,7 +327,7 @@ static int vcap_find_keystream_typegroup_sw(struct vcap_control *vctrl, } /* Verify that the typegroup information, subword count, keyset and type id - * are in sync and correct, return the list of matchin keysets + * are in sync and correct, return the list of matching keysets */ int vcap_find_keystream_keysets(struct vcap_control *vctrl, @@ -2943,7 +2943,7 @@ void vcap_netbytes_copy(u8 *dst, u8 *src, int count) } EXPORT_SYMBOL_GPL(vcap_netbytes_copy); -/* Convert validation error code into tc extact error message */ +/* Convert validation error code into tc exact error message */ void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule) { switch (vrule->exterr) { diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h index 56874f2adbba..d6c3e90745a7 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h @@ -238,7 +238,7 @@ const struct vcap_set *vcap_keyfieldset(struct vcap_control *vctrl, /* Copy to host byte order */ void vcap_netbytes_copy(u8 *dst, u8 *src, int count); -/* Convert validation error code into tc extact error message */ +/* Convert validation error code into tc exact error message */ void vcap_set_tc_exterr(struct flow_cls_offload *fco, struct vcap_rule *vrule); /* Cleanup a VCAP instance */ diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_private.h b/drivers/net/ethernet/microchip/vcap/vcap_api_private.h index df81d9ff502b..844bdf6b5f45 100644 --- a/drivers/net/ethernet/microchip/vcap/vcap_api_private.h +++ b/drivers/net/ethernet/microchip/vcap/vcap_api_private.h @@ -109,7 +109,7 @@ int vcap_addr_keysets(struct vcap_control *vctrl, struct net_device *ndev, struct vcap_keyset_list *kslist); /* Verify that the typegroup information, subword count, keyset and type id - * are in sync and correct, return the list of matchin keysets + * are in sync and correct, return the list of matching keysets */ int vcap_find_keystream_keysets(struct vcap_control *vctrl, enum vcap_type vt, u32 *keystream, u32 *mskstream, bool mask,
Correct spelling in comments, as flagged by codespell. Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/microchip/sparx5/sparx5_fdma.c | 2 +- drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 +- drivers/net/ethernet/microchip/sparx5/sparx5_port.c | 2 +- drivers/net/ethernet/microchip/sparx5/sparx5_switchdev.c | 2 +- drivers/net/ethernet/microchip/vcap/vcap_ag_api.h | 2 +- drivers/net/ethernet/microchip/vcap/vcap_api.c | 4 ++-- drivers/net/ethernet/microchip/vcap/vcap_api_client.h | 2 +- drivers/net/ethernet/microchip/vcap/vcap_api_private.h | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-)