| Message ID | 20240328191205.82295-1-robertcnelson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: arm: ti: Add BeagleY-AI | expand |
On Thu, 28 Mar 2024 14:12:04 -0500, Robert Nelson wrote: > This board is based on ti,j722s > > https://beagley-ai.org/ > https://openbeagle.org/beagley-ai/beagley-ai > > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > CC: Rob Herring <robh@kernel.org> > CC: Nishanth Menon <nm@ti.com> > CC: Jared McArthur <j-mcarthur@ti.com> > CC: Jason Kridner <jkridner@beagleboard.org> > CC: Deepak Khatri <lorforlinux@beagleboard.org> > --- > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + > 1 file changed, 1 insertion(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y ti/k3-j722s-beagley-ai.dtb' for 20240328191205.82295-1-robertcnelson@gmail.com: arch/arm64/boot/dts/ti/k3-j722s-beagley-ai.dtb: pinctrl@f4000: 'vdd-3v3-sd-pins-default' does not match any of the regexes: '-pins(-[0-9]+)?$|-pin$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-single.yaml#
On Thu, 28 Mar 2024 14:12:04 -0500, Robert Nelson wrote: > This board is based on ti,j722s > > https://beagley-ai.org/ > https://openbeagle.org/beagley-ai/beagley-ai > > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > CC: Rob Herring <robh@kernel.org> > CC: Nishanth Menon <nm@ti.com> > CC: Jared McArthur <j-mcarthur@ti.com> > CC: Jason Kridner <jkridner@beagleboard.org> > CC: Deepak Khatri <lorforlinux@beagleboard.org> > --- > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
Hi Robert Nelson, On Thu, 28 Mar 2024 14:12:04 -0500, Robert Nelson wrote: > This board is based on ti,j722s > > https://beagley-ai.org/ > https://openbeagle.org/beagley-ai/beagley-ai > > Robert, I did a couple of sync as part of rebase - but for the future, please be aware of [2] I have applied the following to branch ti-k3-dts-next on [1]. Thank you! [1/2] dt-bindings: arm: ti: Add BeagleY-AI commit: d2b3e3b544d7e657406db3bdcdc296f02f4f07c9 [2/2] arm64: dts: ti: Add k3-j722s-beagley-ai commit: f6a61274cc851e1dbae82b5fa2d3e7087dccf85b All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git [2] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
On 3/28/24 2:12 PM, Robert Nelson wrote: > This board is based on ti,j722s > > https://beagley-ai.org/ > https://openbeagle.org/beagley-ai/beagley-ai > > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > CC: Rob Herring <robh@kernel.org> > CC: Nishanth Menon <nm@ti.com> > CC: Jared McArthur <j-mcarthur@ti.com> > CC: Jason Kridner <jkridner@beagleboard.org> > CC: Deepak Khatri <lorforlinux@beagleboard.org> > --- > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > index 52b51fd7044e..ca23b7e6a35e 100644 > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > @@ -134,6 +134,7 @@ properties: > - description: K3 J722S SoC and Boards > items: > - enum: > + - beagle,j722s-beagley-ai Recommend "beagle,am67-beagley-ai". The "J722s" is the family name, the part used on this board is the AM67. We do the same for the SK boards, for example, the SK-AM69 uses the AM69 part from the J784s4 family, so it is called k3-am69-sk.dts with compatible = "ti,am69-sk", "ti,j784s4"; This would otherwise be the first board with a specific part attached but uses the SoC family name instead of that specific part name in the DT file/name. Only the EVMs should have the family name since we sell versions of those with all the different parts swapped onto it. I don't imagine you will be selling BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your docs and other collateral use "AM67", using the same here would help avoid confusion. Andrew > - ti,j722s-evm > - const: ti,j722s >
On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <afd@ti.com> wrote: > > On 3/28/24 2:12 PM, Robert Nelson wrote: > > This board is based on ti,j722s > > > > https://beagley-ai.org/ > > https://openbeagle.org/beagley-ai/beagley-ai > > > > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > > CC: Rob Herring <robh@kernel.org> > > CC: Nishanth Menon <nm@ti.com> > > CC: Jared McArthur <j-mcarthur@ti.com> > > CC: Jason Kridner <jkridner@beagleboard.org> > > CC: Deepak Khatri <lorforlinux@beagleboard.org> > > --- > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > index 52b51fd7044e..ca23b7e6a35e 100644 > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > @@ -134,6 +134,7 @@ properties: > > - description: K3 J722S SoC and Boards > > items: > > - enum: > > + - beagle,j722s-beagley-ai > > Recommend "beagle,am67-beagley-ai". The "J722s" is the family > name, the part used on this board is the AM67. We do the same > for the SK boards, for example, the SK-AM69 uses the AM69 > part from the J784s4 family, so it is called k3-am69-sk.dts > with compatible = "ti,am69-sk", "ti,j784s4"; > > This would otherwise be the first board with a specific part > attached but uses the SoC family name instead of that specific > part name in the DT file/name. Only the EVMs should have the > family name since we sell versions of those with all the different > parts swapped onto it. I don't imagine you will be selling > BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your > docs and other collateral use "AM67", using the same here > would help avoid confusion. > > Andrew Andrew, would you like us to model this just like the AM69-SK? and also rename the device tree? or just the bindings.. k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a k3-am67a-beagley-ai.dtb ? Regards,
On 14:48-20240423, Robert Nelson wrote: > On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <afd@ti.com> wrote: > > > > On 3/28/24 2:12 PM, Robert Nelson wrote: > > > This board is based on ti,j722s > > > > > > https://beagley-ai.org/ > > > https://openbeagle.org/beagley-ai/beagley-ai > > > > > > Signed-off-by: Robert Nelson <robertcnelson@gmail.com> > > > CC: Rob Herring <robh@kernel.org> > > > CC: Nishanth Menon <nm@ti.com> > > > CC: Jared McArthur <j-mcarthur@ti.com> > > > CC: Jason Kridner <jkridner@beagleboard.org> > > > CC: Deepak Khatri <lorforlinux@beagleboard.org> > > > --- > > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > index 52b51fd7044e..ca23b7e6a35e 100644 > > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml > > > @@ -134,6 +134,7 @@ properties: > > > - description: K3 J722S SoC and Boards > > > items: > > > - enum: > > > + - beagle,j722s-beagley-ai > > > > Recommend "beagle,am67-beagley-ai". The "J722s" is the family > > name, the part used on this board is the AM67. We do the same > > for the SK boards, for example, the SK-AM69 uses the AM69 > > part from the J784s4 family, so it is called k3-am69-sk.dts > > with compatible = "ti,am69-sk", "ti,j784s4"; > > > > This would otherwise be the first board with a specific part > > attached but uses the SoC family name instead of that specific > > part name in the DT file/name. Only the EVMs should have the > > family name since we sell versions of those with all the different > > parts swapped onto it. I don't imagine you will be selling > > BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your > > docs and other collateral use "AM67", using the same here > > would help avoid confusion. > > > > Andrew > > Andrew, would you like us to model this just like the AM69-SK? and > also rename the device tree? or just the bindings.. > > k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a > k3-am67a-beagley-ai.dtb ? > Will drop these patches off the queue for now. please respin as needed.
On 4/23/24 2:48 PM, Robert Nelson wrote: > On Mon, Apr 22, 2024 at 3:57 PM Andrew Davis <afd@ti.com> wrote: >> >> On 3/28/24 2:12 PM, Robert Nelson wrote: >>> This board is based on ti,j722s >>> >>> https://beagley-ai.org/ >>> https://openbeagle.org/beagley-ai/beagley-ai >>> >>> Signed-off-by: Robert Nelson <robertcnelson@gmail.com> >>> CC: Rob Herring <robh@kernel.org> >>> CC: Nishanth Menon <nm@ti.com> >>> CC: Jared McArthur <j-mcarthur@ti.com> >>> CC: Jason Kridner <jkridner@beagleboard.org> >>> CC: Deepak Khatri <lorforlinux@beagleboard.org> >>> --- >>> Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml >>> index 52b51fd7044e..ca23b7e6a35e 100644 >>> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml >>> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml >>> @@ -134,6 +134,7 @@ properties: >>> - description: K3 J722S SoC and Boards >>> items: >>> - enum: >>> + - beagle,j722s-beagley-ai >> >> Recommend "beagle,am67-beagley-ai". The "J722s" is the family >> name, the part used on this board is the AM67. We do the same >> for the SK boards, for example, the SK-AM69 uses the AM69 >> part from the J784s4 family, so it is called k3-am69-sk.dts >> with compatible = "ti,am69-sk", "ti,j784s4"; >> >> This would otherwise be the first board with a specific part >> attached but uses the SoC family name instead of that specific >> part name in the DT file/name. Only the EVMs should have the >> family name since we sell versions of those with all the different >> parts swapped onto it. I don't imagine you will be selling >> BeagleY's with TDA4VEN, TDA4AEN, DRA82x, etc.. All your >> docs and other collateral use "AM67", using the same here >> would help avoid confusion. >> >> Andrew > > Andrew, would you like us to model this just like the AM69-SK? and > also rename the device tree? or just the bindings.. > > k3-j722s-beagley-ai.dtb -> k3-am67-beagley-ai.dtb or even the am67a > k3-am67a-beagley-ai.dtb ? > Yes, rename binding and dtb name would be great. Better now then have the name confuse folks forever. AM67A is more correct than AM67 (which is the spin without AI), given this is an AI focused device I'd imagine you'll be using the "a" version. Andrew > Regards, >
diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml index 52b51fd7044e..ca23b7e6a35e 100644 --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml @@ -134,6 +134,7 @@ properties: - description: K3 J722S SoC and Boards items: - enum: + - beagle,j722s-beagley-ai - ti,j722s-evm - const: ti,j722s
This board is based on ti,j722s https://beagley-ai.org/ https://openbeagle.org/beagley-ai/beagley-ai Signed-off-by: Robert Nelson <robertcnelson@gmail.com> CC: Rob Herring <robh@kernel.org> CC: Nishanth Menon <nm@ti.com> CC: Jared McArthur <j-mcarthur@ti.com> CC: Jason Kridner <jkridner@beagleboard.org> CC: Deepak Khatri <lorforlinux@beagleboard.org> --- Documentation/devicetree/bindings/arm/ti/k3.yaml | 1 + 1 file changed, 1 insertion(+)