mbox series

[0/2] KVM: arm64: Avoid NULL dereference in vgic-v2 device attr accessors

Message ID 20240424173959.3776798-1-oliver.upton@linux.dev (mailing list archive)
Headers show
Series KVM: arm64: Avoid NULL dereference in vgic-v2 device attr accessors | expand

Message

Oliver Upton April 24, 2024, 5:39 p.m. UTC
Alex reports that it is possible to trigger a NULL dereference via the
vgic-v2 device attribute accessors, stemming from a lack of sanitization
of user input...

Here's a fix + regression test for the bug. Obviously, I intend to take
these as a fix ASAP.

Oliver Upton (2):
  KVM: arm64: vgic-v2: Check for non-NULL vCPU in vgic_v2_parse_attr()
  KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF

 arch/arm64/kvm/vgic/vgic-kvm-device.c         |  8 +--
 .../testing/selftests/kvm/aarch64/vgic_init.c | 49 +++++++++++++++++++
 2 files changed, 53 insertions(+), 4 deletions(-)


base-commit: fec50db7033ea478773b159e0e2efb135270e3b7

Comments

Marc Zyngier April 24, 2024, 6:06 p.m. UTC | #1
On Wed, 24 Apr 2024 18:39:57 +0100,
Oliver Upton <oliver.upton@linux.dev> wrote:
> 
> Alex reports that it is possible to trigger a NULL dereference via the
> vgic-v2 device attribute accessors, stemming from a lack of sanitization
> of user input...
> 
> Here's a fix + regression test for the bug. Obviously, I intend to take
> these as a fix ASAP.
> 
> Oliver Upton (2):
>   KVM: arm64: vgic-v2: Check for non-NULL vCPU in vgic_v2_parse_attr()
>   KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF
> 
>  arch/arm64/kvm/vgic/vgic-kvm-device.c         |  8 +--
>  .../testing/selftests/kvm/aarch64/vgic_init.c | 49 +++++++++++++++++++
>  2 files changed, 53 insertions(+), 4 deletions(-)
> 
> 
> base-commit: fec50db7033ea478773b159e0e2efb135270e3b7

Thanks Alex for the heads up!

Reviewed-by: Marc Zyngier <maz@kernel.org>

Please queue this at your earliest convenience.

	M.
Oliver Upton April 24, 2024, 7:15 p.m. UTC | #2
On Wed, 24 Apr 2024 17:39:57 +0000, Oliver Upton wrote:
> Alex reports that it is possible to trigger a NULL dereference via the
> vgic-v2 device attribute accessors, stemming from a lack of sanitization
> of user input...
> 
> Here's a fix + regression test for the bug. Obviously, I intend to take
> these as a fix ASAP.
> 
> [...]

Applied to kvmarm/fixes, thanks!

[1/2] KVM: arm64: vgic-v2: Check for non-NULL vCPU in vgic_v2_parse_attr()
      https://git.kernel.org/kvmarm/kvmarm/c/6ddb4f372fc6
[2/2] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF
      https://git.kernel.org/kvmarm/kvmarm/c/160933e330f4

--
Best,
Oliver