| Message ID | 20240425023325.15586-1-SkyLake.Huang@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: phy: mediatek: Integrate mtk-phy-lib and add 2.5Gphy support | expand |
Hi SkyLake, On Thu, Apr 25, 2024 at 10:33:22AM +0800, Sky Huang wrote: > From: "SkyLake.Huang" <skylake.huang@mediatek.com> > > Re-organize MTK ethernet phy drivers and integrate common manipulations > into mtk-phy-lib. Also, add support for build-in 2.5Gphy on MT7988. I assume this should go to net-next. You should mention the target tree like [PATCH net-next 0/3] and so on, in this case it's pretty obvious though. Generally the series looks fine and I'm glad you factored-out common parts like the LED handling which is a great improvement also for the older PHYs found in MT7530 and MT7531 as well as MT7621 and MT7623N. Splitting the the 3rd patch into more atomic changes would make reviewing a bit easier. Also note that I've recently submitted some fixes for the LED support which now have already been accepted to the net tree, see https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=5b5f724b05c550e10693a53a81cadca901aefd16 So it might be the best to wait for the next round of rebase of net-next before dealing with your suggested changes to spare maintainers from having to deal with the merge conflicts otherwise. Generally it'd also be nice to add support for the NO_LINK rule to the netdev trigger, as it is supported by the hardware, but that can also be done later obviously. Cheers Daniel > > SkyLake.Huang (3): > net: phy: mediatek: Re-organize MediaTek ethernet phy drivers > net: phy: mediatek: Add mtk phy lib for token ring access & LED/other > manipulations > net: phy: mediatek: add support for built-in 2.5G ethernet PHY on > MT7988 > > MAINTAINERS | 7 +- > drivers/net/phy/Kconfig | 17 +- > drivers/net/phy/Makefile | 3 +- > drivers/net/phy/mediatek-ge.c | 111 ---- > drivers/net/phy/mediatek/Kconfig | 33 ++ > drivers/net/phy/mediatek/Makefile | 5 + > drivers/net/phy/mediatek/mtk-2p5ge.c | 399 +++++++++++++ > .../mtk-ge-soc.c} | 522 ++++++++---------- > drivers/net/phy/mediatek/mtk-ge.c | 191 +++++++ > drivers/net/phy/mediatek/mtk-phy-lib.c | 330 +++++++++++ > drivers/net/phy/mediatek/mtk.h | 97 ++++ > 11 files changed, 1277 insertions(+), 438 deletions(-) > delete mode 100644 drivers/net/phy/mediatek-ge.c > create mode 100644 drivers/net/phy/mediatek/Kconfig > create mode 100644 drivers/net/phy/mediatek/Makefile > create mode 100644 drivers/net/phy/mediatek/mtk-2p5ge.c > rename drivers/net/phy/{mediatek-ge-soc.c => mediatek/mtk-ge-soc.c} (79%) > create mode 100644 drivers/net/phy/mediatek/mtk-ge.c > create mode 100644 drivers/net/phy/mediatek/mtk-phy-lib.c > create mode 100644 drivers/net/phy/mediatek/mtk.h > > -- > 2.18.0 >
From: "SkyLake.Huang" <skylake.huang@mediatek.com> Re-organize MTK ethernet phy drivers and integrate common manipulations into mtk-phy-lib. Also, add support for build-in 2.5Gphy on MT7988. SkyLake.Huang (3): net: phy: mediatek: Re-organize MediaTek ethernet phy drivers net: phy: mediatek: Add mtk phy lib for token ring access & LED/other manipulations net: phy: mediatek: add support for built-in 2.5G ethernet PHY on MT7988 MAINTAINERS | 7 +- drivers/net/phy/Kconfig | 17 +- drivers/net/phy/Makefile | 3 +- drivers/net/phy/mediatek-ge.c | 111 ---- drivers/net/phy/mediatek/Kconfig | 33 ++ drivers/net/phy/mediatek/Makefile | 5 + drivers/net/phy/mediatek/mtk-2p5ge.c | 399 +++++++++++++ .../mtk-ge-soc.c} | 522 ++++++++---------- drivers/net/phy/mediatek/mtk-ge.c | 191 +++++++ drivers/net/phy/mediatek/mtk-phy-lib.c | 330 +++++++++++ drivers/net/phy/mediatek/mtk.h | 97 ++++ 11 files changed, 1277 insertions(+), 438 deletions(-) delete mode 100644 drivers/net/phy/mediatek-ge.c create mode 100644 drivers/net/phy/mediatek/Kconfig create mode 100644 drivers/net/phy/mediatek/Makefile create mode 100644 drivers/net/phy/mediatek/mtk-2p5ge.c rename drivers/net/phy/{mediatek-ge-soc.c => mediatek/mtk-ge-soc.c} (79%) create mode 100644 drivers/net/phy/mediatek/mtk-ge.c create mode 100644 drivers/net/phy/mediatek/mtk-phy-lib.c create mode 100644 drivers/net/phy/mediatek/mtk.h