mbox series

[net-next,v2,0/4] net: sparx5: flower: validate control flags

Message ID 20240424121632.459022-1-ast@fiberby.net (mailing list archive)
Headers show
Series net: sparx5: flower: validate control flags | expand

Message

Asbjørn Sloth Tønnesen April 24, 2024, 12:16 p.m. UTC
This series adds flower control flags validation to the
sparx5 driver, and changes it from assuming that it handles
all control flags, to instead reject rules if they have
masked any unknown/unsupported control flags.

---

Changelog:

v2:
* Split first patch into 3 (requested by Jiri)
* Convert a missed extack usage (noticed by Daniel)
* Added cover letter (requested by Simon and Daniel)

v1: https://lore.kernel.org/netdev/20240423102728.228765-1-ast@fiberby.net/

Asbjørn Sloth Tønnesen (4):
  net: sparx5: flower: only do lookup if fragment flags are set
  net: sparx5: flower: add extack to
    sparx5_tc_flower_handler_control_usage()
  net: sparx5: flower: remove goto in
    sparx5_tc_flower_handler_control_usage()
  net: sparx5: flower: check for unsupported control flags

 .../microchip/sparx5/sparx5_tc_flower.c       | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

Comments

Daniel Machon April 24, 2024, 1:39 p.m. UTC | #1
> This series adds flower control flags validation to the
> sparx5 driver, and changes it from assuming that it handles
> all control flags, to instead reject rules if they have
> masked any unknown/unsupported control flags.
> 
> ---
> 
> Changelog:
> 
> v2:
> * Split first patch into 3 (requested by Jiri)
> * Convert a missed extack usage (noticed by Daniel)
> * Added cover letter (requested by Simon and Daniel)
> 
> v1: https://lore.kernel.org/netdev/20240423102728.228765-1-ast@fiberby.net/
> 
> Asbjørn Sloth Tønnesen (4):
>   net: sparx5: flower: only do lookup if fragment flags are set
>   net: sparx5: flower: add extack to
>     sparx5_tc_flower_handler_control_usage()
>   net: sparx5: flower: remove goto in
>     sparx5_tc_flower_handler_control_usage()
>   net: sparx5: flower: check for unsupported control flags
> 
>  .../microchip/sparx5/sparx5_tc_flower.c       | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 
> --
> 2.43.0
>

For the series:

Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Tested-by: Daniel Machon <daniel.machon@microchip.com>
patchwork-bot+netdevbpf@kernel.org April 26, 2024, 2:40 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 24 Apr 2024 12:16:21 +0000 you wrote:
> This series adds flower control flags validation to the
> sparx5 driver, and changes it from assuming that it handles
> all control flags, to instead reject rules if they have
> masked any unknown/unsupported control flags.
> 
> ---
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/4] net: sparx5: flower: only do lookup if fragment flags are set
    https://git.kernel.org/netdev/net-next/c/bcf303c62c98
  - [net-next,v2,2/4] net: sparx5: flower: add extack to sparx5_tc_flower_handler_control_usage()
    https://git.kernel.org/netdev/net-next/c/8cd1b6c0bf31
  - [net-next,v2,3/4] net: sparx5: flower: remove goto in sparx5_tc_flower_handler_control_usage()
    https://git.kernel.org/netdev/net-next/c/b92eb1ac13f0
  - [net-next,v2,4/4] net: sparx5: flower: check for unsupported control flags
    https://git.kernel.org/netdev/net-next/c/8ef631e9c995

You are awesome, thank you!