[0/6] migration removals & deprecations

Message

Fabiano Rosas April 25, 2024, 3:09 p.m. UTC

Hi everyone,

Here's some cleaning up of deprecated code. It removes the old block
migration and compression code. Both have suitable replacements in the
form of the blockdev-mirror driver and multifd compression,
respectively.

There's also a deprecation for fd: + file to cope with the fact that
the new MigrationAddress API defines transports instead of protocols
(loose terms) like the old string API did. So we cannot map 1:1 from
fd: to any transport because fd: allows *both* file migration and
socket migration.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/1267859704

Fabiano Rosas (6):
  migration: Remove 'skipped' field from MigrationStats
  migration: Remove 'inc' option from migrate command
  migration: Remove 'blk/-b' option from migrate commands
  migration: Remove block migration
  migration: Remove non-multifd compression
  migration: Deprecate fd: for file migration

 .gitlab-ci.d/buildtest.yml       |    2 +-
 MAINTAINERS                      |    1 -
 docs/about/deprecated.rst        |   51 +-
 docs/about/removed-features.rst  |  104 ++-
 docs/devel/migration/main.rst    |    2 +-
 hw/core/machine.c                |    1 -
 include/migration/misc.h         |    6 -
 meson.build                      |    2 -
 meson_options.txt                |    2 -
 migration/block.c                | 1019 ------------------------------
 migration/block.h                |   52 --
 migration/colo.c                 |    1 -
 migration/meson.build            |    4 -
 migration/migration-hmp-cmds.c   |   97 +--
 migration/migration.c            |   70 +-
 migration/migration.h            |    7 -
 migration/options.c              |  229 -------
 migration/ram-compress.c         |  564 -----------------
 migration/ram.c                  |  166 +----
 migration/savevm.c               |    5 -
 qapi/migration.json              |  205 +-----
 scripts/meson-buildoptions.sh    |    4 -
 tests/qemu-iotests/183           |  147 -----
 tests/qemu-iotests/183.out       |   66 --
 tests/qemu-iotests/common.filter |    7 -
 tests/qtest/migration-test.c     |  139 ----
 26 files changed, 130 insertions(+), 2823 deletions(-)
 delete mode 100644 migration/block.c
 delete mode 100644 migration/block.h
 delete mode 100644 migration/ram-compress.c
 delete mode 100755 tests/qemu-iotests/183
 delete mode 100644 tests/qemu-iotests/183.out

Comments

Markus Armbruster April 26, 2024, 6:02 a.m. UTC | #1

Doesn't apply for me.  What's your base?

Fabiano Rosas April 26, 2024, 12:51 p.m. UTC | #2

Markus Armbruster <[e-mail]> writes:

> Doesn't apply for me.  What's your base?

88daa112d4 ("Merge tag 'migration-20240423-pull-request' of
https://gitlab.com/peterx/qemu into staging")

Probably clashed with the other removals from Philippe.

Markus Armbruster April 26, 2024, 1:08 p.m. UTC | #3

Fabiano Rosas <[e-mail]> writes:

> Markus Armbruster <[e-mail]> writes:
>
>> Doesn't apply for me.  What's your base?
>
> 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of
> https://gitlab.com/peterx/qemu into staging")
>
> Probably clashed with the other removals from Philippe.

Thanks!

Fabiano Rosas April 26, 2024, 1:15 p.m. UTC | #4

Markus Armbruster <[e-mail]> writes:

> Fabiano Rosas <[e-mail]> writes:
>
>> Markus Armbruster <[e-mail]> writes:
>>
>>> Doesn't apply for me.  What's your base?
>>
>> 88daa112d4 ("Merge tag 'migration-20240423-pull-request' of
>> https://gitlab.com/peterx/qemu into staging")
>>
>> Probably clashed with the other removals from Philippe.
>
> Thanks!

I sent a respin a moment ago.