| Message ID | 20240425163758.809025-1-willy@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bio: Export bio_add_folio_nofail to modules | expand |
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote: > Several modules use __bio_add_page() today and may need to be converted > to bio_add_folio_nofail(). Confused, we don't have any modular users of this. A change like this should be submitted with a conversion.
On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote: > On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote: > > Several modules use __bio_add_page() today and may need to be converted > > to bio_add_folio_nofail(). > > Confused, we don't have any modular users of this. A change like this > should be submitted with a conversion. Thank you for reinforcing my point. https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/ Can I have an Acked-by so David can take it through the btrfs tree?
On 4/26/24 8:02 AM, Matthew Wilcox wrote: > On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote: >> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote: >>> Several modules use __bio_add_page() today and may need to be converted >>> to bio_add_folio_nofail(). >> >> Confused, we don't have any modular users of this. A change like this >> should be submitted with a conversion. > > Thank you for reinforcing my point. > > https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/ > > Can I have an Acked-by so David can take it through the btrfs tree? Yeah that's fine, makes more sense now than the standalone one: Reviewed-by: Jens Axboe <axboe@kernel.dk>
On Fri, Apr 26, 2024 at 08:03:56AM -0600, Jens Axboe wrote: > On 4/26/24 8:02 AM, Matthew Wilcox wrote: > > On Fri, Apr 26, 2024 at 07:41:29AM -0600, Jens Axboe wrote: > >> On 4/25/24 10:37 AM, Matthew Wilcox (Oracle) wrote: > >>> Several modules use __bio_add_page() today and may need to be converted > >>> to bio_add_folio_nofail(). > >> > >> Confused, we don't have any modular users of this. A change like this > >> should be submitted with a conversion. > > > > Thank you for reinforcing my point. > > > > https://lore.kernel.org/linux-fsdevel/ZiqHIH3lIzcRXCkU@casper.infradead.org/ > > > > Can I have an Acked-by so David can take it through the btrfs tree? > > Yeah that's fine, makes more sense now than the standalone one: > > Reviewed-by: Jens Axboe <axboe@kernel.dk> Thanks, I'll add it to Matthew's series in my patch queue and it'll appear in linux-next soon.
diff --git a/block/bio.c b/block/bio.c index 38baedb39c6f..3f3977c69997 100644 --- a/block/bio.c +++ b/block/bio.c @@ -1125,6 +1125,7 @@ void bio_add_folio_nofail(struct bio *bio, struct folio *folio, size_t len, WARN_ON_ONCE(off > UINT_MAX); __bio_add_page(bio, &folio->page, len, off); } +EXPORT_SYMBOL_GPL(bio_add_folio_nofail); /** * bio_add_folio - Attempt to add part of a folio to a bio.
Several modules use __bio_add_page() today and may need to be converted to bio_add_folio_nofail(). Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- block/bio.c | 1 + 1 file changed, 1 insertion(+)