| Message ID | 20240428011236.1008917-1-chao@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 48d180e2bf5a527ba6513a8abddf8b3beb6b7674 |
| Headers | show |
| Series | [f2fs-dev,v2] f2fs: zone: fix to don't trigger OPU on pinfile for direct IO | expand |
On Sat, Apr 27, 2024 at 6:12 PM Chao Yu <chao@kernel.org> wrote: > > Otherwise, it breaks pinfile's sematics. > > Cc: Daeho Jeong <daeho43@gmail.com> > Signed-off-by: Chao Yu <chao@kernel.org> > --- > v2: > - fix to disallow OPU on pinfile no matter what device type f2fs uses. > fs/f2fs/data.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index d8e4434e8801..56600dd43834 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -1595,8 +1595,9 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) > } > > /* use out-place-update for direct IO under LFS mode */ > - if (map->m_may_create && > - (is_hole || (f2fs_lfs_mode(sbi) && flag == F2FS_GET_BLOCK_DIO))) { > + if (map->m_may_create && (is_hole || > + (flag == F2FS_GET_BLOCK_DIO && f2fs_lfs_mode(sbi) && > + !f2fs_is_pinned_file(inode)))) { > if (unlikely(f2fs_cp_error(sbi))) { > err = -EIO; > goto sync_out; > -- > 2.40.1 > Reviewed-by: Daeho Jeong <daehojeong@google.com> Thanks,
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Sun, 28 Apr 2024 09:12:36 +0800 you wrote: > Otherwise, it breaks pinfile's sematics. > > Cc: Daeho Jeong <daeho43@gmail.com> > Signed-off-by: Chao Yu <chao@kernel.org> > --- > v2: > - fix to disallow OPU on pinfile no matter what device type f2fs uses. > fs/f2fs/data.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Here is the summary with links: - [f2fs-dev,v2] f2fs: zone: fix to don't trigger OPU on pinfile for direct IO https://git.kernel.org/jaegeuk/f2fs/c/48d180e2bf5a You are awesome, thank you!
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index d8e4434e8801..56600dd43834 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1595,8 +1595,9 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) } /* use out-place-update for direct IO under LFS mode */ - if (map->m_may_create && - (is_hole || (f2fs_lfs_mode(sbi) && flag == F2FS_GET_BLOCK_DIO))) { + if (map->m_may_create && (is_hole || + (flag == F2FS_GET_BLOCK_DIO && f2fs_lfs_mode(sbi) && + !f2fs_is_pinned_file(inode)))) { if (unlikely(f2fs_cp_error(sbi))) { err = -EIO; goto sync_out;
Otherwise, it breaks pinfile's sematics. Cc: Daeho Jeong <daeho43@gmail.com> Signed-off-by: Chao Yu <chao@kernel.org> --- v2: - fix to disallow OPU on pinfile no matter what device type f2fs uses. fs/f2fs/data.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)