| Message ID | 20240426-n-const-ops-var-v2-0-e553fe67ae82@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: Constify local snd_sof_dsp_ops | expand |
On Fri, 26 Apr 2024 11:03:47 +0200, Krzysztof Kozlowski wrote: > Changes in v2 > ============= > - Only rebase on for-next of broonie/sound.git > - Add tags. > - Link to v1: https://lore.kernel.org/r/20240414-n-const-ops-var-v1-0-8f53ee5d981c@kernel.org > > Description > =========== > The core code does not modify the 'struct snd_sof_dsp_ops' passed via > pointer in various places, so this can be made pointer to const in few > places. This in turn allows few drivers to have the local (usually > static) 'struct snd_sof_dsp_ops' as const which increased code safety, > as it is now part of rodata. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [01/14] ASoC: SOF: debug: Constify local snd_sof_dsp_ops commit: ffca099bbff1978bc9c97b076f0d35b4fe6ddf27 [02/14] ASoC: SOF: ipc3: Constify local snd_sof_dsp_ops commit: ee5acc1e035ec5ed5d9f0f63fda9d627220090c2 [03/14] ASoC: SOF: pcm: Constify local snd_sof_dsp_ops commit: a0db037df9630edad76153c7937c6f5ca04ed44f [04/14] ASoC: SOF: Constify stored pointer to snd_sof_dsp_ops commit: 8bbc692d1abce5bc949dea9acba85fc686601c04 [05/14] ASoC: SOF: intel: pci-tng: Constify snd_sof_dsp_ops commit: 8f2b0d55abc44676b076128903a5dc730aab23c6 [06/14] ASoC: SOF: intel: hda: Constify snd_sof_dsp_ops commit: 6032eefc2c478243a511352dda04495c9a9fec6a [07/14] ASoC: SOF: amd: acp: Constify snd_sof_dsp_ops commit: 04f2f516be09d5493d764e0020a771c46b5470d8 [08/14] ASoC: SOF: imx8: Constify snd_sof_dsp_ops commit: ab85c44973298b69eb32795de11ce4d426705532 [09/14] ASoC: SOF: imx8m: Constify snd_sof_dsp_ops commit: 66d49ab5fb51bb8d1b4c2c9c8fa0fbe8e4c8ca1c [10/14] ASoC: SOF: imx8ulp: Constify snd_sof_dsp_ops commit: 232e0da9fa778233358586617bd22173bcac6bcc [11/14] ASoC: SOF: intel: bdw: Constify snd_sof_dsp_ops commit: 936cc56044a87ae7fbd0e4098a7daefa0f2f4e8e [12/14] ASoC: SOF: intel: byt: Constify snd_sof_dsp_ops commit: 48d5f1800d0cbda0212c5a58177918c419a24f8a [13/14] ASoC: SOF: mediatek: mt8186: Constify snd_sof_dsp_ops commit: fe80673f59da01776a1402e4b508a66fca43a24d [14/14] ASoC: SOF: mediatek: mt8195: Constify snd_sof_dsp_ops commit: 8b6d678fede700db6466d73f11fcbad496fa515e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, Changes in v2 ============= - Only rebase on for-next of broonie/sound.git - Add tags. - Link to v1: https://lore.kernel.org/r/20240414-n-const-ops-var-v1-0-8f53ee5d981c@kernel.org Description =========== The core code does not modify the 'struct snd_sof_dsp_ops' passed via pointer in various places, so this can be made pointer to const in few places. This in turn allows few drivers to have the local (usually static) 'struct snd_sof_dsp_ops' as const which increased code safety, as it is now part of rodata. Not all drivers can be made safer that way. Intel and AMD rely on customizing that 'struct snd_sof_dsp_ops' before passing to SOF, so they won't benefit. They don't lose anything., either. All further patches depend on the first four patches. Best regards, Krzysztof --- Krzysztof Kozlowski (14): ASoC: SOF: debug: Constify local snd_sof_dsp_ops ASoC: SOF: ipc3: Constify local snd_sof_dsp_ops ASoC: SOF: pcm: Constify local snd_sof_dsp_ops ASoC: SOF: Constify stored pointer to snd_sof_dsp_ops ASoC: SOF: intel: pci-tng: Constify snd_sof_dsp_ops ASoC: SOF: intel: hda: Constify snd_sof_dsp_ops ASoC: SOF: amd: acp: Constify snd_sof_dsp_ops ASoC: SOF: imx8: Constify snd_sof_dsp_ops ASoC: SOF: imx8m: Constify snd_sof_dsp_ops ASoC: SOF: imx8ulp: Constify snd_sof_dsp_ops ASoC: SOF: intel: bdw: Constify snd_sof_dsp_ops ASoC: SOF: intel: byt: Constify snd_sof_dsp_ops ASoC: SOF: mediatek: mt8186: Constify snd_sof_dsp_ops ASoC: SOF: mediatek: mt8195: Constify snd_sof_dsp_ops include/sound/sof.h | 2 +- sound/soc/sof/amd/acp-common.c | 2 +- sound/soc/sof/amd/acp.h | 2 +- sound/soc/sof/debug.c | 2 +- sound/soc/sof/imx/imx8.c | 4 ++-- sound/soc/sof/imx/imx8m.c | 2 +- sound/soc/sof/imx/imx8ulp.c | 2 +- sound/soc/sof/intel/bdw.c | 2 +- sound/soc/sof/intel/byt.c | 4 ++-- sound/soc/sof/intel/hda-common-ops.c | 2 +- sound/soc/sof/intel/hda.h | 2 +- sound/soc/sof/intel/pci-tng.c | 2 +- sound/soc/sof/intel/shim.h | 2 +- sound/soc/sof/ipc3-priv.h | 6 +++--- sound/soc/sof/mediatek/mt8186/mt8186.c | 2 +- sound/soc/sof/mediatek/mt8195/mt8195.c | 2 +- sound/soc/sof/pcm.c | 2 +- 17 files changed, 21 insertions(+), 21 deletions(-) --- base-commit: efdfbbc4dcc8f98754056971f88af0f7ff906144 change-id: 20240414-n-const-ops-var-136f395b374b Best regards,