diff mbox series

arm64: dts: qcom: qcs404: fix bluetooth device address

Message ID 20240501075201.4732-1-johan+linaro@kernel.org (mailing list archive)
State Accepted
Commit f5f390a77f18eaeb2c93211a1b7c5e66b5acd423
Headers show
Series arm64: dts: qcom: qcs404: fix bluetooth device address | expand

Commit Message

Johan Hovold May 1, 2024, 7:52 a.m. UTC
The 'local-bd-address' property is used to pass a unique Bluetooth
device address from the boot firmware to the kernel and should otherwise
be left unset so that the OS can prevent the controller from being used
until a valid address has been provided through some other means (e.g.
using btmgmt).

Fixes: 60f77ae7d1c1 ("arm64: dts: qcom: qcs404-evb: Enable uart3 and add Bluetooth")
Cc: stable@vger.kernel.org	# 5.10
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bryan O'Donoghue May 1, 2024, 10:14 a.m. UTC | #1
On 01/05/2024 08:52, Johan Hovold wrote:
> The 'local-bd-address' property is used to pass a unique Bluetooth
> device address from the boot firmware to the kernel and should otherwise
> be left unset so that the OS can prevent the controller from being used
> until a valid address has been provided through some other means (e.g.
> using btmgmt).
> 
> Fixes: 60f77ae7d1c1 ("arm64: dts: qcom: qcs404-evb: Enable uart3 and add Bluetooth")
> Cc: stable@vger.kernel.org	# 5.10
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> index 10655401528e..a22b4501ce1e 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
> @@ -62,7 +62,7 @@ bluetooth {
>   		vddrf-supply = <&vreg_l1_1p3>;
>   		vddch0-supply = <&vdd_ch0_3p3>;
>   
> -		local-bd-address = [ 02 00 00 00 5a ad ];
> +		local-bd-address = [ 00 00 00 00 00 00 ];
>   
>   		max-speed = <3200000>;
>   	};

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Bjorn Andersson May 1, 2024, 8:20 p.m. UTC | #2
On Wed, 01 May 2024 09:52:01 +0200, Johan Hovold wrote:
> The 'local-bd-address' property is used to pass a unique Bluetooth
> device address from the boot firmware to the kernel and should otherwise
> be left unset so that the OS can prevent the controller from being used
> until a valid address has been provided through some other means (e.g.
> using btmgmt).
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: qcs404: fix bluetooth device address
      commit: f5f390a77f18eaeb2c93211a1b7c5e66b5acd423

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
index 10655401528e..a22b4501ce1e 100644
--- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi
@@ -62,7 +62,7 @@  bluetooth {
 		vddrf-supply = <&vreg_l1_1p3>;
 		vddch0-supply = <&vdd_ch0_3p3>;
 
-		local-bd-address = [ 02 00 00 00 5a ad ];
+		local-bd-address = [ 00 00 00 00 00 00 ];
 
 		max-speed = <3200000>;
 	};