| Message ID | 20240424-video-backlight-lcd-ops-v2-0-1aaa82b07bc6@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | backlight: Constify lcd_ops | expand |
On Wed, 24 Apr 2024, Krzysztof Kozlowski wrote: > Hi, > > Changes in v2: > - Collect tags, including wrongly places Thomas' tag (which requires me > to manually edit 15 other patches to drop it). > - Combine here checkpatch patch: > https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/ > - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org What's missing? Are we good to go? > Dependencies > ============ > All further patches depend on the first patch. Therefore everything > could go via backlight tree (please ack) or via cross-tree pulls. Or > whatever maintainer choose, just coordinate this with backlight. > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (19): > backlight: Constify lcd_ops > backlight: ams369fg06: Constify lcd_ops > backlight: corgi_lcd: Constify lcd_ops > backlight: hx8357: Constify lcd_ops > backlight: ili922x: Constify lcd_ops > backlight: ili9320: Constify lcd_ops > backlight: jornada720_lcd: Constify lcd_ops > backlight: l4f00242t03: Constify lcd_ops > backlight: lms283gf05: Constify lcd_ops > backlight: lms501kf03: Constify lcd_ops > backlight: ltv350qv: Constify lcd_ops > backlight: otm3225a: Constify lcd_ops > backlight: platform_lcd: Constify lcd_ops > backlight: tdo24m: Constify lcd_ops > HID: picoLCD: Constify lcd_ops > fbdev: clps711x: Constify lcd_ops > fbdev: imx: Constify lcd_ops > fbdev: omap: lcd_ams_delta: Constify lcd_ops > const_structs.checkpatch: add lcd_ops > > drivers/hid/hid-picolcd_lcd.c | 2 +- > drivers/video/backlight/ams369fg06.c | 2 +- > drivers/video/backlight/corgi_lcd.c | 2 +- > drivers/video/backlight/hx8357.c | 2 +- > drivers/video/backlight/ili922x.c | 2 +- > drivers/video/backlight/ili9320.c | 2 +- > drivers/video/backlight/jornada720_lcd.c | 2 +- > drivers/video/backlight/l4f00242t03.c | 2 +- > drivers/video/backlight/lcd.c | 4 ++-- > drivers/video/backlight/lms283gf05.c | 2 +- > drivers/video/backlight/lms501kf03.c | 2 +- > drivers/video/backlight/ltv350qv.c | 2 +- > drivers/video/backlight/otm3225a.c | 2 +- > drivers/video/backlight/platform_lcd.c | 2 +- > drivers/video/backlight/tdo24m.c | 2 +- > drivers/video/fbdev/clps711x-fb.c | 2 +- > drivers/video/fbdev/imxfb.c | 2 +- > drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- > include/linux/lcd.h | 6 +++--- > scripts/const_structs.checkpatch | 1 + > 20 files changed, 23 insertions(+), 22 deletions(-) > --- > base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 > change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8 > > Best regards, > -- > Krzysztof Kozlowski <krzk@kernel.org> >
On 02/05/2024 09:22, Lee Jones wrote: > On Wed, 24 Apr 2024, Krzysztof Kozlowski wrote: > >> Hi, >> >> Changes in v2: >> - Collect tags, including wrongly places Thomas' tag (which requires me >> to manually edit 15 other patches to drop it). >> - Combine here checkpatch patch: >> https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/ >> - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org > > What's missing? Are we good to go? Nothing missing, you can take entire set (also last checkpatch patch which you acked). Best regards, Krzysztof
On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote: > Changes in v2: > - Collect tags, including wrongly places Thomas' tag (which requires me > to manually edit 15 other patches to drop it). > - Combine here checkpatch patch: > https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/ > - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org > > [...] Applied, thanks! [01/19] backlight: Constify lcd_ops commit: 9258e31adebf0ccf0797867841f3f9800695dba2 [02/19] backlight: ams369fg06: Constify lcd_ops commit: 8053c4fa200c3fef07859bac9469ad3f26f5aba1 [03/19] backlight: corgi_lcd: Constify lcd_ops commit: 18c5d4ab9f6312f2c9c6c409287d552112db810a [04/19] backlight: hx8357: Constify lcd_ops commit: 1d669c1998b559393ec2eaac0449f4989a255049 [05/19] backlight: ili922x: Constify lcd_ops commit: e77fef89de954b1557cb91b64696cd4fc06c80ad [06/19] backlight: ili9320: Constify lcd_ops commit: 06cfc92faa1eabb2ea226c58d6fd0b5ab117ee39 [07/19] backlight: jornada720_lcd: Constify lcd_ops commit: a54b4999dc204bc5839bb70602078c7c8e4a5010 [08/19] backlight: l4f00242t03: Constify lcd_ops commit: 657e6c1b270e9f4a890059f5d08a08ea842fa1a8 [09/19] backlight: lms283gf05: Constify lcd_ops commit: 66e5a10818fd332e973d36429e36f4c436a86a91 [10/19] backlight: lms501kf03: Constify lcd_ops commit: 31c205d1e8426dd0cce0143c500ff1ff71fe64d1 [11/19] backlight: ltv350qv: Constify lcd_ops commit: 24424f84d7568d9d794657622e080b1cba1e9290 [12/19] backlight: otm3225a: Constify lcd_ops commit: 02949072ee8fb6141cd8ac2be9867ef466580ddb [13/19] backlight: platform_lcd: Constify lcd_ops commit: d217a8d5a39851caa16996756682715c9debb4a9 [14/19] backlight: tdo24m: Constify lcd_ops commit: c7a1809d1982f671e66a4b1c1ffd8bdd5ba260aa [15/19] HID: picoLCD: Constify lcd_ops commit: 238724635763e7c5d82c0581b0c49e5dfdd5505a [16/19] fbdev: clps711x: Constify lcd_ops commit: 55d9a955375af3b3fd5725a9b5cbc658d4bdd244 [17/19] fbdev: imx: Constify lcd_ops commit: a6abbb5783345c4c7cc9fbd583b81e167bd0207d [18/19] fbdev: omap: lcd_ams_delta: Constify lcd_ops commit: ca991e8e096c9f0cff0300289e2d4813192b8ef3 [19/19] const_structs.checkpatch: add lcd_ops commit: f02aeccbec6108d768f54d31e7cb48b06c0e3814 -- Lee Jones [李琼斯]
On Fri, 03 May 2024, Lee Jones wrote: > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote: > > Changes in v2: > > - Collect tags, including wrongly places Thomas' tag (which requires me > > to manually edit 15 other patches to drop it). > > - Combine here checkpatch patch: > > https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/ > > - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org > > > > [...] > > Applied, thanks! > > [01/19] backlight: Constify lcd_ops > commit: 9258e31adebf0ccf0797867841f3f9800695dba2 > [02/19] backlight: ams369fg06: Constify lcd_ops > commit: 8053c4fa200c3fef07859bac9469ad3f26f5aba1 > [03/19] backlight: corgi_lcd: Constify lcd_ops > commit: 18c5d4ab9f6312f2c9c6c409287d552112db810a > [04/19] backlight: hx8357: Constify lcd_ops > commit: 1d669c1998b559393ec2eaac0449f4989a255049 > [05/19] backlight: ili922x: Constify lcd_ops > commit: e77fef89de954b1557cb91b64696cd4fc06c80ad > [06/19] backlight: ili9320: Constify lcd_ops > commit: 06cfc92faa1eabb2ea226c58d6fd0b5ab117ee39 > [07/19] backlight: jornada720_lcd: Constify lcd_ops > commit: a54b4999dc204bc5839bb70602078c7c8e4a5010 > [08/19] backlight: l4f00242t03: Constify lcd_ops > commit: 657e6c1b270e9f4a890059f5d08a08ea842fa1a8 > [09/19] backlight: lms283gf05: Constify lcd_ops > commit: 66e5a10818fd332e973d36429e36f4c436a86a91 > [10/19] backlight: lms501kf03: Constify lcd_ops > commit: 31c205d1e8426dd0cce0143c500ff1ff71fe64d1 > [11/19] backlight: ltv350qv: Constify lcd_ops > commit: 24424f84d7568d9d794657622e080b1cba1e9290 > [12/19] backlight: otm3225a: Constify lcd_ops > commit: 02949072ee8fb6141cd8ac2be9867ef466580ddb > [13/19] backlight: platform_lcd: Constify lcd_ops > commit: d217a8d5a39851caa16996756682715c9debb4a9 > [14/19] backlight: tdo24m: Constify lcd_ops > commit: c7a1809d1982f671e66a4b1c1ffd8bdd5ba260aa > [15/19] HID: picoLCD: Constify lcd_ops > commit: 238724635763e7c5d82c0581b0c49e5dfdd5505a > [16/19] fbdev: clps711x: Constify lcd_ops > commit: 55d9a955375af3b3fd5725a9b5cbc658d4bdd244 > [17/19] fbdev: imx: Constify lcd_ops > commit: a6abbb5783345c4c7cc9fbd583b81e167bd0207d > [18/19] fbdev: omap: lcd_ams_delta: Constify lcd_ops > commit: ca991e8e096c9f0cff0300289e2d4813192b8ef3 > [19/19] const_structs.checkpatch: add lcd_ops > commit: f02aeccbec6108d768f54d31e7cb48b06c0e3814 Please ensure you use checkpatch.pl before submitting: ==== ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0 warnings, 0 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH v2 19/19] const_structs.checkpatch: add lcd_ops" has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: Missing commit description - Add an appropriate one ERROR: Missing Signed-off-by: line(s) total: 1 errors, 1 warnings, 7 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ==== Some of them are a little odd. I fixed the relevant ones Submitted for build testing. If successful, I'll submit a PR for the other maintainers soon.
On Fri, 03 May 2024, Lee Jones wrote: > On Fri, 03 May 2024, Lee Jones wrote: > > > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote: > > > Changes in v2: > > > - Collect tags, including wrongly places Thomas' tag (which requires me > > > to manually edit 15 other patches to drop it). > > > - Combine here checkpatch patch: > > > https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/ > > > - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org > > > > > > [...] > > > > Applied, thanks! > > > > [01/19] backlight: Constify lcd_ops > > commit: 9258e31adebf0ccf0797867841f3f9800695dba2 > > [02/19] backlight: ams369fg06: Constify lcd_ops > > commit: 8053c4fa200c3fef07859bac9469ad3f26f5aba1 > > [03/19] backlight: corgi_lcd: Constify lcd_ops > > commit: 18c5d4ab9f6312f2c9c6c409287d552112db810a > > [04/19] backlight: hx8357: Constify lcd_ops > > commit: 1d669c1998b559393ec2eaac0449f4989a255049 > > [05/19] backlight: ili922x: Constify lcd_ops > > commit: e77fef89de954b1557cb91b64696cd4fc06c80ad > > [06/19] backlight: ili9320: Constify lcd_ops > > commit: 06cfc92faa1eabb2ea226c58d6fd0b5ab117ee39 > > [07/19] backlight: jornada720_lcd: Constify lcd_ops > > commit: a54b4999dc204bc5839bb70602078c7c8e4a5010 > > [08/19] backlight: l4f00242t03: Constify lcd_ops > > commit: 657e6c1b270e9f4a890059f5d08a08ea842fa1a8 > > [09/19] backlight: lms283gf05: Constify lcd_ops > > commit: 66e5a10818fd332e973d36429e36f4c436a86a91 > > [10/19] backlight: lms501kf03: Constify lcd_ops > > commit: 31c205d1e8426dd0cce0143c500ff1ff71fe64d1 > > [11/19] backlight: ltv350qv: Constify lcd_ops > > commit: 24424f84d7568d9d794657622e080b1cba1e9290 > > [12/19] backlight: otm3225a: Constify lcd_ops > > commit: 02949072ee8fb6141cd8ac2be9867ef466580ddb > > [13/19] backlight: platform_lcd: Constify lcd_ops > > commit: d217a8d5a39851caa16996756682715c9debb4a9 > > [14/19] backlight: tdo24m: Constify lcd_ops > > commit: c7a1809d1982f671e66a4b1c1ffd8bdd5ba260aa > > [15/19] HID: picoLCD: Constify lcd_ops > > commit: 238724635763e7c5d82c0581b0c49e5dfdd5505a > > [16/19] fbdev: clps711x: Constify lcd_ops > > commit: 55d9a955375af3b3fd5725a9b5cbc658d4bdd244 > > [17/19] fbdev: imx: Constify lcd_ops > > commit: a6abbb5783345c4c7cc9fbd583b81e167bd0207d > > [18/19] fbdev: omap: lcd_ams_delta: Constify lcd_ops > > commit: ca991e8e096c9f0cff0300289e2d4813192b8ef3 > > [19/19] const_structs.checkpatch: add lcd_ops > > commit: f02aeccbec6108d768f54d31e7cb48b06c0e3814 > > Please ensure you use checkpatch.pl before submitting: > > ==== > > ERROR: Does not appear to be a unified-diff format patch > > total: 1 errors, 0 warnings, 0 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > "[PATCH v2 19/19] const_structs.checkpatch: add lcd_ops" has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > WARNING: Missing commit description - Add an appropriate one > > ERROR: Missing Signed-off-by: line(s) > > total: 1 errors, 1 warnings, 7 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > Your patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > ==== > > Some of them are a little odd. I fixed the relevant ones Change of plan - I actually can't find anything to fix. All of this reports seem bogus!
Hi, Changes in v2: - Collect tags, including wrongly places Thomas' tag (which requires me to manually edit 15 other patches to drop it). - Combine here checkpatch patch: https://lore.kernel.org/all/20240414185440.288812-1-krzk@kernel.org/ - Link to v1: https://lore.kernel.org/r/20240414-video-backlight-lcd-ops-v1-0-9b37fcbf546a@kernel.org Dependencies ============ All further patches depend on the first patch. Therefore everything could go via backlight tree (please ack) or via cross-tree pulls. Or whatever maintainer choose, just coordinate this with backlight. Best regards, Krzysztof --- Krzysztof Kozlowski (19): backlight: Constify lcd_ops backlight: ams369fg06: Constify lcd_ops backlight: corgi_lcd: Constify lcd_ops backlight: hx8357: Constify lcd_ops backlight: ili922x: Constify lcd_ops backlight: ili9320: Constify lcd_ops backlight: jornada720_lcd: Constify lcd_ops backlight: l4f00242t03: Constify lcd_ops backlight: lms283gf05: Constify lcd_ops backlight: lms501kf03: Constify lcd_ops backlight: ltv350qv: Constify lcd_ops backlight: otm3225a: Constify lcd_ops backlight: platform_lcd: Constify lcd_ops backlight: tdo24m: Constify lcd_ops HID: picoLCD: Constify lcd_ops fbdev: clps711x: Constify lcd_ops fbdev: imx: Constify lcd_ops fbdev: omap: lcd_ams_delta: Constify lcd_ops const_structs.checkpatch: add lcd_ops drivers/hid/hid-picolcd_lcd.c | 2 +- drivers/video/backlight/ams369fg06.c | 2 +- drivers/video/backlight/corgi_lcd.c | 2 +- drivers/video/backlight/hx8357.c | 2 +- drivers/video/backlight/ili922x.c | 2 +- drivers/video/backlight/ili9320.c | 2 +- drivers/video/backlight/jornada720_lcd.c | 2 +- drivers/video/backlight/l4f00242t03.c | 2 +- drivers/video/backlight/lcd.c | 4 ++-- drivers/video/backlight/lms283gf05.c | 2 +- drivers/video/backlight/lms501kf03.c | 2 +- drivers/video/backlight/ltv350qv.c | 2 +- drivers/video/backlight/otm3225a.c | 2 +- drivers/video/backlight/platform_lcd.c | 2 +- drivers/video/backlight/tdo24m.c | 2 +- drivers/video/fbdev/clps711x-fb.c | 2 +- drivers/video/fbdev/imxfb.c | 2 +- drivers/video/fbdev/omap/lcd_ams_delta.c | 2 +- include/linux/lcd.h | 6 +++--- scripts/const_structs.checkpatch | 1 + 20 files changed, 23 insertions(+), 22 deletions(-) --- base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8 Best regards,