diff mbox series

[v3,next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get

Message ID 20240502063621.65687-2-shresthprasad7@gmail.com (mailing list archive)
State New, archived
Headers show
Series [v3,next] backlight: sky81452-backlight: Remove unnecessary call to of_node_get | expand

Commit Message

Shresth Prasad May 2, 2024, 6:36 a.m. UTC 
`dev->of_node` already has a reference to the device_node and calling
of_node_get on it is unnecessary. All conresponding calls to
of_node_put are also removed.

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
---
Changes in v3:
    - Remove unnecessary braces

 drivers/video/backlight/sky81452-backlight.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Comments

Lee Jones May 2, 2024, 9:36 a.m. UTC | #1 
On Thu, 02 May 2024, Shresth Prasad wrote:

> `dev->of_node` already has a reference to the device_node and calling
> of_node_get on it is unnecessary. All conresponding calls to
> of_node_put are also removed.
> 
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> ---
> Changes in v3:
>     - Remove unnecessary braces
> 
>  drivers/video/backlight/sky81452-backlight.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

No idea what you're talking about.

This patch/version doesn't exist in either my inbox or LORE:

  https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
Shresth Prasad May 2, 2024, 10 a.m. UTC | #2 
On Thu, May 2, 2024 at 3:06 PM Lee Jones <lee@kernel.org> wrote:
>
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > `dev->of_node` already has a reference to the device_node and calling
> > of_node_get on it is unnecessary. All conresponding calls to
> > of_node_put are also removed.
> >
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> > ---
> > Changes in v3:
> >     - Remove unnecessary braces
> >
> >  drivers/video/backlight/sky81452-backlight.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
>
> No idea what you're talking about.
>
> This patch/version doesn't exist in either my inbox or LORE:
>
>   https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
>
> --
> Lee Jones [李琼斯]

I'm not sure what you mean.
The patches show up just fine:
https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get

If you mean that the first version doesn't show up, it's because the
commit message
was changed to better reflect changes.

Regards,
Shresth
Lee Jones May 2, 2024, 10:08 a.m. UTC | #3 
On Thu, 02 May 2024, Shresth Prasad wrote:

> On Thu, May 2, 2024 at 3:06 PM Lee Jones <lee@kernel.org> wrote:
> >
> > On Thu, 02 May 2024, Shresth Prasad wrote:
> >
> > > `dev->of_node` already has a reference to the device_node and calling
> > > of_node_get on it is unnecessary. All conresponding calls to
> > > of_node_put are also removed.
> > >
> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> > > ---
> > > Changes in v3:
> > >     - Remove unnecessary braces
> > >
> > >  drivers/video/backlight/sky81452-backlight.c | 8 ++------
> > >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > No idea what you're talking about.
> >
> > This patch/version doesn't exist in either my inbox or LORE:
> >
> >   https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
> >
> > --
> > Lee Jones [李琼斯]
> 
> I'm not sure what you mean.
> The patches show up just fine:
> https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get
> 
> If you mean that the first version doesn't show up, it's because the
> commit message
> was changed to better reflect changes.

Those are v2

You replied to a non-existent v3 which started a new thread.
Lee Jones May 2, 2024, 10:35 a.m. UTC | #4 
On Thu, 02 May 2024, Lee Jones wrote:

> On Thu, 02 May 2024, Shresth Prasad wrote:
> 
> > On Thu, May 2, 2024 at 3:06 PM Lee Jones <lee@kernel.org> wrote:
> > >
> > > On Thu, 02 May 2024, Shresth Prasad wrote:
> > >
> > > > `dev->of_node` already has a reference to the device_node and calling
> > > > of_node_get on it is unnecessary. All conresponding calls to
> > > > of_node_put are also removed.
> > > >
> > > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> > > > Signed-off-by: Shresth Prasad <shresthprasad7@gmail.com>
> > > > ---
> > > > Changes in v3:
> > > >     - Remove unnecessary braces
> > > >
> > > >  drivers/video/backlight/sky81452-backlight.c | 8 ++------
> > > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > No idea what you're talking about.
> > >
> > > This patch/version doesn't exist in either my inbox or LORE:
> > >
> > >   https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
> > >
> > > --
> > > Lee Jones [李琼斯]
> > 
> > I'm not sure what you mean.
> > The patches show up just fine:
> > https://lore.kernel.org/all/?q=backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get
> > 
> > If you mean that the first version doesn't show up, it's because the
> > commit message
> > was changed to better reflect changes.
> 
> Those are v2
> 
> You replied to a non-existent v3 which started a new thread.

Something funky is going on.  Your pokey emails are coming through
disconnected from the patches which is causing confusion.

The best thing going forward is to submit [RESEND]s instead of
contentless pokes.

Please submit a [RESEND] for v3 and we can start again.
diff mbox series

Patch

diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index eb18c6eb0ff0..19f9f84a9fd6 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -182,7 +182,7 @@  static const struct attribute_group sky81452_bl_attr_group = {
 static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
 							struct device *dev)
 {
-	struct device_node *np = of_node_get(dev->of_node);
+	struct device_node *np = dev->of_node;
 	struct sky81452_bl_platform_data *pdata;
 	int num_entry;
 	unsigned int sources[6];
@@ -194,10 +194,8 @@  static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
 	}
 
 	pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
-	if (!pdata) {
-		of_node_put(np);
+	if (!pdata)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	of_property_read_string(np, "name", &pdata->name);
 	pdata->ignore_pwm = of_property_read_bool(np, "skyworks,ignore-pwm");
@@ -217,7 +215,6 @@  static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
 					num_entry);
 		if (ret < 0) {
 			dev_err(dev, "led-sources node is invalid.\n");
-			of_node_put(np);
 			return ERR_PTR(-EINVAL);
 		}
 
@@ -237,7 +234,6 @@  static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
 	if (ret < 0)
 		pdata->boost_current_limit = 2750;
 
-	of_node_put(np);
 	return pdata;
 }
 #else