diff mbox series

arm64: dts: imx8qm: Add GPU nodes

Message ID 20240502215747.2832126-1-christian.gmeiner@gmail.com (mailing list archive)
State Superseded
Headers show
Series arm64: dts: imx8qm: Add GPU nodes | expand

Commit Message

Christian Gmeiner May 2, 2024, 9:57 p.m. UTC 
From: Christian Gmeiner <cgmeiner@igalia.com>

Add the DT node for the GPU core found on the i.MX8QM.

etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
[drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0

Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
---
 arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam May 2, 2024, 11:01 p.m. UTC | #1 
Hi Christian,

On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
<christian.gmeiner@gmail.com> wrote:
>
> From: Christian Gmeiner <cgmeiner@igalia.com>
>
> Add the DT node for the GPU core found on the i.MX8QM.
>
> etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
>
> Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> index b3d01677b70c..54879ae1d7d5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> @@ -467,6 +467,7 @@ drc_crit0: trip1 {
>         #include "imx8-ss-dma.dtsi"
>         #include "imx8-ss-conn.dtsi"
>         #include "imx8-ss-lsio.dtsi"
> +       #include "imx8-ss-gpu0.dtsi"

Nit: better put it in alphabetical order.

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Frank Li May 3, 2024, 3:05 a.m. UTC | #2 
On Thu, May 02, 2024 at 08:01:37PM -0300, Fabio Estevam wrote:
> Hi Christian,
> 
> On Thu, May 2, 2024 at 6:58 PM Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
> >
> > From: Christian Gmeiner <cgmeiner@igalia.com>
> >
> > Add the DT node for the GPU core found on the i.MX8QM.
> >
> > etnaviv-gpu 53100000.gpu: model: GC7000, revision: 6009
> > [drm] Initialized etnaviv 1.4.0 20151214 for etnaviv on minor 0
> >
> > Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > index b3d01677b70c..54879ae1d7d5 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
> > @@ -467,6 +467,7 @@ drc_crit0: trip1 {
> >         #include "imx8-ss-dma.dtsi"
> >         #include "imx8-ss-conn.dtsi"
> >         #include "imx8-ss-lsio.dtsi"
> > +       #include "imx8-ss-gpu0.dtsi"
> 
> Nit: better put it in alphabetical order.

No, it should be order by subsystem register address. gpu is 53100000.
should be between imx8-ss-vpu and imx8-ss-img. 

Frank

> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index b3d01677b70c..54879ae1d7d5 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -467,6 +467,7 @@  drc_crit0: trip1 {
 	#include "imx8-ss-dma.dtsi"
 	#include "imx8-ss-conn.dtsi"
 	#include "imx8-ss-lsio.dtsi"
+	#include "imx8-ss-gpu0.dtsi"
 };
 
 #include "imx8qm-ss-img.dtsi"