diff mbox series

[net,v1] netlink: specs: Add missing bridge linkinfo attrs

Message ID 20240503164304.87427-1-donald.hunter@gmail.com (mailing list archive)
State Accepted
Commit 9adcac6506185dd1a727f1784b89f30cd217ef7e
Delegated to: Netdev Maintainers
Headers show
Series [net,v1] netlink: specs: Add missing bridge linkinfo attrs | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 12 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-05-05--03-00 (tests: 1003)

Commit Message

Donald Hunter May 3, 2024, 4:43 p.m. UTC 
Attributes for FDB learned entries were added to the if_link netlink api
for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
missing attributes to the spec.

Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
---
 Documentation/netlink/specs/rt_link.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Nikolay Aleksandrov May 3, 2024, 4:53 p.m. UTC | #1 
On 03/05/2024 19:43, Donald Hunter wrote:
> Attributes for FDB learned entries were added to the if_link netlink api
> for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
> missing attributes to the spec.
> 
> Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
> ---
>  Documentation/netlink/specs/rt_link.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/rt_link.yaml b/Documentation/netlink/specs/rt_link.yaml
> index 8e4d19adee8c..4e702ac8bf66 100644
> --- a/Documentation/netlink/specs/rt_link.yaml
> +++ b/Documentation/netlink/specs/rt_link.yaml
> @@ -1144,6 +1144,12 @@ attribute-sets:
>        -
>          name: mcast-querier-state
>          type: binary
> +      -
> +        name: fdb-n-learned
> +        type: u32
> +      -
> +        name: fdb-max-learned
> +        type: u32
>    -
>      name: linkinfo-brport-attrs
>      name-prefix: ifla-brport-

Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
Jacob Keller May 3, 2024, 6:15 p.m. UTC | #2 
> -----Original Message-----
> From: Donald Hunter <donald.hunter@gmail.com>
> Sent: Friday, May 3, 2024 9:43 AM
> To: netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Paolo Abeni
> <pabeni@redhat.com>; Jiri Pirko <jiri@resnulli.us>; Keller, Jacob E
> <jacob.e.keller@intel.com>; Johannes Nixdorf <jnixdorf-oss@avm.de>; Ido
> Schimmel <idosch@nvidia.com>; Nikolay Aleksandrov <razor@blackwall.org>
> Cc: donald.hunter@redhat.com; Donald Hunter <donald.hunter@gmail.com>
> Subject: [PATCH net v1] netlink: specs: Add missing bridge linkinfo attrs
> 
> Attributes for FDB learned entries were added to the if_link netlink api
> for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
> missing attributes to the spec.
> 
> Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned
> FDB entries")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> ---
>  Documentation/netlink/specs/rt_link.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/netlink/specs/rt_link.yaml
> b/Documentation/netlink/specs/rt_link.yaml
> index 8e4d19adee8c..4e702ac8bf66 100644
> --- a/Documentation/netlink/specs/rt_link.yaml
> +++ b/Documentation/netlink/specs/rt_link.yaml
> @@ -1144,6 +1144,12 @@ attribute-sets:
>        -
>          name: mcast-querier-state
>          type: binary
> +      -
> +        name: fdb-n-learned
> +        type: u32
> +      -
> +        name: fdb-max-learned
> +        type: u32
>    -
>      name: linkinfo-brport-attrs
>      name-prefix: ifla-brport-
> --
> 2.44.0
patchwork-bot+netdevbpf@kernel.org May 7, 2024, 2:50 a.m. UTC | #3 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  3 May 2024 17:43:04 +0100 you wrote:
> Attributes for FDB learned entries were added to the if_link netlink api
> for bridge linkinfo but are missing from the rt_link.yaml spec. Add the
> missing attributes to the spec.
> 
> Fixes: ddd1ad68826d ("net: bridge: Add netlink knobs for number / max learned FDB entries")
> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net,v1] netlink: specs: Add missing bridge linkinfo attrs
    https://git.kernel.org/netdev/net/c/9adcac650618

You are awesome, thank you!
diff mbox series

Patch

diff --git a/Documentation/netlink/specs/rt_link.yaml b/Documentation/netlink/specs/rt_link.yaml
index 8e4d19adee8c..4e702ac8bf66 100644
--- a/Documentation/netlink/specs/rt_link.yaml
+++ b/Documentation/netlink/specs/rt_link.yaml
@@ -1144,6 +1144,12 @@  attribute-sets:
       -
         name: mcast-querier-state
         type: binary
+      -
+        name: fdb-n-learned
+        type: u32
+      -
+        name: fdb-max-learned
+        type: u32
   -
     name: linkinfo-brport-attrs
     name-prefix: ifla-brport-