| Message ID | d0607989f5bf64c4251259af72d8816469e8865f.1714046812.git.siyanteng@loongson.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | stmmac: Add Loongson platform support | expand |
On Thu, Apr 25, 2024 at 09:06:11PM +0800, Yanteng Si wrote: > The phy mask of gmac(and gnet) is 0. First of all the GNET PHY mask won't be zero as you setting it up to ~BIT(2) in the patch 13 yourself. Secondly the stmmac_mdio_bus_data structure instance is Z-malloced, thus it will be zeroed anyway. So the only reason why the explicit stmmac_mdio_bus_data::phy_mask zeroing would be useful is to signify the difference between the GMAC and GNET devices. But that difference could be relatively easy inferred from the code. So to speak IMO the patch has a little value. I would drop it. -Serge(y) > > Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn> > Signed-off-by: Yinggang Gu <guyinggang@loongson.cn> > Signed-off-by: Yanteng Si <siyanteng@loongson.cn> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > index 9f208f84c1e7..f7618edf4a3a 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > @@ -48,6 +48,8 @@ static int loongson_gmac_data(struct plat_stmmacenet_data *plat) > { > loongson_default_data(plat); > > + plat->mdio_bus_data->phy_mask = 0; > + > return 0; > } > > -- > 2.31.4 >
在 2024/5/4 02:28, Serge Semin 写道: > On Thu, Apr 25, 2024 at 09:06:11PM +0800, Yanteng Si wrote: >> The phy mask of gmac(and gnet) is 0. > First of all the GNET PHY mask won't be zero as you setting it up to > ~BIT(2) in the patch 13 yourself. Secondly the stmmac_mdio_bus_data > structure instance is Z-malloced, thus it will be zeroed anyway. So > the only reason why the explicit stmmac_mdio_bus_data::phy_mask > zeroing would be useful is to signify the difference between the GMAC > and GNET devices. But that difference could be relatively easy > inferred from the code. So to speak IMO the patch has a little value. > I would drop it. OK, drop it. Thanks, Yanteng
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index 9f208f84c1e7..f7618edf4a3a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -48,6 +48,8 @@ static int loongson_gmac_data(struct plat_stmmacenet_data *plat) { loongson_default_data(plat); + plat->mdio_bus_data->phy_mask = 0; + return 0; }