diff mbox series

[v4,1/3] doc: clean up usage documentation for --no-* opts

Message ID 20240503071706.78109-2-james@jamesliu.io (mailing list archive)
State Accepted
Commit 9b715ad92609f9b4ad12fa76ac649954ccdd119a
Headers show
Series advice: add "all" option to disable all hints | expand

Commit Message

James Liu May 3, 2024, 7:17 a.m. UTC
We'll be adding another option to the --no-* class of options soon.

Clean up the existing options by grouping them together in the OPTIONS
section, and adding missing ones to the SYNOPSIS.

Signed-off-by: James Liu <james@jamesliu.io>
---
 Documentation/git.txt | 14 +++++++-------
 git.c                 |  6 +++---
 2 files changed, 10 insertions(+), 10 deletions(-)

Comments

Junio C Hamano May 3, 2024, 5:30 p.m. UTC | #1
James Liu <james@jamesliu.io> writes:

> We'll be adding another option to the --no-* class of options soon.
>
> Clean up the existing options by grouping them together in the OPTIONS
> section, and adding missing ones to the SYNOPSIS.

Nice.  

> diff --git a/Documentation/git.txt b/Documentation/git.txt
> index 7a1b112a3e..7fa75350b2 100644
> --- a/Documentation/git.txt
> +++ b/Documentation/git.txt
> @@ -11,9 +11,9 @@ SYNOPSIS
>  [verse]
>  'git' [-v | --version] [-h | --help] [-C <path>] [-c <name>=<value>]
>      [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
> -    [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--bare]
> -    [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
> -    [--config-env=<name>=<envvar>] <command> [<args>]
> +    [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--no-lazy-fetch]
> +    [--no-optional-locks] [--bare] [--git-dir=<path>] [--work-tree=<path>]
> +    [--namespace=<name>] [--config-env=<name>=<envvar>] <command> [<args>]

Looks sensible.

There still are a few options (like noglob-pathspecs) missing, but
cleaning them up from this part of the documentation is totally
outside the scope of this topic (#leftoverbits -- we either make
this exhaustive, or make it clear that this is not exhaustive).

Thanks.
James Liu May 6, 2024, 1:39 a.m. UTC | #2
On Sat May 4, 2024 at 3:30 AM AEST, Junio C Hamano wrote:
> James Liu <james@jamesliu.io> writes:
>
> > We'll be adding another option to the --no-* class of options soon.
> >
> > Clean up the existing options by grouping them together in the OPTIONS
> > section, and adding missing ones to the SYNOPSIS.
>
> Nice.  
>
> > diff --git a/Documentation/git.txt b/Documentation/git.txt
> > index 7a1b112a3e..7fa75350b2 100644
> > --- a/Documentation/git.txt
> > +++ b/Documentation/git.txt
> > @@ -11,9 +11,9 @@ SYNOPSIS
> >  [verse]
> >  'git' [-v | --version] [-h | --help] [-C <path>] [-c <name>=<value>]
> >      [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
> > -    [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--bare]
> > -    [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
> > -    [--config-env=<name>=<envvar>] <command> [<args>]
> > +    [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--no-lazy-fetch]
> > +    [--no-optional-locks] [--bare] [--git-dir=<path>] [--work-tree=<path>]
> > +    [--namespace=<name>] [--config-env=<name>=<envvar>] <command> [<args>]
>
> Looks sensible.
>
> There still are a few options (like noglob-pathspecs) missing, but
> cleaning them up from this part of the documentation is totally
> outside the scope of this topic (#leftoverbits -- we either make
> this exhaustive, or make it clear that this is not exhaustive).
>
> Thanks.

I did notice noglob-pathspecs, but I wasn't sure if it came under the
same purview as the `--no-*` options (where a dash exists after "no").

Cheers,
James
diff mbox series

Patch

diff --git a/Documentation/git.txt b/Documentation/git.txt
index 7a1b112a3e..7fa75350b2 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -11,9 +11,9 @@  SYNOPSIS
 [verse]
 'git' [-v | --version] [-h | --help] [-C <path>] [-c <name>=<value>]
     [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
-    [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--bare]
-    [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
-    [--config-env=<name>=<envvar>] <command> [<args>]
+    [-p|--paginate|-P|--no-pager] [--no-replace-objects] [--no-lazy-fetch]
+    [--no-optional-locks] [--bare] [--git-dir=<path>] [--work-tree=<path>]
+    [--namespace=<name>] [--config-env=<name>=<envvar>] <command> [<args>]
 
 DESCRIPTION
 -----------
@@ -186,6 +186,10 @@  If you just want to run git as if it was started in `<path>` then use
 	This is equivalent to setting the `GIT_NO_LAZY_FETCH`
 	environment variable to `1`.
 
+--no-optional-locks::
+	Do not perform optional operations that require locks. This is
+	equivalent to setting the `GIT_OPTIONAL_LOCKS` to `0`.
+
 --literal-pathspecs::
 	Treat pathspecs literally (i.e. no globbing, no pathspec magic).
 	This is equivalent to setting the `GIT_LITERAL_PATHSPECS` environment
@@ -207,10 +211,6 @@  If you just want to run git as if it was started in `<path>` then use
 	Add "icase" magic to all pathspec. This is equivalent to setting
 	the `GIT_ICASE_PATHSPECS` environment variable to `1`.
 
---no-optional-locks::
-	Do not perform optional operations that require locks. This is
-	equivalent to setting the `GIT_OPTIONAL_LOCKS` to `0`.
-
 --list-cmds=<group>[,<group>...]::
 	List commands by group. This is an internal/experimental
 	option and may change or be removed in the future. Supported
diff --git a/git.c b/git.c
index 654d615a18..7654571b75 100644
--- a/git.c
+++ b/git.c
@@ -36,9 +36,9 @@  struct cmd_struct {
 const char git_usage_string[] =
 	N_("git [-v | --version] [-h | --help] [-C <path>] [-c <name>=<value>]\n"
 	   "           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]\n"
-	   "           [-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]\n"
-	   "           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]\n"
-	   "           [--config-env=<name>=<envvar>] <command> [<args>]");
+	   "           [-p | --paginate | -P | --no-pager] [--no-replace-objects] [--no-lazy-fetch]\n"
+	   "           [--no-optional-locks] [--bare] [--git-dir=<path>] [--work-tree=<path>]\n"
+	   "           [--namespace=<name>] [--config-env=<name>=<envvar>] <command> [<args>]");
 
 const char git_more_info_string[] =
 	N_("'git help -a' and 'git help -g' list available subcommands and some\n"