| Message ID | 20240426100716.2111688-8-zhao1.liu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/i386: Misc cleanup on KVM PV defs and outdated comments | expand |
> Update the comment to match the X86ConfidentialGuestClass > implementation. > > Suggested-by: Xiaoyao Li <xiaoyao.li@intel.com> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > --- > target/i386/confidential-guest.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/confidential-guest.h b/target/i386/confidential-guest.h > index 532e172a60b6..06d54a120227 100644 > --- a/target/i386/confidential-guest.h > +++ b/target/i386/confidential-guest.h > @@ -44,7 +44,7 @@ struct X86ConfidentialGuestClass { > /** > * x86_confidential_guest_kvm_type: > * > - * Calls #X86ConfidentialGuestClass.unplug callback of @plug_handler. > + * Calls #X86ConfidentialGuestClass.kvm_type() callback. > */ > static inline int x86_confidential_guest_kvm_type(X86ConfidentialGuest *cg) > { Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>
On 4/26/2024 6:07 PM, Zhao Liu wrote: > Update the comment to match the X86ConfidentialGuestClass > implementation. > > Suggested-by: Xiaoyao Li <xiaoyao.li@intel.com> I think it should be "Reported-by" > Signed-off-by: Zhao Liu <zhao1.liu@intel.com> > --- > target/i386/confidential-guest.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/confidential-guest.h b/target/i386/confidential-guest.h > index 532e172a60b6..06d54a120227 100644 > --- a/target/i386/confidential-guest.h > +++ b/target/i386/confidential-guest.h > @@ -44,7 +44,7 @@ struct X86ConfidentialGuestClass { > /** > * x86_confidential_guest_kvm_type: > * > - * Calls #X86ConfidentialGuestClass.unplug callback of @plug_handler. > + * Calls #X86ConfidentialGuestClass.kvm_type() callback. > */ > static inline int x86_confidential_guest_kvm_type(X86ConfidentialGuest *cg) > {
Hi Xiaoyao, On Sat, Apr 27, 2024 at 07:05:41AM +0800, Xiaoyao Li wrote: > Date: Sat, 27 Apr 2024 07:05:41 +0800 > From: Xiaoyao Li <xiaoyao.li@intel.com> > Subject: Re: [PATCH 6/6] target/i386/confidential-guest: Fix comment of > x86_confidential_guest_kvm_type() > > On 4/26/2024 6:07 PM, Zhao Liu wrote: > > Update the comment to match the X86ConfidentialGuestClass > > implementation. > > > > Suggested-by: Xiaoyao Li <xiaoyao.li@intel.com> > > I think it should be "Reported-by" > Right, let me fix and respin it. Thanks, Zhao
diff --git a/target/i386/confidential-guest.h b/target/i386/confidential-guest.h index 532e172a60b6..06d54a120227 100644 --- a/target/i386/confidential-guest.h +++ b/target/i386/confidential-guest.h @@ -44,7 +44,7 @@ struct X86ConfidentialGuestClass { /** * x86_confidential_guest_kvm_type: * - * Calls #X86ConfidentialGuestClass.unplug callback of @plug_handler. + * Calls #X86ConfidentialGuestClass.kvm_type() callback. */ static inline int x86_confidential_guest_kvm_type(X86ConfidentialGuest *cg) {
Update the comment to match the X86ConfidentialGuestClass implementation. Suggested-by: Xiaoyao Li <xiaoyao.li@intel.com> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> --- target/i386/confidential-guest.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)