diff mbox series

[1/4] dt-bindings: clock: imx8mp: Add #reset-cells property

Message ID 1714967359-27905-2-git-send-email-shengjiu.wang@nxp.com (mailing list archive)
State Superseded
Headers show
Series clk: imx: clk-audiomix: Improvement for audiomix | expand

Commit Message

Shengjiu Wang May 6, 2024, 3:49 a.m. UTC
Make audiomix block control a reset provider for
Enhanced Audio Return Channel (eARC).

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski May 6, 2024, 6:23 a.m. UTC | #1
On 06/05/2024 05:49, Shengjiu Wang wrote:
> Make audiomix block control a reset provider for
> Enhanced Audio Return Channel (eARC).

Why? Commit msg should explain that. Why suddenly this became reset
coontroller? Does it represent hardware?



Best regards,
Krzysztof
Shengjiu Wang May 6, 2024, 6:50 a.m. UTC | #2
On Mon, May 6, 2024 at 2:24 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 06/05/2024 05:49, Shengjiu Wang wrote:
> > Make audiomix block control a reset provider for
> > Enhanced Audio Return Channel (eARC).
>
> Why? Commit msg should explain that. Why suddenly this became reset
> coontroller? Does it represent hardware?
>

Yes.  The Audio BLK_CTRL contains clock distribution and gating controls,
as well as reset handling to several of the AUDIOMIX peripherals.

The register at offset 0x200 controls the EARC PHY and Controller's reset.

Best regards
Shengjiu Wang

>
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
index 0a6dc1a6e122..6588a17a7d9a 100644
--- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml
@@ -44,6 +44,9 @@  properties:
       ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8mp-clock.h
       for the full list of i.MX8MP IMX8MP_CLK_AUDIOMIX_ clock IDs.
 
+  '#reset-cells':
+    const: 1
+
 required:
   - compatible
   - reg